diff mbox

[v1,2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board

Message ID 1430041299-24874-2-git-send-email-lyz@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

LiYunzhi April 26, 2015, 9:41 a.m. UTC
rk3288-firefly board use the dwc2 usb otg controller as a host
controller and the device mode not used, so the dr_mode should be
"host" then the dwc2 usb otg controller will work at host only
mode

Signed-off-by: Yunzhi Li <lyz@rock-chips.com>

---

 arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Stuebner April 26, 2015, 10:16 a.m. UTC | #1
Hi,

Am Sonntag, 26. April 2015, 17:41:39 schrieb Yunzhi Li:
> rk3288-firefly board use the dwc2 usb otg controller as a host
> controller and the device mode not used, so the dr_mode should be
> "host" then the dwc2 usb otg controller will work at host only
> mode
> 
> Signed-off-by: Yunzhi Li <lyz@rock-chips.com>

Not sure I understand. Is this some sort of hardware limitation? Because when 
for example flashing a kernel via upgrade_tool it is working just fine as 
gadget.

If it is a software choice, this should not be made in the devicetree, as the 
dt describes the hardware alone.


Heiko


> 
> ---
> 
>  arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi
> b/arch/arm/boot/dts/rk3288-firefly.dtsi index e6f873a..a861776 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -466,6 +466,7 @@
>  };
> 
>  &usb_otg {
> +	dr_modr = "host";
>  	status = "okay";
>  };
Sergei Shtylyov April 26, 2015, 11:12 a.m. UTC | #2
Hello.

On 4/26/2015 12:41 PM, Yunzhi Li wrote:

> rk3288-firefly board use the dwc2 usb otg controller as a host
> controller and the device mode not used, so the dr_mode should be
> "host" then the dwc2 usb otg controller will work at host only
> mode

> Signed-off-by: Yunzhi Li <lyz@rock-chips.com>

> ---

>   arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
>   1 file changed, 1 insertion(+)

> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi
> index e6f873a..a861776 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -466,6 +466,7 @@
>   };
>
>   &usb_otg {
> +	dr_modr = "host";

    You meant to type "dr_mode".

WBR, Sergei
diff mbox

Patch

diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi
index e6f873a..a861776 100644
--- a/arch/arm/boot/dts/rk3288-firefly.dtsi
+++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
@@ -466,6 +466,7 @@ 
 };
 
 &usb_otg {
+	dr_modr = "host";
 	status = "okay";
 };