| Message ID | 1430219491-5076-6-git-send-email-ao2@ao2.it (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1a65864a8b443a1aa4b4225d9c4db9fca26c5661 |
| Headers | show |
On 04/28/2015 01:11 PM, Antonio Ospite wrote: > Signed-off-by: Antonio Ospite <ao2@ao2.it> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Mark Brown <broonie@kernel.org> > Cc: alsa-devel@alsa-project.org Acked-by: Lars-Peter Clausen <lars@metafoo.de> Thanks.
On Tue, Apr 28, 2015 at 01:11:24PM +0200, Antonio Ospite wrote:
> Signed-off-by: Antonio Ospite <ao2@ao2.it>
Applied, but please use subject lines reflecting the style for the
subsystem and don't send only a single patch for a series.
On Tue, 28 Apr 2015 17:00:24 +0100 Mark Brown <broonie@kernel.org> wrote: > On Tue, Apr 28, 2015 at 01:11:24PM +0200, Antonio Ospite wrote: > > Signed-off-by: Antonio Ospite <ao2@ao2.it> > > Applied, but please use subject lines reflecting the style for the > subsystem and don't send only a single patch for a series. Hi Mark, I tried to follow the subject style for the subsystem, but then I prefixed it with "trivial" to highlight that I was sending an aggregate set of unrelated patches to trivial@kernel.org, that's also why I didn't want to CC everyone on every patch: to reduce noise. Maybe involving trivial@kernel.org for changes which apply to a _specific_ subsystem is not necessary at all, next time I will just aggregate by subsystem. As a rule of thumb I will use trivial@kernel.org only for trivial changes which span different subsystems and still make sense to have in a single patch. Thanks for making me notice that. Ciao, Antonio
On Tue, Apr 28, 2015 at 11:27:58PM +0200, Antonio Ospite wrote: > I tried to follow the subject style for the subsystem, but then I > prefixed it with "trivial" to highlight that I was sending an aggregate > set of unrelated patches to trivial@kernel.org, that's also why I didn't > want to CC everyone on every patch: to reduce noise. That's not really helpful - it means that the patch is more likely to be missed and that the patch sticks out in the changelog. > Maybe involving trivial@kernel.org for changes which apply to a > _specific_ subsystem is not necessary at all, next time I will just > aggregate by subsystem. That's generally better, the expectation should be that maintainers are going to apply even trivial patches and it does make life easier if things go that way (less chance of conflicting changes for example).
diff --git a/sound/soc/codecs/adau1977.c b/sound/soc/codecs/adau1977.c index 7ad8e15..dc8ad08 100644 --- a/sound/soc/codecs/adau1977.c +++ b/sound/soc/codecs/adau1977.c @@ -202,7 +202,7 @@ static const struct snd_soc_dapm_route adau1977_dapm_routes[] = { ADAU1977_REG_DC_HPF_CAL, (x) - 1, 1, 0) #define ADAU1977_DC_SUB_SWITCH(x) \ - SOC_SINGLE("ADC" #x " DC Substraction Capture Switch", \ + SOC_SINGLE("ADC" #x " DC Subtraction Capture Switch", \ ADAU1977_REG_DC_HPF_CAL, (x) + 3, 1, 0) static const struct snd_kcontrol_new adau1977_snd_controls[] = {
Signed-off-by: Antonio Ospite <ao2@ao2.it> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Mark Brown <broonie@kernel.org> Cc: alsa-devel@alsa-project.org --- sound/soc/codecs/adau1977.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)