| Message ID | 1430761002-9327-3-git-send-email-abrestic@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/04/2015 12:36 PM, Andrew Bresticker wrote: > The mailbox controller's channel ops ought to be read-only. Update > all the mailbox drivers to make their mbox_chan_ops const as well. > > Signed-off-by: Andrew Bresticker <abrestic@chromium.org> > Cc: Jassi Brar <jassisinghbrar@gmail.com> > Cc: Suman Anna <s-anna@ti.com> > Cc: Ashwin Chaugule <ashwin.chaugule@linaro.org> > Cc: Ley Foon Tan <lftan@altera.com> Thanks, the new patch looks good. Acked-by: Suman Anna <s-anna@ti.com> > --- > Changes from v7: > - Constify all drivers' mbox_chan_ops. > No changes from v5/v6. > New for v5. > --- > drivers/mailbox/arm_mhu.c | 2 +- > drivers/mailbox/mailbox-altera.c | 2 +- > drivers/mailbox/omap-mailbox.c | 2 +- > drivers/mailbox/pcc.c | 2 +- > include/linux/mailbox_controller.h | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mailbox/arm_mhu.c b/drivers/mailbox/arm_mhu.c > index ac693c6..d9e99f9 100644 > --- a/drivers/mailbox/arm_mhu.c > +++ b/drivers/mailbox/arm_mhu.c > @@ -110,7 +110,7 @@ static void mhu_shutdown(struct mbox_chan *chan) > free_irq(mlink->irq, chan); > } > > -static struct mbox_chan_ops mhu_ops = { > +static const struct mbox_chan_ops mhu_ops = { > .send_data = mhu_send_data, > .startup = mhu_startup, > .shutdown = mhu_shutdown, > diff --git a/drivers/mailbox/mailbox-altera.c b/drivers/mailbox/mailbox-altera.c > index a266265..bb682c9 100644 > --- a/drivers/mailbox/mailbox-altera.c > +++ b/drivers/mailbox/mailbox-altera.c > @@ -285,7 +285,7 @@ static void altera_mbox_shutdown(struct mbox_chan *chan) > } > } > > -static struct mbox_chan_ops altera_mbox_ops = { > +static const struct mbox_chan_ops altera_mbox_ops = { > .send_data = altera_mbox_send_data, > .startup = altera_mbox_startup, > .shutdown = altera_mbox_shutdown, > diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c > index 0f332c1..03f8545 100644 > --- a/drivers/mailbox/omap-mailbox.c > +++ b/drivers/mailbox/omap-mailbox.c > @@ -604,7 +604,7 @@ static int omap_mbox_chan_send_data(struct mbox_chan *chan, void *data) > return ret; > } > > -static struct mbox_chan_ops omap_mbox_chan_ops = { > +static const struct mbox_chan_ops omap_mbox_chan_ops = { > .startup = omap_mbox_chan_startup, > .send_data = omap_mbox_chan_send_data, > .shutdown = omap_mbox_chan_shutdown, > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c > index 7e91d68..26d121d 100644 > --- a/drivers/mailbox/pcc.c > +++ b/drivers/mailbox/pcc.c > @@ -198,7 +198,7 @@ static int pcc_send_data(struct mbox_chan *chan, void *data) > return 0; > } > > -static struct mbox_chan_ops pcc_chan_ops = { > +static const struct mbox_chan_ops pcc_chan_ops = { > .send_data = pcc_send_data, > }; > > diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h > index d4cf96f..68c4245 100644 > --- a/include/linux/mailbox_controller.h > +++ b/include/linux/mailbox_controller.h > @@ -72,7 +72,7 @@ struct mbox_chan_ops { > */ > struct mbox_controller { > struct device *dev; > - struct mbox_chan_ops *ops; > + const struct mbox_chan_ops *ops; > struct mbox_chan *chans; > int num_chans; > bool txdone_irq; >
diff --git a/drivers/mailbox/arm_mhu.c b/drivers/mailbox/arm_mhu.c index ac693c6..d9e99f9 100644 --- a/drivers/mailbox/arm_mhu.c +++ b/drivers/mailbox/arm_mhu.c @@ -110,7 +110,7 @@ static void mhu_shutdown(struct mbox_chan *chan) free_irq(mlink->irq, chan); } -static struct mbox_chan_ops mhu_ops = { +static const struct mbox_chan_ops mhu_ops = { .send_data = mhu_send_data, .startup = mhu_startup, .shutdown = mhu_shutdown, diff --git a/drivers/mailbox/mailbox-altera.c b/drivers/mailbox/mailbox-altera.c index a266265..bb682c9 100644 --- a/drivers/mailbox/mailbox-altera.c +++ b/drivers/mailbox/mailbox-altera.c @@ -285,7 +285,7 @@ static void altera_mbox_shutdown(struct mbox_chan *chan) } } -static struct mbox_chan_ops altera_mbox_ops = { +static const struct mbox_chan_ops altera_mbox_ops = { .send_data = altera_mbox_send_data, .startup = altera_mbox_startup, .shutdown = altera_mbox_shutdown, diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c index 0f332c1..03f8545 100644 --- a/drivers/mailbox/omap-mailbox.c +++ b/drivers/mailbox/omap-mailbox.c @@ -604,7 +604,7 @@ static int omap_mbox_chan_send_data(struct mbox_chan *chan, void *data) return ret; } -static struct mbox_chan_ops omap_mbox_chan_ops = { +static const struct mbox_chan_ops omap_mbox_chan_ops = { .startup = omap_mbox_chan_startup, .send_data = omap_mbox_chan_send_data, .shutdown = omap_mbox_chan_shutdown, diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 7e91d68..26d121d 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -198,7 +198,7 @@ static int pcc_send_data(struct mbox_chan *chan, void *data) return 0; } -static struct mbox_chan_ops pcc_chan_ops = { +static const struct mbox_chan_ops pcc_chan_ops = { .send_data = pcc_send_data, }; diff --git a/include/linux/mailbox_controller.h b/include/linux/mailbox_controller.h index d4cf96f..68c4245 100644 --- a/include/linux/mailbox_controller.h +++ b/include/linux/mailbox_controller.h @@ -72,7 +72,7 @@ struct mbox_chan_ops { */ struct mbox_controller { struct device *dev; - struct mbox_chan_ops *ops; + const struct mbox_chan_ops *ops; struct mbox_chan *chans; int num_chans; bool txdone_irq;
The mailbox controller's channel ops ought to be read-only. Update all the mailbox drivers to make their mbox_chan_ops const as well. Signed-off-by: Andrew Bresticker <abrestic@chromium.org> Cc: Jassi Brar <jassisinghbrar@gmail.com> Cc: Suman Anna <s-anna@ti.com> Cc: Ashwin Chaugule <ashwin.chaugule@linaro.org> Cc: Ley Foon Tan <lftan@altera.com> --- Changes from v7: - Constify all drivers' mbox_chan_ops. No changes from v5/v6. New for v5. --- drivers/mailbox/arm_mhu.c | 2 +- drivers/mailbox/mailbox-altera.c | 2 +- drivers/mailbox/omap-mailbox.c | 2 +- drivers/mailbox/pcc.c | 2 +- include/linux/mailbox_controller.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)