diff mbox

[v4,4/7] selftest/x86: build both bitnesses

Message ID 1429656693-9937-1-git-send-email-tyler.baker@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Tyler Baker April 21, 2015, 10:51 p.m. UTC 
Using uname with the processor flag option in some cases can yield 'unknown'
so lets use the machine flag option as it is deterministic. Add a dependency
for all_32 when building on a x86 64 bit host so that both bitnesses are
built in this case.

Cc: Andy Lutomirski <luto@amacapital.net>
Acked-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
---
 tools/testing/selftests/x86/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Shuah Khan May 6, 2015, 8:20 p.m. UTC | #1 
On 04/21/2015 04:51 PM, Tyler Baker wrote:
> Using uname with the processor flag option in some cases can yield 'unknown'
> so lets use the machine flag option as it is deterministic. Add a dependency
> for all_32 when building on a x86 64 bit host so that both bitnesses are
> built in this case.
> 
> Cc: Andy Lutomirski <luto@amacapital.net>
> Acked-by: Andy Lutomirski <luto@kernel.org>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---

I will wait on this patch and other x85 patches in this series
until x86 always build 32 breaking make kselftest target.

thanks,
-- Shuah
diff mbox

Patch

diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index ddf6356..be93945 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -7,13 +7,13 @@  BINARIES_64 := $(TARGETS_C_BOTHBITS:%=%_64)
 
 CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
 
-UNAME_P := $(shell uname -p)
+UNAME_M := $(shell uname -m)
 
 # Always build 32-bit tests
 all: all_32
 
 # If we're on a 64-bit host, build 64-bit tests as well
-ifeq ($(shell uname -p),x86_64)
+ifeq ($(UNAME_M),x86_64)
 all: all_64
 endif