Message ID | 554C73A8.1030406@oracle.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, May 08, 2015 at 04:28:24PM +0800, Anand Jain wrote: > >> @@ -187,7 +187,7 @@ static int cmd_rm_dev(int argc, char **argv) > >> ret++; > >> } else if (res < 0) { > >> fprintf(stderr, > >> - "ERROR: error removing the device '%s' - %s\n", > >> + "ERROR: ioctl error removing the device '%s' - %s\n", > > > > The only difference is the strerror vs btrfs_err_str. As both ret > 0 > > and ret < 0 report some kind of error, the wording would be very similar > > so I think that one error message would fit better. I'll fix that. > > You means res not ret (above) ? Oh right, please send a patch. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/cmds-device.c b/cmds-device.c index cbb3243..1022656 100644 --- a/cmds-device.c +++ b/cmds-device.c @@ -183,7 +183,7 @@ static int cmd_rm_dev(int argc, char **argv) if (res) { const char *msg; - if (ret > 0) + if (res > 0) msg = btrfs_err_str(res); else msg = strerror(e);