| Message ID | 20150513113239.GA31617@mwanda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dan Carpenter <dan.carpenter@oracle.com> writes: > "base_irq" needs to be signed for the error handling to work. Also we > can remove the initialization because we re-assign it later. Indeed. I suppose smatch found this one with : arch/arm/mach-pxa/pxa_cplds_irqs.c:126 cplds_probe() warn: unsigned 'base_irq' is never less than zero. I still don't see which tool found the "re-assign" part ... Anyway, thanks for this, I'll queue it in pxa/fixes. Cheers. -- Robert
diff --git a/arch/arm/mach-pxa/pxa_cplds_irqs.c b/arch/arm/mach-pxa/pxa_cplds_irqs.c index f1aeb54..2385052 100644 --- a/arch/arm/mach-pxa/pxa_cplds_irqs.c +++ b/arch/arm/mach-pxa/pxa_cplds_irqs.c @@ -107,7 +107,7 @@ static int cplds_probe(struct platform_device *pdev) struct resource *res; struct cplds *fpga; int ret; - unsigned int base_irq = 0; + int base_irq; unsigned long irqflags = 0; fpga = devm_kzalloc(&pdev->dev, sizeof(*fpga), GFP_KERNEL);
"base_irq" needs to be signed for the error handling to work. Also we can remove the initialization because we re-assign it later. Fixes: aa8d6b73ea33 ('ARM: pxa: pxa_cplds: add lubbock and mainstone IO') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>