diff mbox

[PATCHv2,1/3] arm64: Mark PMU interrupt IRQF_NO_THREAD

Message ID 1430167990-12333-2-git-send-email-anders.roxell@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Anders Roxell April 27, 2015, 8:53 p.m. UTC
Mark the PMU interrupts as non-threadable, as is the case with
arch/arm: d9c3365 ARM: 7813/1: Mark pmu interupt IRQF_NO_THREAD

Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 arch/arm64/kernel/perf_event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sebastian Andrzej Siewior May 14, 2015, 3:39 p.m. UTC | #1
* Anders Roxell | 2015-04-27 22:53:08 [+0200]:

>Mark the PMU interrupts as non-threadable, as is the case with
>arch/arm: d9c3365 ARM: 7813/1: Mark pmu interupt IRQF_NO_THREAD
>
>Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Could this please go via the arm64 tree?

>---
> arch/arm64/kernel/perf_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
>index aa29ecb..70dcde6 100644
>--- a/arch/arm64/kernel/perf_event.c
>+++ b/arch/arm64/kernel/perf_event.c
>@@ -461,7 +461,7 @@ armpmu_reserve_hardware(struct arm_pmu *armpmu)
> 			}
> 
> 			err = request_irq(irq, armpmu->handle_irq,
>-					IRQF_NOBALANCING,
>+					IRQF_NOBALANCING | IRQF_NO_THREAD,
> 					"arm-pmu", armpmu);
> 			if (err) {
> 				pr_err("unable to request IRQ%d for ARM PMU counters\n",

Sebastian
Will Deacon May 14, 2015, 3:42 p.m. UTC | #2
On Thu, May 14, 2015 at 04:39:37PM +0100, Sebastian Andrzej Siewior wrote:
> * Anders Roxell | 2015-04-27 22:53:08 [+0200]:
> 
> >Mark the PMU interrupts as non-threadable, as is the case with
> >arch/arm: d9c3365 ARM: 7813/1: Mark pmu interupt IRQF_NO_THREAD
> >
> >Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> >Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> Could this please go via the arm64 tree?

I already acked it:

  https://lkml.org/lkml/2015/4/23/161

so it will be picked up for 4.2.

Will
Kevin Hilman May 14, 2015, 5:09 p.m. UTC | #3
On Thu, May 14, 2015 at 8:42 AM, Will Deacon <will.deacon@arm.com> wrote:
> On Thu, May 14, 2015 at 04:39:37PM +0100, Sebastian Andrzej Siewior wrote:
>> * Anders Roxell | 2015-04-27 22:53:08 [+0200]:
>>
>> >Mark the PMU interrupts as non-threadable, as is the case with
>> >arch/arm: d9c3365 ARM: 7813/1: Mark pmu interupt IRQF_NO_THREAD
>> >
>> >Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>> >Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>
>> Could this please go via the arm64 tree?
>
> I already acked it:
>
>   https://lkml.org/lkml/2015/4/23/161
>
> so it will be picked up for 4.2.

Which tree is at applied to?  I'm not seeing it in -next, and couldn't
find it in any branches of the arm64 tree[1].  Sorry to pester, I'm
just looking to cherry-pick it from it's proper upstream for testing
with a stable/3.18 based kernel.

Thanks,

Kevin

[1] https://git.kernel.org/cgit/linux/kernel/git/arm64/linux.git/
Will Deacon May 14, 2015, 5:10 p.m. UTC | #4
On Thu, May 14, 2015 at 06:09:23PM +0100, Kevin Hilman wrote:
> On Thu, May 14, 2015 at 8:42 AM, Will Deacon <will.deacon@arm.com> wrote:
> > On Thu, May 14, 2015 at 04:39:37PM +0100, Sebastian Andrzej Siewior wrote:
> >> * Anders Roxell | 2015-04-27 22:53:08 [+0200]:
> >>
> >> >Mark the PMU interrupts as non-threadable, as is the case with
> >> >arch/arm: d9c3365 ARM: 7813/1: Mark pmu interupt IRQF_NO_THREAD
> >> >
> >> >Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> >> >Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> >>
> >> Could this please go via the arm64 tree?
> >
> > I already acked it:
> >
> >   https://lkml.org/lkml/2015/4/23/161
> >
> > so it will be picked up for 4.2.
> 
> Which tree is at applied to?  I'm not seeing it in -next, and couldn't
> find it in any branches of the arm64 tree[1].  Sorry to pester, I'm
> just looking to cherry-pick it from it's proper upstream for testing
> with a stable/3.18 based kernel.

I don't think Catalin has started putting together our for-next/core branch
yet, but I'd expect it to appear there when he picks it up.

Will
Kevin Hilman May 14, 2015, 5:19 p.m. UTC | #5
On Thu, May 14, 2015 at 10:10 AM, Will Deacon <will.deacon@arm.com> wrote:
> On Thu, May 14, 2015 at 06:09:23PM +0100, Kevin Hilman wrote:

[...]

>> Which tree is at applied to?  I'm not seeing it in -next, and couldn't
>> find it in any branches of the arm64 tree[1].  Sorry to pester, I'm
>> just looking to cherry-pick it from it's proper upstream for testing
>> with a stable/3.18 based kernel.
>
> I don't think Catalin has started putting together our for-next/core branch
> yet, but I'd expect it to appear there when he picks it up.

Cool, thanks.

Kevin
Catalin Marinas May 14, 2015, 5:24 p.m. UTC | #6
On Thu, May 14, 2015 at 06:10:56PM +0100, Will Deacon wrote:
> On Thu, May 14, 2015 at 06:09:23PM +0100, Kevin Hilman wrote:
> > On Thu, May 14, 2015 at 8:42 AM, Will Deacon <will.deacon@arm.com> wrote:
> > > On Thu, May 14, 2015 at 04:39:37PM +0100, Sebastian Andrzej Siewior wrote:
> > >> * Anders Roxell | 2015-04-27 22:53:08 [+0200]:
> > >>
> > >> >Mark the PMU interrupts as non-threadable, as is the case with
> > >> >arch/arm: d9c3365 ARM: 7813/1: Mark pmu interupt IRQF_NO_THREAD
> > >> >
> > >> >Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > >> >Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > >> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > >>
> > >> Could this please go via the arm64 tree?
> > >
> > > I already acked it:
> > >
> > >   https://lkml.org/lkml/2015/4/23/161
> > >
> > > so it will be picked up for 4.2.
> > 
> > Which tree is at applied to?  I'm not seeing it in -next, and couldn't
> > find it in any branches of the arm64 tree[1].  Sorry to pester, I'm
> > just looking to cherry-pick it from it's proper upstream for testing
> > with a stable/3.18 based kernel.
> 
> I don't think Catalin has started putting together our for-next/core branch
> yet, but I'd expect it to appear there when he picks it up.

I'll push it out after -rc4 (i.e. next week).
diff mbox

Patch

diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index aa29ecb..70dcde6 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -461,7 +461,7 @@  armpmu_reserve_hardware(struct arm_pmu *armpmu)
 			}
 
 			err = request_irq(irq, armpmu->handle_irq,
-					IRQF_NOBALANCING,
+					IRQF_NOBALANCING | IRQF_NO_THREAD,
 					"arm-pmu", armpmu);
 			if (err) {
 				pr_err("unable to request IRQ%d for ARM PMU counters\n",