| Message ID | 1431618016-2087-8-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-05-15 0:40 GMT+09:00 Javier Martinez Canillas <javier.martinez@collabora.co.uk>: > Many Exynos devices have devices attached to their display ports. > This patch enables the needed Kconfig options to support different > configuration such as simple panel, embedded DisplayPort (eDP) to > LVDS bridges and HDMI displays. Enabling the display would be nice but for some quite long time we had issues with DRM on Exynos. exynos_defconfig has it enabled and most of boards boot fine with it. Exception is Arndale 5250: http://storage.kernelci.org/next/next-20150514/arm-exynos_defconfig/lab-khilman/boot-exynos5250-arndale.html [ 1.630290] [drm:exynos_dp_bind] *ERROR* failed: of_get_videomode() : -22 [ 1.637071] exynos-drm exynos-drm: failed to bind 145b0000.dp-controller (ops exynos_dp_ops): -22 [ 1.646504] exynos-drm exynos-drm: master bind failed: -22 [ 1.651391] exynos-drm: probe of exynos-drm failed with error -22 Anyway it is not like I am against it... just wondering. On the other hand enabling it could help in early detection of errors. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Krzysztof, On Fri, May 15, 2015 at 2:36 AM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > 2015-05-15 0:40 GMT+09:00 Javier Martinez Canillas > <javier.martinez@collabora.co.uk>: >> Many Exynos devices have devices attached to their display ports. >> This patch enables the needed Kconfig options to support different >> configuration such as simple panel, embedded DisplayPort (eDP) to >> LVDS bridges and HDMI displays. > > Enabling the display would be nice but for some quite long time we had > issues with DRM on Exynos. exynos_defconfig has it enabled and most of > boards boot fine with it. Exception is Arndale 5250: Yes, like I said in the other thread, the fact that Exynos DRM is working fine now on most boards is mostly because the bugs were exposed when the Exynos DRM options were enabled. > http://storage.kernelci.org/next/next-20150514/arm-exynos_defconfig/lab-khilman/boot-exynos5250-arndale.html > [ 1.630290] [drm:exynos_dp_bind] *ERROR* failed: of_get_videomode() : -22 > [ 1.637071] exynos-drm exynos-drm: failed to bind > 145b0000.dp-controller (ops exynos_dp_ops): -22 > [ 1.646504] exynos-drm exynos-drm: master bind failed: -22 > [ 1.651391] exynos-drm: probe of exynos-drm failed with error -22 > Ajay Kumar changed the DT bindings for the Exynos DRM Display Panel driver some time ago but it seems that the Arndale 5250 DTS was never updated. Something along the lines of commit [0] is needed. > Anyway it is not like I am against it... just wondering. On the other > hand enabling it could help in early detection of errors. > I think that not enabling these options will just make latent bugs to not be exposed. As an example I found that module auto-loading was broken for the driver of the PTN3460 eDP to LVDS bridge used in the Exynos5250 Snow Chromebook and already posted a fix [1]. I would had never found that bug if wouldn't had tried enabling these options in multi_v7 as a module. Also remember that the consumer version of these machines don't have a serial console so for users building images with multi_v7, not having display support means that the machine is pretty useless. > Best regards, > Krzysztof Best regards, Javier [0]: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0a0752c6ee58f28a29e78f1a8c38f2f1b11cba9f [1]: https://lkml.org/lkml/2015/5/14/363 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-05-15 9:58 GMT+09:00 Javier Martinez Canillas <javier@dowhile0.org>: > Hello Krzysztof, > > On Fri, May 15, 2015 at 2:36 AM, Krzysztof Kozlowski > <k.kozlowski@samsung.com> wrote: >> 2015-05-15 0:40 GMT+09:00 Javier Martinez Canillas >> <javier.martinez@collabora.co.uk>: >>> Many Exynos devices have devices attached to their display ports. >>> This patch enables the needed Kconfig options to support different >>> configuration such as simple panel, embedded DisplayPort (eDP) to >>> LVDS bridges and HDMI displays. >> >> Enabling the display would be nice but for some quite long time we had >> issues with DRM on Exynos. exynos_defconfig has it enabled and most of >> boards boot fine with it. Exception is Arndale 5250: > > Yes, like I said in the other thread, the fact that Exynos DRM is > working fine now on most boards is mostly because the bugs were > exposed when the Exynos DRM options were enabled. I saw your response in email 0/9 but let us stick to one thread. So these are my only concerns - instability in the past. >> http://storage.kernelci.org/next/next-20150514/arm-exynos_defconfig/lab-khilman/boot-exynos5250-arndale.html >> [ 1.630290] [drm:exynos_dp_bind] *ERROR* failed: of_get_videomode() : -22 >> [ 1.637071] exynos-drm exynos-drm: failed to bind >> 145b0000.dp-controller (ops exynos_dp_ops): -22 >> [ 1.646504] exynos-drm exynos-drm: master bind failed: -22 >> [ 1.651391] exynos-drm: probe of exynos-drm failed with error -22 >> > > Ajay Kumar changed the DT bindings for the Exynos DRM Display Panel > driver some time ago but it seems that the Arndale 5250 DTS was never > updated. Something along the lines of commit [0] is needed. Thanks, > >> Anyway it is not like I am against it... just wondering. On the other >> hand enabling it could help in early detection of errors. >> > > I think that not enabling these options will just make latent bugs to > not be exposed. As an example I found that module auto-loading was > broken for the driver of the PTN3460 eDP to LVDS bridge used in the > Exynos5250 Snow Chromebook and already posted a fix [1]. Right, enabling the options helps in exposing problems so they could be spotted and fixed. > I would had never found that bug if wouldn't had tried enabling these > options in multi_v7 as a module. Also remember that the consumer > version of these machines don't have a serial console so for users > building images with multi_v7, not having display support means that > the machine is pretty useless. That is indeed good reason. FWIW, I tested multi_v7 with your patches on Exynos4412 Trats2 board and it worked fine. Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index f587f2214202..e89bd6999aa3 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -402,6 +402,12 @@ CONFIG_VIDEO_RENESAS_VSP1=m # CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set CONFIG_VIDEO_ADV7180=m CONFIG_DRM=y +CONFIG_DRM_PTN3460=m +CONFIG_DRM_PS8622=m +CONFIG_DRM_EXYNOS=m +CONFIG_DRM_EXYNOS_FIMD=y +CONFIG_DRM_EXYNOS_DP=y +CONFIG_DRM_EXYNOS_HDMI=y CONFIG_DRM_RCAR_DU=m CONFIG_DRM_TEGRA=y CONFIG_DRM_PANEL_SIMPLE=y @@ -411,6 +417,7 @@ CONFIG_FB_SH_MOBILE_LCDC=y CONFIG_FB_SIMPLE=y CONFIG_FB_SH_MOBILE_MERAM=y CONFIG_BACKLIGHT_LCD_SUPPORT=y +CONFIG_LCD_PLATFORM=m CONFIG_BACKLIGHT_CLASS_DEVICE=y CONFIG_BACKLIGHT_PWM=y CONFIG_BACKLIGHT_AS3711=y
Many Exynos devices have devices attached to their display ports. This patch enables the needed Kconfig options to support different configuration such as simple panel, embedded DisplayPort (eDP) to LVDS bridges and HDMI displays. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/configs/multi_v7_defconfig | 7 +++++++ 1 file changed, 7 insertions(+)