| Message ID | 1488e7d0337944d98996c115cd0baefc@EX13-MBX-026.vmware.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 14 May 2015, Prasad Gondi wrote: > It seems like rpriv is used to set the fsp->tgt_flags originally > > > fsp->tgt_flags = rpriv->flags > > And fsp->tgt_flags are used in "fc_fcp_cmd_send" like this > > setup_timer(&fsp->timer, fc_fcp_timeout, (unsigned long)fsp); > if (rpriv->flags & FC_RP_FLAGS_REC_SUPPORTED) > fc_fcp_timer_set(fsp, get_fsp_rec_tov(fsp)); > > Main purpose of this flags used is to set the correct TimeOut Value for fc_fcp_timer. > > So is the removal of the "fsp->tgt_flags = rpriv->flags" in fc_queuecommand() is intentional? Or by mistake? > thats something I can't say - but the commit message indicated that the removal of tgt_flags was intentional. > Once we clear that out we can see whether this change make sense? > yup - many thanks ! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2015-05-15 at 09:14 +0200, Nicholas Mc Guire wrote: > On Thu, 14 May 2015, Prasad Gondi wrote: > > > It seems like rpriv is used to set the fsp->tgt_flags originally > > > > > fsp->tgt_flags = rpriv->flags > > > > And fsp->tgt_flags are used in "fc_fcp_cmd_send" like this > > > > setup_timer(&fsp->timer, fc_fcp_timeout, (unsigned long)fsp); > > if (rpriv->flags & FC_RP_FLAGS_REC_SUPPORTED) > > fc_fcp_timer_set(fsp, get_fsp_rec_tov(fsp)); > > > > Main purpose of this flags used is to set the correct TimeOut Value for fc_fcp_timer. > > > > So is the removal of the "fsp->tgt_flags = rpriv->flags" in fc_queuecommand() is intentional? Or by mistake? > > > thats something I can't say - but the commit message indicated that the > removal of tgt_flags was intentional. > It was intentional and good cleanup since now rpriv->flags is used directly with that change instead of storing in fsp->tgt_flags as it was before. > > Once we clear that out we can see whether this change make sense? > > Anycase the patch under discussion is straight forward clean up patch since it just removes a local stack variable which is not used. Thanks, Vasu -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks Vasu for the details. I agree current patch is good to go. I have no objections and it is an extension to the older patch which removed the " fsp->tgt_flags" flags. Thanks, Prasad -----Original Message----- From: vasu.dev@linux.intel.com [mailto:vasu.dev@linux.intel.com] Sent: Friday, May 15, 2015 10:10 AM To: Nicholas Mc Guire Cc: Prasad Gondi; linux-scsi@vger.kernel.org; James E.J. Bottomley; linux-kernel@vger.kernel.org; Nicholas Mc Guire; fcoe-devel@open-fcoe.org Subject: Re: [Open-FCoE] [PATCH] scsi: fix Wunused-but-set-variable buildwarning On Fri, 2015-05-15 at 09:14 +0200, Nicholas Mc Guire wrote: > On Thu, 14 May 2015, Prasad Gondi wrote: > > > It seems like rpriv is used to set the fsp->tgt_flags originally > > > > > fsp->tgt_flags = rpriv->flags > > > > And fsp->tgt_flags are used in "fc_fcp_cmd_send" like this > > > > setup_timer(&fsp->timer, fc_fcp_timeout, (unsigned long)fsp); > > if (rpriv->flags & FC_RP_FLAGS_REC_SUPPORTED) > > fc_fcp_timer_set(fsp, get_fsp_rec_tov(fsp)); > > > > Main purpose of this flags used is to set the correct TimeOut Value for fc_fcp_timer. > > > > So is the removal of the "fsp->tgt_flags = rpriv->flags" in fc_queuecommand() is intentional? Or by mistake? > > > thats something I can't say - but the commit message indicated that > the removal of tgt_flags was intentional. > It was intentional and good cleanup since now rpriv->flags is used directly with that change instead of storing in fsp->tgt_flags as it was before. > > Once we clear that out we can see whether this change make sense? > > Anycase the patch under discussion is straight forward clean up patch since it just removes a local stack variable which is not used. Thanks, Vasu
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index c438b81..fee6928 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c @@ -1792,7 +1792,6 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd) struct fc_lport *lport = shost_priv(shost); struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device)); struct fc_fcp_pkt *fsp; - struct fc_rport_libfc_priv *rpriv; int rval; int rc = 0; struct fc_stats *stats; @@ -1814,8 +1813,6 @@ int fc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc_cmd) goto out; } - rpriv = rport->dd_data; - if (!fc_fcp_lport_queue_ready(lport)) { if (lport->qfull) fc_fcp_can_queue_ramp_down(lport);