| Message ID | 3121960.dnOqT9LCth@wuerfel (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote: > The ips driver contains > > #warning "This driver has only been tested on the x86/ia64/x86_64 platforms" > > which gets printed by the compiler every time this driver gets > build for something other than those three architectures. The same > is true for most other drivers, but none of them prints a warning like > this. > > Let's remove the warning now to reduce the amount of clutter. > > FWIW, I've reviewed the driver and found a few oddities, but nothing > that needs to be fixed or that would be architecture specific. In principle I don't disagree. However this warning was a specific request of the driver writers. Since the driver is pretty much dead, I'm not sure anyone is going to check or fix it for non-intel any time soon. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 19 May 2015 06:52:52 James Bottomley wrote: > On Tue, 2015-05-19 at 15:33 +0200, Arnd Bergmann wrote: > > The ips driver contains > > > > #warning "This driver has only been tested on the x86/ia64/x86_64 platforms" > > > > which gets printed by the compiler every time this driver gets > > build for something other than those three architectures. The same > > is true for most other drivers, but none of them prints a warning like > > this. > > > > Let's remove the warning now to reduce the amount of clutter. > > > > FWIW, I've reviewed the driver and found a few oddities, but nothing > > that needs to be fixed or that would be architecture specific. > > In principle I don't disagree. However this warning was a specific > request of the driver writers. Since the driver is pretty much dead, > I'm not sure anyone is going to check or fix it for non-intel any time > soon. My main interest here is to get a clean build of ARM 'allmodconfig'. If you prefer another approach, we could also add 'depends on X86 || IA64' into Kconfig, which would also avoid that warning. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c index 7542f11d3fcd..d86673a4cdb4 100644 --- a/drivers/scsi/ips.c +++ b/drivers/scsi/ips.c @@ -206,10 +206,6 @@ module_param(ips, charp, 0); #define IPS_VERSION_HIGH IPS_VER_MAJOR_STRING "." IPS_VER_MINOR_STRING #define IPS_VERSION_LOW "." IPS_VER_BUILD_STRING " " -#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__) -#warning "This driver has only been tested on the x86/ia64/x86_64 platforms" -#endif - #define IPS_DMA_DIR(scb) ((!scb->scsi_cmd || ips_is_passthru(scb->scsi_cmd) || \ DMA_NONE == scb->scsi_cmd->sc_data_direction) ? \ PCI_DMA_BIDIRECTIONAL : \
The ips driver contains #warning "This driver has only been tested on the x86/ia64/x86_64 platforms" which gets printed by the compiler every time this driver gets build for something other than those three architectures. The same is true for most other drivers, but none of them prints a warning like this. Let's remove the warning now to reduce the amount of clutter. FWIW, I've reviewed the driver and found a few oddities, but nothing that needs to be fixed or that would be architecture specific. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- Submitted last in January, but got no reply -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html