| Message ID | 1431622863-28575-14-git-send-email-julien.grall@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 14/05/15 18:00, Julien Grall wrote: > The xenstore ring is always based on the page granularity of Xen. [...] > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -713,7 +713,7 @@ static int __init xenstored_local_init(void) > > xen_store_mfn = xen_start_info->store_mfn = > pfn_to_mfn(virt_to_phys((void *)page) >> > - PAGE_SHIFT); > + XEN_PAGE_SHIFT); This is page_to_mfn() that you adjusted in the previous patch. David
Hi David, On 19/05/15 14:59, David Vrabel wrote: > On 14/05/15 18:00, Julien Grall wrote: >> The xenstore ring is always based on the page granularity of Xen. > [...] >> --- a/drivers/xen/xenbus/xenbus_probe.c >> +++ b/drivers/xen/xenbus/xenbus_probe.c >> @@ -713,7 +713,7 @@ static int __init xenstored_local_init(void) >> >> xen_store_mfn = xen_start_info->store_mfn = >> pfn_to_mfn(virt_to_phys((void *)page) >> >> - PAGE_SHIFT); >> + XEN_PAGE_SHIFT); > > This is page_to_mfn() that you adjusted in the previous patch. Right, I think there is a couple of other places where page_to_mfn can be used. Regards,
diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index 5390a67..f99933d9 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -713,7 +713,7 @@ static int __init xenstored_local_init(void) xen_store_mfn = xen_start_info->store_mfn = pfn_to_mfn(virt_to_phys((void *)page) >> - PAGE_SHIFT); + XEN_PAGE_SHIFT); /* Next allocate a local port which xenstored can bind to */ alloc_unbound.dom = DOMID_SELF; @@ -804,7 +804,7 @@ static int __init xenbus_init(void) goto out_error; xen_store_mfn = (unsigned long)v; xen_store_interface = - xen_remap(xen_store_mfn << PAGE_SHIFT, PAGE_SIZE); + xen_remap(xen_store_mfn << XEN_PAGE_SHIFT, XEN_PAGE_SIZE); break; default: pr_warn("Xenstore state unknown\n");
The xenstore ring is always based on the page granularity of Xen. Signed-off-by: Julien Grall <julien.grall@citrix.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: David Vrabel <david.vrabel@citrix.com> --- drivers/xen/xenbus/xenbus_probe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)