| Message ID | 1431158038-3813-2-git-send-email-mcoquelin.stm32@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Michal, 2015-05-09 9:53 GMT+02:00 Maxime Coquelin <mcoquelin.stm32@gmail.com>: > When Kernel is executed in place from ROM, the symbol addresses can be > lower than the page offset. > > Tested-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> > --- > scripts/link-vmlinux.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index 86a4fe7..b055d9d 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -82,7 +82,7 @@ kallsyms() > kallsymopt="${kallsymopt} --all-symbols" > fi > > - if [ -n "${CONFIG_ARM}" ] && [ -n "${CONFIG_PAGE_OFFSET}" ]; then > + if [ -n "${CONFIG_ARM}" ] && [ -z "${CONFIG_XIP_KERNEL}" ] && [ -n "${CONFIG_PAGE_OFFSET}" ]; then > kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET" > fi > > -- > 1.9.1 > The get_maintainer.pl does not explicitly provide your name as maintainer for this file. But looking at MAINTAINERS file, I think you are the one for it. Do you confirm? If this is the case and you agree with the patch, could you consider taking it for v4.2? Thanks in advance, Maxime
Hi, Am 18.05.2015 um 13:47 schrieb Maxime Coquelin: > 2015-05-09 9:53 GMT+02:00 Maxime Coquelin <mcoquelin.stm32@gmail.com>: >> When Kernel is executed in place from ROM, the symbol addresses can be >> lower than the page offset. >> >> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> This issue was reported by Stefan Agner in 2014 for the VF610 [1], not sure if I asked already whether there should be a Reported-by line? Stefan, have you had a chance to test this patch? Back then on STM32F4 I debugged that disabling KALLSYMS works around it. Now on a different XIP target I have confirmed this patch to help show a stacktrace (my clk driver was missing some CLK_DIVIDER_ALLOW_ZEROs) ... although my earlyprintk serial output still gets stuck further down the stacktrace - probably unrelated. [ 0.000000] ------------[ cut here ]------------ [ 0.000000] WARNING: CPU: 0 PID: 0 at drivers/clk/clk-divider.c:126 divider_recalc_rate+0x2b/0x44() [ 0.000000] SYS: Zero divisor and CLK_DIVIDER_ALLOW_ZERO not set [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.1.0-rc4-next-20150519+ #23 [ 0.000000] Hardware name: XMC4000 (Device Tree Support) [ 0.000000] [<0800bd5d>] (unwind_backtrace) from [<0800b0cb>] (show_stack+0xb/0xc) [ 0.000000] [<0800b0cb>] (show_stack) from [<0800e0a5>] (warn_slowpath_common+0x55/0x78) [ 0.000000] [<0800e0a5>] (warn_slowpath_common) from [<0800e103>] (warn_slowpath_fmt+0x1b/0x24) [ 0.000000] [<0800e103>] (warn_slowpath_fmt) from [<080942e3>] (divide But this is definitely an improvement for ARMv7-M debugging, Tested-by: Andreas Färber <afaerber@suse.de> > [Hi Michal, ...] could you consider > taking it for v4.2? Regards, Andreas [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/307297.html
Dne 21.5.2015 v 07:04 Andreas Färber napsal(a): > Am 18.05.2015 um 13:47 schrieb Maxime Coquelin: > But this is definitely an improvement for ARMv7-M debugging, > > Tested-by: Andreas Färber <afaerber@suse.de> > >> [Hi Michal, ...] could you consider >> taking it for v4.2? I applied it to kbuild.git#kbuild now. Thanks, Michal
2015-05-21 7:40 GMT+02:00 Michal Marek <mmarek@suse.cz>: > Dne 21.5.2015 v 07:04 Andreas Färber napsal(a): >> Am 18.05.2015 um 13:47 schrieb Maxime Coquelin: >> But this is definitely an improvement for ARMv7-M debugging, >> >> Tested-by: Andreas Färber <afaerber@suse.de> >> >>> [Hi Michal, ...] could you consider >>> taking it for v4.2? > > I applied it to kbuild.git#kbuild now. Thanks! Maxime
Am 21.05.2015 um 01:04 schrieb Andreas Färber: > Hi, > > Am 18.05.2015 um 13:47 schrieb Maxime Coquelin: >> 2015-05-09 9:53 GMT+02:00 Maxime Coquelin <mcoquelin.stm32@gmail.com>: >>> When Kernel is executed in place from ROM, the symbol addresses can be >>> lower than the page offset. >>> >>> Tested-by: Chanwoo Choi <cw00.choi@samsung.com> >>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com> [...] > Back then on STM32F4 I debugged that disabling KALLSYMS works around it. > > Now on a different XIP target I have confirmed this patch to help show a > stacktrace (my clk driver was missing some CLK_DIVIDER_ALLOW_ZEROs) ... > although my earlyprintk serial output still gets stuck further down the > stacktrace - probably unrelated. FTR confirming my suspicion: insufficient power supply. ;) Andreas > [ 0.000000] ------------[ cut here ]------------ > [ 0.000000] WARNING: CPU: 0 PID: 0 at drivers/clk/clk-divider.c:126 > divider_recalc_rate+0x2b/0x44() > [ 0.000000] SYS: Zero divisor and CLK_DIVIDER_ALLOW_ZERO not set > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted > 4.1.0-rc4-next-20150519+ #23 > [ 0.000000] Hardware name: XMC4000 (Device Tree Support) > [ 0.000000] [<0800bd5d>] (unwind_backtrace) from [<0800b0cb>] > (show_stack+0xb/0xc) > [ 0.000000] [<0800b0cb>] (show_stack) from [<0800e0a5>] > (warn_slowpath_common+0x55/0x78) > [ 0.000000] [<0800e0a5>] (warn_slowpath_common) from [<0800e103>] > (warn_slowpath_fmt+0x1b/0x24) > [ 0.000000] [<0800e103>] (warn_slowpath_fmt) from [<080942e3>] (divide > > But this is definitely an improvement for ARMv7-M debugging, > > Tested-by: Andreas Färber <afaerber@suse.de>
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index 86a4fe7..b055d9d 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -82,7 +82,7 @@ kallsyms() kallsymopt="${kallsymopt} --all-symbols" fi - if [ -n "${CONFIG_ARM}" ] && [ -n "${CONFIG_PAGE_OFFSET}" ]; then + if [ -n "${CONFIG_ARM}" ] && [ -z "${CONFIG_XIP_KERNEL}" ] && [ -n "${CONFIG_PAGE_OFFSET}" ]; then kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET" fi