| Message ID | 1432205293-9488-12-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
On Thu, May 21, 2015 at 12:48 PM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > Regulator setup seems identical to Koelsch. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ulrich, On Thu, May 21, 2015 at 12:48 PM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > Regulator setup seems identical to Koelsch. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > --- > arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Have you tested this? You forgot to update the Makefile with: +obj-$(CONFIG_ARCH_R8A7793) += regulator-quirk-rcar-gen2.o (and add "select I2C" to "config ARCH_R8A7793"). If enabled, it will tell you if it did anything. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 21, 2015 at 7:57 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Thu, May 21, 2015 at 12:48 PM, Ulrich Hecht > <ulrich.hecht+renesas@gmail.com> wrote: >> Regulator setup seems identical to Koelsch. >> >> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> >> --- >> arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Have you tested this? Works for me. And as it turns out, that's because... > You forgot to update the Makefile with: > > +obj-$(CONFIG_ARCH_R8A7793) += regulator-quirk-rcar-gen2.o > > (and add "select I2C" to "config ARCH_R8A7793"). ...I'm testing with a multi-platform kernel config that enables r8a7791 as well. Sorry for the hassle, I'll fix it. > If enabled, it will tell you if it did anything. It does, in fact, say "IRQ2 is asserted, installing da9063/da9210 regulator quirk". CU Uli -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ulrich, On Fri, May 22, 2015 at 10:43 AM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > On Thu, May 21, 2015 at 7:57 PM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: >> On Thu, May 21, 2015 at 12:48 PM, Ulrich Hecht >> <ulrich.hecht+renesas@gmail.com> wrote: >>> Regulator setup seems identical to Koelsch. >>> >>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> >>> --- >>> arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> Have you tested this? > > Works for me. And as it turns out, that's because... > >> You forgot to update the Makefile with: >> >> +obj-$(CONFIG_ARCH_R8A7793) += regulator-quirk-rcar-gen2.o >> >> (and add "select I2C" to "config ARCH_R8A7793"). > > ...I'm testing with a multi-platform kernel config that enables > r8a7791 as well. Sorry for the hassle, I'll fix it. > >> If enabled, it will tell you if it did anything. > > It does, in fact, say "IRQ2 is asserted, installing da9063/da9210 > regulator quirk". Does it also print "IRQ2 is not asserted, removing quirk", to indicate success after masking the da9063 and da9210 interrupt sources? Thanks again! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi! On Fri, May 22, 2015 at 11:07 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Does it also print "IRQ2 is not asserted, removing quirk", to indicate success > after masking the da9063 and da9210 interrupt sources? Yep: i2c 6-0058: Masking da9063 interrupt sources i2c 6-0068: Masking da9210 interrupt sources i2c 6-0068: IRQ2 is not asserted, removing quirk CU Uli -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ulrich, On Fri, May 22, 2015 at 11:10 AM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > On Fri, May 22, 2015 at 11:07 AM, Geert Uytterhoeven > <geert@linux-m68k.org> wrote: >> Does it also print "IRQ2 is not asserted, removing quirk", to indicate success >> after masking the da9063 and da9210 interrupt sources? > > Yep: > > i2c 6-0058: Masking da9063 interrupt sources > i2c 6-0068: Masking da9210 interrupt sources > i2c 6-0068: IRQ2 is not asserted, removing quirk Thanks for testing! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c index 384e6e9..62437b5 100644 --- a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c +++ b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c @@ -123,7 +123,8 @@ static int __init rcar_gen2_regulator_quirk(void) u32 mon; if (!of_machine_is_compatible("renesas,koelsch") && - !of_machine_is_compatible("renesas,lager")) + !of_machine_is_compatible("renesas,lager") && + !of_machine_is_compatible("renesas,gose")) return -ENODEV; irqc = ioremap(IRQC_BASE, PAGE_SIZE);
Regulator setup seems identical to Koelsch. Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> --- arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)