| Message ID | 1431562378-8514-2-git-send-email-rajinikanth.pandurangan@pmcs.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/14/2015 02:12 AM, rajinikanth.pandurangan@pmcs.com wrote: > From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com> > > Description: > Driver sends the right size of the response buffer. > > Signed-off-by: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com> > --- > drivers/scsi/aacraid/aachba.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c > index 9b3dd6e..fe59b00 100644 > --- a/drivers/scsi/aacraid/aachba.c > +++ b/drivers/scsi/aacraid/aachba.c > @@ -570,7 +570,7 @@ static int aac_get_container_name(struct scsi_cmnd * scsicmd) > > status = aac_fib_send(ContainerCommand, > cmd_fibcontext, > - sizeof (struct aac_get_name), > + sizeof(struct aac_get_name_resp), Hi Rajinikanth, in aac_fib_send the size parameter is used in just one place and a comment there says "Set the size of the Fib we want to send to the adapter" From that^ it looks like it is the size of the command you sending, to the hw. Do I miss something? Cheers, Tomas > FsaNormal, > 0, 1, > (fib_callback)get_container_name_callback, > @@ -1052,7 +1052,7 @@ static int aac_get_container_serial(struct scsi_cmnd * scsicmd) > > status = aac_fib_send(ContainerCommand, > cmd_fibcontext, > - sizeof (struct aac_get_serial), > + sizeof(struct aac_get_serial_resp), > FsaNormal, > 0, 1, > (fib_callback) get_container_serial_callback, > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Tomas, Yes, you are right. The mentioned comment is right for some cases where as in some cases it should actually be the size of response buffer instead of request buffer. To "get logical device name", it request size of response buffer instead of size of the request. Thanks, -Raj P. -----Original Message----- From: Tomas Henzl [mailto:thenzl@redhat.com] Sent: Friday, May 22, 2015 6:19 AM To: Rajinikanth Pandurangan; jbottomley@parallels.com; linux-scsi@vger.kernel.org Cc: aacraid@pmc-sierra.com; Harry Yang; Rich Bono; Achim Leubner; Murthy Bhat Subject: Re: [PATCH 1/9] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS On 05/14/2015 02:12 AM, rajinikanth.pandurangan@pmcs.com wrote: > From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com> > > Description: > Driver sends the right size of the response buffer. > > Signed-off-by: Rajinikanth Pandurangan > <rajinikanth.pandurangan@pmcs.com> > --- > drivers/scsi/aacraid/aachba.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/aacraid/aachba.c > b/drivers/scsi/aacraid/aachba.c index 9b3dd6e..fe59b00 100644 > --- a/drivers/scsi/aacraid/aachba.c > +++ b/drivers/scsi/aacraid/aachba.c > @@ -570,7 +570,7 @@ static int aac_get_container_name(struct scsi_cmnd > * scsicmd) > > status = aac_fib_send(ContainerCommand, > cmd_fibcontext, > - sizeof (struct aac_get_name), > + sizeof(struct aac_get_name_resp), Hi Rajinikanth, in aac_fib_send the size parameter is used in just one place and a comment there says "Set the size of the Fib we want to send to the adapter" From that^ it looks like it is the size of the command you sending, to the hw. Do I miss something? Cheers, Tomas > FsaNormal, > 0, 1, > (fib_callback)get_container_name_callback, > @@ -1052,7 +1052,7 @@ static int aac_get_container_serial(struct > scsi_cmnd * scsicmd) > > status = aac_fib_send(ContainerCommand, > cmd_fibcontext, > - sizeof (struct aac_get_serial), > + sizeof(struct aac_get_serial_resp), > FsaNormal, > 0, 1, > (fib_callback) get_container_serial_callback, > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/14/2015 02:12 AM, rajinikanth.pandurangan@pmcs.com wrote: > From: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com> > > Description: > Driver sends the right size of the response buffer. > > Signed-off-by: Rajinikanth Pandurangan <rajinikanth.pandurangan@pmcs.com> Reviewed-by: Tomas Henzl <thenzl@redhat.com> Cheers, Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index 9b3dd6e..fe59b00 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -570,7 +570,7 @@ static int aac_get_container_name(struct scsi_cmnd * scsicmd) status = aac_fib_send(ContainerCommand, cmd_fibcontext, - sizeof (struct aac_get_name), + sizeof(struct aac_get_name_resp), FsaNormal, 0, 1, (fib_callback)get_container_name_callback, @@ -1052,7 +1052,7 @@ static int aac_get_container_serial(struct scsi_cmnd * scsicmd) status = aac_fib_send(ContainerCommand, cmd_fibcontext, - sizeof (struct aac_get_serial), + sizeof(struct aac_get_serial_resp), FsaNormal, 0, 1, (fib_callback) get_container_serial_callback,