| Message ID | 1432720398-5701-5-git-send-email-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/27, Sudeep Holla wrote: > The clocks for the CPUs are provided by SCP and are managed by this > clock driver. So the cpufreq device needs to be added only after the > clock get registered and removed when this driver is unloaded. > > This patch manages the cpufreq virtual device based on the clock > availability. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > Cc: Mike Turquette <mturquette@linaro.org> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Liviu Dudau <Liviu.Dudau@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Cc: Jon Medhurst (Tixy) <tixy@linaro.org> > Cc: linux-clk@vger.kernel.org > --- Acked-by: Stephen Boyd <sboyd@codeaurora.org> I guess there's no better place for this right now.
On 04/06/15 22:19, Stephen Boyd wrote: > On 05/27, Sudeep Holla wrote: >> The clocks for the CPUs are provided by SCP and are managed by this >> clock driver. So the cpufreq device needs to be added only after the >> clock get registered and removed when this driver is unloaded. >> >> This patch manages the cpufreq virtual device based on the clock >> availability. >> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> Cc: Mike Turquette <mturquette@linaro.org> >> Cc: Stephen Boyd <sboyd@codeaurora.org> >> Cc: Liviu Dudau <Liviu.Dudau@arm.com> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >> Cc: Jon Medhurst (Tixy) <tixy@linaro.org> >> Cc: linux-clk@vger.kernel.org >> --- > > Acked-by: Stephen Boyd <sboyd@codeaurora.org> > > Thanks > I guess there's no better place for this right now. > True Regards, Sudeep
diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c index 55bfa708a5b4..04068072f8d1 100644 --- a/drivers/clk/clk-scpi.c +++ b/drivers/clk/clk-scpi.c @@ -36,6 +36,7 @@ struct scpi_clk { #define to_scpi_clk(clk) container_of(clk, struct scpi_clk, hw) static struct scpi_ops *scpi_ops; +static struct platform_device *cpufreq_dev; static unsigned long scpi_clk_recalc_rate(struct clk_hw *hw, unsigned long parent_rate) @@ -241,6 +242,11 @@ static int scpi_clocks_remove(struct platform_device *pdev) struct device *dev = &pdev->dev; struct device_node *child, *np = dev->of_node; + if (cpufreq_dev) { + platform_device_unregister(cpufreq_dev); + cpufreq_dev = NULL; + } + for_each_available_child_of_node(np, child) of_clk_del_provider(np); scpi_ops = NULL; @@ -264,6 +270,12 @@ static int scpi_clocks_probe(struct platform_device *pdev) return ret; } } + /* Add the virtual cpufreq device */ + cpufreq_dev = platform_device_register_simple("scpi-cpufreq", + -1, NULL, 0); + if (!cpufreq_dev) + pr_warn("unable to register cpufreq device"); + return 0; }
The clocks for the CPUs are provided by SCP and are managed by this clock driver. So the cpufreq device needs to be added only after the clock get registered and removed when this driver is unloaded. This patch manages the cpufreq virtual device based on the clock availability. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Cc: Mike Turquette <mturquette@linaro.org> Cc: Stephen Boyd <sboyd@codeaurora.org> Cc: Liviu Dudau <Liviu.Dudau@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Jon Medhurst (Tixy) <tixy@linaro.org> Cc: linux-clk@vger.kernel.org --- drivers/clk/clk-scpi.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)