| Message ID | 1431499020-3912-2-git-send-email-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: > Add pwm-fan node to the Odroid-XU3 board. > > Tested-by: Markus Reichl <m.reichl@fivetechno.de> > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > Signed-off-by: Anand Moon <linux.amoon@gmail.com> Please fix the title of commit (missing colon, duplicated name of board) to: "ARM: dts: exynos5422-odroidxu3: Add pwm-fan node" Rest looks good: Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Krzysztof, Will make the changes. Thanks for the review. -Anand Moon On 13 May 2015 at 12:41, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: >> Add pwm-fan node to the Odroid-XU3 board. >> >> Tested-by: Markus Reichl <m.reichl@fivetechno.de> >> Acked-by: Lukasz Majewski <l.majewski@samsung.com> >> Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > Please fix the title of commit (missing colon, duplicated name of board) to: > "ARM: dts: exynos5422-odroidxu3: Add pwm-fan node" > > Rest looks good: > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > Best regards, > Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/13/15 16:11, Krzysztof Kozlowski wrote: > 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: >> Add pwm-fan node to the Odroid-XU3 board. >> >> Tested-by: Markus Reichl <m.reichl@fivetechno.de> >> Acked-by: Lukasz Majewski <l.majewski@samsung.com> >> Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > Please fix the title of commit (missing colon, duplicated name of board) to: > "ARM: dts: exynos5422-odroidxu3: Add pwm-fan node" > Well, I'd preferred to use the following format: "ARM: dts: add pwm-fan node for exynos5422-odroidxu3" But I can change it when I apply it ;-) > Rest looks good: > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2015-05-13 16:46 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: > Hi Krzysztof, > > Will make the changes. > > Thanks for the review. Hi Anand, Do you plan to continue working on this patchset? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
hi Krzysztof, I will send an update version soon. -Anand Moon On 14 June 2015 at 11:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > 2015-05-13 16:46 GMT+09:00 Anand Moon <linux.amoon@gmail.com>: >> Hi Krzysztof, >> >> Will make the changes. >> >> Thanks for the review. > > Hi Anand, > > Do you plan to continue working on this patchset? > > Best regards, > Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts index f0ce60b..9446e28 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts @@ -310,6 +310,15 @@ linux,default-trigger = "mmc1"; }; }; + + fan0: pwm-fan { + compatible = "pwm-fan"; + pwms = <&pwm 0 20972 0>; + cooling-min-state = <0>; + cooling-max-state = <3>; + #cooling-cells = <2>; + cooling-levels = <0 130 170 230>; + }; }; &hdmi { @@ -415,3 +424,10 @@ shunt-resistor = <10000>; }; }; + +&pwm { + pinctrl-0 = <&pwm0_out>; + pinctrl-names = "default"; + samsung,pwm-outputs = <0>; + status = "okay"; +};