| Message ID | 1434198134-8278-1-git-send-email-minipli@googlemail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8422ddf762c6168a261b5ba07eeaa2f1238ba8c2 |
| Headers | show |
On Sat, Jun 13, 2015 at 02:22:14PM +0200, Mathias Krause wrote: > Constify the ACPI device ID array, it doesn't need to be writable at > runtime. Applied, please do make an effort to CC relevant people working on the code when contributing patches (I'm not seeing any of the people working on the Intel platforms here and I'm at a bit of a loss why Rafael and Len are in the CCs).
On 15 June 2015 at 11:53, Mark Brown <broonie@kernel.org> wrote: > On Sat, Jun 13, 2015 at 02:22:14PM +0200, Mathias Krause wrote: >> Constify the ACPI device ID array, it doesn't need to be writable at >> runtime. > > Applied, please do make an effort to CC relevant people working on the > code when contributing patches (I'm not seeing any of the people working > on the Intel platforms here and I'm at a bit of a loss why Rafael and > Len are in the CCs). I used the list of people that are mentioned in the MAINTAINERS file: PXA2xx/PXA3xx SUPPORT M: Daniel Mack <daniel@zonque.org> M: Haojian Zhuang <haojian.zhuang@gmail.com> M: Robert Jarzmik <robert.jarzmik@free.fr> ... F: drivers/spi/spi-pxa2xx* Was that wrong? Who else should I've send the patch to? Maybe they should be added to the MAINTAINERS file? Rafael and Len are on Cc because of [1] -- an effort to constify all users of struct acpi_device_id. They're on Cc because of the ACPI relation. I hope that clears it up. I was uncertain how to group those changes but tried to split them up per-system. So you're seeing only the patches where you are mentioned as a maintainer. I thought it would be less noise this way for the non-ACPI related patches. It's a simple patch, after all. [1] http://www.spinics.net/lists/linux-acpi/msg58593.html Regards, Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Brown <broonie@kernel.org> writes: > On Sat, Jun 13, 2015 at 02:22:14PM +0200, Mathias Krause wrote: >> Constify the ACPI device ID array, it doesn't need to be writable at >> runtime. > > Applied, please do make an effort to CC relevant people working on the > code when contributing patches (I'm not seeing any of the people working > on the Intel platforms here Actually there is one working on Intel embedded devices, it's just that it's his dark side, see "To:" of this mail with an unusual mail address :) And Mathias, even if it's not obvious, and even obfuscated, look at this : rj@belgarion:~/mio_linux/kernel$ scripts/get_maintainer.pl --rolestats --roles --git-max-maintainers=10 --git-blame -f drivers/spi/spi-pxa2xx.c Stephen Street <stephen@streetfiresound.com> (authored lines:553/1600=35%) Mika Westerberg <mika.westerberg@linux.intel.com> (authored lines:321/1600=20%,commits:25/80=31%) These are the top 2 authors. All of this brings me to the next point : Mika, wouldn't you add yourself as spi-pxa2xx maintainer ? I can't recall if it's for Edison or another platform, but you contribute a lot to spi-pxa2xx, so wouldn't it make sense ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 15, 2015 at 07:47:37PM +0200, Mathias Krause wrote: > Was that wrong? Who else should I've send the patch to? Maybe they > should be added to the MAINTAINERS file? I'd have expected at least Jarkko (who's been actively working on the ACPI stuff for this driver) - in general MAINTAINERS is a bit unreliable, you should probably glance at git log. > Rafael and Len are on Cc because of [1] -- an effort to constify all > users of struct acpi_device_id. They're on Cc because of the ACPI > relation. I hope that clears it up. Consider if every single patch adding a const to an ACPI ID list really needs to go to the ACPI maintainers (I know I get a lot of really odd stuff registering SPI devices). > I was uncertain how to group those changes but tried to split them up > per-system. So you're seeing only the patches where you are mentioned > as a maintainer. I thought it would be less noise this way for the > non-ACPI related patches. It's a simple patch, after all. That bit is fine.
On Mon, Jun 15, 2015 at 09:12:22PM +0200, Robert Jarzmik wrote: > Actually there is one working on Intel embedded devices, it's just that it's his > dark side, see "To:" of this mail with an unusual mail address :) Huh, I'd forgotten you were working for Intel now sorry - I was mainly thinking of Mika and Jarkko here. I did remember you used to work on some of the PXA handhelds! > All of this brings me to the next point : Mika, wouldn't you add yourself as > spi-pxa2xx maintainer ? I can't recall if it's for Edison or another platform, > but you contribute a lot to spi-pxa2xx, so wouldn't it make sense ? Yeah.
On Mon, Jun 15, 2015 at 08:20:25PM +0100, Mark Brown wrote: > On Mon, Jun 15, 2015 at 09:12:22PM +0200, Robert Jarzmik wrote: > > > Actually there is one working on Intel embedded devices, it's just that it's his > > dark side, see "To:" of this mail with an unusual mail address :) > > Huh, I'd forgotten you were working for Intel now sorry - I was mainly > thinking of Mika and Jarkko here. I did remember you used to work on > some of the PXA handhelds! > > > All of this brings me to the next point : Mika, wouldn't you add yourself as > > spi-pxa2xx maintainer ? I can't recall if it's for Edison or another platform, > > but you contribute a lot to spi-pxa2xx, so wouldn't it make sense ? > > Yeah. Jarkko Nikula (CC'd) has been taking care of this driver lately. I would recommend him to be listed as a maintainer if this driver. If it is OK for him, that is. -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index f97cd42fbc22..7293d6d875c5 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1265,7 +1265,7 @@ static void cleanup(struct spi_device *spi) #ifdef CONFIG_ACPI -static struct acpi_device_id pxa2xx_spi_acpi_match[] = { +static const struct acpi_device_id pxa2xx_spi_acpi_match[] = { { "INT33C0", LPSS_LPT_SSP }, { "INT33C1", LPSS_LPT_SSP }, { "INT3430", LPSS_LPT_SSP },
Constify the ACPI device ID array, it doesn't need to be writable at runtime. Signed-off-by: Mathias Krause <minipli@googlemail.com> Cc: Daniel Mack <daniel@zonque.org> Cc: Haojian Zhuang <haojian.zhuang@gmail.com> Cc: Robert Jarzmik <robert.jarzmik@free.fr> --- This patch should go on top of spi.git#topic/pxa drivers/spi/spi-pxa2xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)