diff mbox

[dri2proto] Declare DRI2ParamXHasBufferAge

Message ID 1421665245-5994-2-git-send-email-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson Jan. 19, 2015, 11 a.m. UTC
In order for X/DDX to reuse a driver specific field of the DRI2GetBuffers
reply, we need to declare the change in semantics. To indicate that the
flags field now continues the last swap buffers count instead, we
introduce the has-buffer-age parameter.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 configure.ac  |  2 +-
 dri2proto.h   |  2 ++
 dri2proto.txt | 11 ++++++++---
 3 files changed, 11 insertions(+), 4 deletions(-)

Comments

Ian Romanick Jan. 20, 2015, 8:53 p.m. UTC | #1
On 01/19/2015 03:00 AM, Chris Wilson wrote:
> In order for X/DDX to reuse a driver specific field of the DRI2GetBuffers
> reply, we need to declare the change in semantics. To indicate that the
> flags field now continues the last swap buffers count instead, we
> introduce the has-buffer-age parameter.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

> ---
>  configure.ac  |  2 +-
>  dri2proto.h   |  2 ++
>  dri2proto.txt | 11 ++++++++---
>  3 files changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 5fadf56..9f4c4a0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1,5 +1,5 @@
>  AC_PREREQ([2.60])
> -AC_INIT([DRI2Proto], [2.8], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
> +AC_INIT([DRI2Proto], [2.9], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
>  AM_INIT_AUTOMAKE([foreign dist-bzip2])
>  
>  # Require xorg-macros: XORG_DEFAULT_OPTIONS
> diff --git a/dri2proto.h b/dri2proto.h
> index 128b807..086dc96 100644
> --- a/dri2proto.h
> +++ b/dri2proto.h
> @@ -340,6 +340,8 @@ typedef struct {
>  } xDRI2GetParamReq;
>  #define sz_xDRI2GetParamReq 12
>  
> +#define DRI2ParamXHasBufferAge 0
> +
>  typedef struct {
>      BYTE    type; /*X_Reply*/
>      BOOL    is_param_recognized;
> diff --git a/dri2proto.txt b/dri2proto.txt
> index 9921301..9daa58e 100644
> --- a/dri2proto.txt
> +++ b/dri2proto.txt
> @@ -454,9 +454,14 @@ The name of this extension is "DRI2".
>  	the screen associated with 'drawable'.
>  
>  	Parameter names in which the value of the most significant byte is
> -	0 are reserved for the X server. Currently, no such parameter names
> -	are defined. (When any such names are defined, they will be defined in
> -	this extension specification and its associated headers).
> +	0 are reserved for the X server. The complete list of known parameter
> +        names for the X server are:
> +
> +                0 - DRI2ParamXHasBufferAge
> +
> +                    Query whether the X server and DDX support passing the
> +                    buffers last swap buffer count in the flags field of
> +                    the DRI2GetBuffers reply.
>  
>  	Parameter names in which the byte's value is 1 are reserved for the
>  	DDX. Such names are private to each driver and shall be defined in the
>
Martin Peres June 16, 2015, 12:25 p.m. UTC | #2
On 20/01/15 22:53, Ian Romanick wrote:
> On 01/19/2015 03:00 AM, Chris Wilson wrote:
>> In order for X/DDX to reuse a driver specific field of the DRI2GetBuffers
>> reply, we need to declare the change in semantics. To indicate that the
>> flags field now continues the last swap buffers count instead, we
>> introduce the has-buffer-age parameter.
>>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
>

Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index 5fadf56..9f4c4a0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@ 
 AC_PREREQ([2.60])
-AC_INIT([DRI2Proto], [2.8], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
+AC_INIT([DRI2Proto], [2.9], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
 AM_INIT_AUTOMAKE([foreign dist-bzip2])
 
 # Require xorg-macros: XORG_DEFAULT_OPTIONS
diff --git a/dri2proto.h b/dri2proto.h
index 128b807..086dc96 100644
--- a/dri2proto.h
+++ b/dri2proto.h
@@ -340,6 +340,8 @@  typedef struct {
 } xDRI2GetParamReq;
 #define sz_xDRI2GetParamReq 12
 
+#define DRI2ParamXHasBufferAge 0
+
 typedef struct {
     BYTE    type; /*X_Reply*/
     BOOL    is_param_recognized;
diff --git a/dri2proto.txt b/dri2proto.txt
index 9921301..9daa58e 100644
--- a/dri2proto.txt
+++ b/dri2proto.txt
@@ -454,9 +454,14 @@  The name of this extension is "DRI2".
 	the screen associated with 'drawable'.
 
 	Parameter names in which the value of the most significant byte is
-	0 are reserved for the X server. Currently, no such parameter names
-	are defined. (When any such names are defined, they will be defined in
-	this extension specification and its associated headers).
+	0 are reserved for the X server. The complete list of known parameter
+        names for the X server are:
+
+                0 - DRI2ParamXHasBufferAge
+
+                    Query whether the X server and DDX support passing the
+                    buffers last swap buffer count in the flags field of
+                    the DRI2GetBuffers reply.
 
 	Parameter names in which the byte's value is 1 are reserved for the
 	DDX. Such names are private to each driver and shall be defined in the