| Message ID | 20150616025425.GB26592@linux (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jun 15, 2015 at 9:54 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 16-06-15, 06:01, Viresh Kumar wrote: >> On 16 June 2015 at 05:05, Rob Herring <robherring2@gmail.com> wrote: >> >> +- opp-suspend: Phandle of the OPP to set while device is suspended. >> >> + >> > >> > I would just do a bool property in the OPP you want. >> >> I will do that if you want, no big deal. > > In order to not waste any time, here is the change you suggested. Ack > the one (original change or this one) you like :) > > ------------------8<---------------------- > > From: Viresh Kumar <viresh.kumar@linaro.org> > Date: Wed, 20 May 2015 08:27:49 +0530 > Subject: [PATCH V8] OPP: Add binding for 'opp-suspend' > > On few platforms, for power efficiency, we want the device to be > configured for a specific OPP while we put the device in suspend state. > > Add an optional property in operating-points-v2 bindings for that. > > Acked-by: Nishanth Menon <nm@ti.com> > Suggested-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > V7->V8: > - opp-suspend is moved to OPPs instead of the table, and is bool now. Acked-by: Rob Herring <robh@kernel.org> > Documentation/devicetree/bindings/power/opp.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt > index 2938c52dbf84..2d4291127003 100644 > --- a/Documentation/devicetree/bindings/power/opp.txt > +++ b/Documentation/devicetree/bindings/power/opp.txt > @@ -113,6 +113,9 @@ properties. > frequency for a short duration of time limited by the device's power, current > and thermal limits. > > +- opp-suspend: Marks the OPP to be used during device suspend. Only one OPP in > + the table should have this. > + > - status: Marks the node enabled/disabled. > > Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > @@ -152,6 +155,7 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -230,6 +234,7 @@ independently. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -305,6 +310,7 @@ DVFS state together. > opp-microvolt = <970000 975000 985000>; > opp-microamp = <70000>; > clock-latency-ns = <300000>; > + opp-suspend; > }; > opp01 { > opp-hz = <1100000000>; > @@ -330,6 +336,7 @@ DVFS state together. > opp-microvolt = <1045000 1050000 1055000>; > opp-microamp = <95000>; > clock-latency-ns = <400000>; > + opp-suspend; > }; > opp11 { > opp-hz = <1400000000>; > -- > 2.4.0 >
On Tuesday, June 16, 2015 02:23:23 PM Rob Herring wrote: > On Mon, Jun 15, 2015 at 9:54 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On 16-06-15, 06:01, Viresh Kumar wrote: > >> On 16 June 2015 at 05:05, Rob Herring <robherring2@gmail.com> wrote: > >> >> +- opp-suspend: Phandle of the OPP to set while device is suspended. > >> >> + > >> > > >> > I would just do a bool property in the OPP you want. > >> > >> I will do that if you want, no big deal. > > > > In order to not waste any time, here is the change you suggested. Ack > > the one (original change or this one) you like :) > > > > ------------------8<---------------------- > > > > From: Viresh Kumar <viresh.kumar@linaro.org> > > Date: Wed, 20 May 2015 08:27:49 +0530 > > Subject: [PATCH V8] OPP: Add binding for 'opp-suspend' > > > > On few platforms, for power efficiency, we want the device to be > > configured for a specific OPP while we put the device in suspend state. > > > > Add an optional property in operating-points-v2 bindings for that. > > > > Acked-by: Nishanth Menon <nm@ti.com> > > Suggested-by: Nishanth Menon <nm@ti.com> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > V7->V8: > > - opp-suspend is moved to OPPs instead of the table, and is bool now. > > Acked-by: Rob Herring <robh@kernel.org> Thanks! Does your ACK also apply to patches [1-2/3] in this series? Rafael
On 16-06-15, 23:21, Rafael J. Wysocki wrote:
> Does your ACK also apply to patches [1-2/3] in this series?
His RBY tag is already present for 1/3 :)
@Rob: Please Ack 2/3 as well :)
On Wed, Jun 17, 2015 at 4:38 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 16-06-15, 23:21, Rafael J. Wysocki wrote: >> Does your ACK also apply to patches [1-2/3] in this series? > > His RBY tag is already present for 1/3 :) Yes, it is, sorry for overlooking that.
diff --git a/Documentation/devicetree/bindings/power/opp.txt b/Documentation/devicetree/bindings/power/opp.txt index 2938c52dbf84..2d4291127003 100644 --- a/Documentation/devicetree/bindings/power/opp.txt +++ b/Documentation/devicetree/bindings/power/opp.txt @@ -113,6 +113,9 @@ properties. frequency for a short duration of time limited by the device's power, current and thermal limits. +- opp-suspend: Marks the OPP to be used during device suspend. Only one OPP in + the table should have this. + - status: Marks the node enabled/disabled. Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. @@ -152,6 +155,7 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; + opp-suspend; }; opp01 { opp-hz = <1100000000>; @@ -230,6 +234,7 @@ independently. opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; + opp-suspend; }; opp01 { opp-hz = <1100000000>; @@ -305,6 +310,7 @@ DVFS state together. opp-microvolt = <970000 975000 985000>; opp-microamp = <70000>; clock-latency-ns = <300000>; + opp-suspend; }; opp01 { opp-hz = <1100000000>; @@ -330,6 +336,7 @@ DVFS state together. opp-microvolt = <1045000 1050000 1055000>; opp-microamp = <95000>; clock-latency-ns = <400000>; + opp-suspend; }; opp11 { opp-hz = <1400000000>;