diff mbox

[acm] acme.c: Fix IPv6 address handling in inet_any_pton

Message ID 558026A4.3090907@dev.mellanox.co.il (mailing list archive)
State Accepted
Headers show

Commit Message

Hal Rosenstock June 16, 2015, 1:37 p.m. UTC 
From: Ilya Nelkenbaum <ilyan@mellanox.com>

In inet_any_pton() routine, src_addr was used by mistake
instead of addr argument.

Signed-off-by: Ilya Nelkenbaum <ilyan@mellanox.com>
Signed-off-by: Hal Rosenstock <hal@mellanox.com>
---
 acm/src/acme.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Hefty, Sean June 17, 2015, 5:50 a.m. UTC | #1 
Thanks - applied manually

>  acm/src/acme.c |    2 +-

Path?

> diff --git a/acm/src/acme.c b/acm/src/acme.c
> index 9bf7557..d54c8b9 100644
> --- a/acm/src/acme.c
> +++ b/acm/src/acme.c
> @@ -787,7 +787,7 @@ static int inet_any_pton(char *addr, struct sockaddr

This was off by a couple hundred lines.  Can you check your branch?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hal Rosenstock June 17, 2015, 10:09 a.m. UTC | #2 
On 6/17/2015 1:50 AM, Hefty, Sean wrote:
> Thanks - applied manually

Thanks.

>>  acm/src/acme.c |    2 +-
> 
> Path?
> 
>> diff --git a/acm/src/acme.c b/acm/src/acme.c
>> index 9bf7557..d54c8b9 100644
>> --- a/acm/src/acme.c
>> +++ b/acm/src/acme.c
>> @@ -787,7 +787,7 @@ static int inet_any_pton(char *addr, struct sockaddr
> 
> This was off by a couple hundred lines.  Can you check your branch?

My bad; patch I sent was against SSA ACM. I only compared code to see it
was needed upstream and forgot to port it against upstream tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/acm/src/acme.c b/acm/src/acme.c
index 9bf7557..d54c8b9 100644
--- a/acm/src/acme.c
+++ b/acm/src/acme.c
@@ -787,7 +787,7 @@  static int inet_any_pton(char *addr, struct sockaddr *sa)
 	if (ret <= 0) {
 		sin6 = (struct sockaddr_in6 *) sa;
 		sa->sa_family = AF_INET6;
-		ret = inet_pton(AF_INET6, src_addr, &sin6->sin6_addr);
+		ret = inet_pton(AF_INET6, addr, &sin6->sin6_addr);
 	}
 
 	return ret;