| Message ID | 1434970465-12687-5-git-send-email-shobhit.kumar@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Shobhit Kumar, On 06/22/2015 04:24 PM, Shobhit Kumar wrote: > On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > entry for the same to be used by the consumer (Intel GFX) > > v2: Remove the lookup table on driver unload (Thierry) > > v3: Correct the subject line (Lee jones) This part should only describe what this is about.. Don't put this patch change history over here. Include this change history after ... Signed-off-by: Author <email> --- > CC: Samuel Ortiz <sameo@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Acked-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > --- Here you add this change history so that after applying this will not be the part of your commit description. This comment is applicable for all of your patches.
On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote: > Hi Shobhit Kumar, > > On 06/22/2015 04:24 PM, Shobhit Kumar wrote: > > >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > >entry for the same to be used by the consumer (Intel GFX) > > > >v2: Remove the lookup table on driver unload (Thierry) > > > >v3: Correct the subject line (Lee jones) > > This part should only describe what this is about.. > > Don't put this patch change history over here. > Include this change history after > ... > Signed-off-by: Author <email> > --- > > >CC: Samuel Ortiz <sameo@linux.intel.com> > >Cc: Linus Walleij <linus.walleij@linaro.org> > >Cc: Alexandre Courbot <gnurou@gmail.com> > >Cc: Thierry Reding <thierry.reding@gmail.com> > >Acked-by: Lee Jones <lee.jones@linaro.org> > >Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > >--- > > Here you add this change history so that after applying this > will not be the part of your commit description. > > This comment is applicable for all of your patches. It's honestly a per-maintainer thing and hard to tell who wants what ... Personally I do want to include the patch changelog in the commit message. -Daniel > > > -- > Best regards, > Varka Bhadram. > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, 22 Jun 2015, Daniel Vetter wrote: > On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote: > > Hi Shobhit Kumar, > > > > On 06/22/2015 04:24 PM, Shobhit Kumar wrote: > > > > >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup > > >entry for the same to be used by the consumer (Intel GFX) > > > > > >v2: Remove the lookup table on driver unload (Thierry) > > > > > >v3: Correct the subject line (Lee jones) > > > > This part should only describe what this is about.. > > > > Don't put this patch change history over here. > > Include this change history after > > ... > > Signed-off-by: Author <email> > > --- > > > > >CC: Samuel Ortiz <sameo@linux.intel.com> > > >Cc: Linus Walleij <linus.walleij@linaro.org> > > >Cc: Alexandre Courbot <gnurou@gmail.com> > > >Cc: Thierry Reding <thierry.reding@gmail.com> > > >Acked-by: Lee Jones <lee.jones@linaro.org> > > >Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > > >--- > > > > Here you add this change history so that after applying this > > will not be the part of your commit description. > > > > This comment is applicable for all of your patches. > > It's honestly a per-maintainer thing and hard to tell who wants what ... > Personally I do want to include the patch changelog in the commit message. The patch change-log should go below the '---'. There are very few (weird ;) ) Maintainers who like to see them in the commit log.
On Tue, Jun 23, 2015 at 12:49 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Mon, 22 Jun 2015, Daniel Vetter wrote: > >> On Mon, Jun 22, 2015 at 04:33:22PM +0530, Varka Bhadram wrote: >> > Hi Shobhit Kumar, >> > >> > On 06/22/2015 04:24 PM, Shobhit Kumar wrote: >> > >> > >On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup >> > >entry for the same to be used by the consumer (Intel GFX) >> > > >> > >v2: Remove the lookup table on driver unload (Thierry) >> > > >> > >v3: Correct the subject line (Lee jones) >> > >> > This part should only describe what this is about.. >> > >> > Don't put this patch change history over here. >> > Include this change history after >> > ... >> > Signed-off-by: Author <email> >> > --- >> > >> > >CC: Samuel Ortiz <sameo@linux.intel.com> >> > >Cc: Linus Walleij <linus.walleij@linaro.org> >> > >Cc: Alexandre Courbot <gnurou@gmail.com> >> > >Cc: Thierry Reding <thierry.reding@gmail.com> >> > >Acked-by: Lee Jones <lee.jones@linaro.org> >> > >Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> >> > >--- >> > >> > Here you add this change history so that after applying this >> > will not be the part of your commit description. >> > >> > This comment is applicable for all of your patches. >> >> It's honestly a per-maintainer thing and hard to tell who wants what ... >> Personally I do want to include the patch changelog in the commit message. > > The patch change-log should go below the '---'. There are very few > (weird ;) ) Maintainers who like to see them in the commit log. To satisfy everybody, for the last two patches for intel-gfx, I will keep the version history as is, for others, I will move it down as suggested. Will push all again as new series after addressing all comments. Regards Shobhit > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org ? Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index f3d918e..a00ddd9 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -25,6 +25,7 @@ #include <linux/regmap.h> #include <linux/mfd/intel_soc_pmic.h> #include <linux/gpio/machine.h> +#include <linux/pwm.h> #include "intel_soc_pmic_core.h" /* Lookup table for the Panel Enable/Disable line as GPIO signals */ @@ -37,6 +38,11 @@ static struct gpiod_lookup_table panel_gpio_table = { }, }; +/* PWM consumed by the Intel GFX */ +static struct pwm_lookup crc_pwm_lookup[] = { + PWM_LOOKUP("crystal_cove_pwm", 0, "0000:00:02.0", "pwm_backlight", 0, PWM_POLARITY_NORMAL), +}; + static int intel_soc_pmic_find_gpio_irq(struct device *dev) { struct gpio_desc *desc; @@ -99,6 +105,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, /* Add lookup table binding for Panel Control to the GPIO Chip */ gpiod_add_lookup_table(&panel_gpio_table); + /* Add lookup table for crc-pwm */ + pwm_add_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); + ret = mfd_add_devices(dev, -1, config->cell_dev, config->n_cell_devs, NULL, 0, regmap_irq_get_domain(pmic->irq_chip_data)); @@ -121,6 +130,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c) /* Remove lookup table for Panel Control from the GPIO Chip */ gpiod_remove_lookup_table(&panel_gpio_table); + /* remove crc-pwm lookup table */ + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); + mfd_remove_devices(&i2c->dev); return 0;