| Message ID | 20150621081033.10187.38630.sendpatchset@little-apple (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Magnus, Thank you for the patch. On Sunday 21 June 2015 17:10:33 Magnus Damm wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > Update the DTS to remove the now deprecated "renesas,channels-mask" > property. > > The channel information is now kept in the device driver and can easily > be determined based on the compat string. Unless I've missed something (which is entirely possibly given the late hour), the channel mask is only stored in the driver for the Gen2 CMT instances. > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> > --- > > arch/arm/boot/dts/r8a73a4.dtsi | 3 --- > arch/arm/boot/dts/r8a7740.dtsi | 3 --- > arch/arm/boot/dts/r8a7790.dtsi | 6 ------ > arch/arm/boot/dts/r8a7791.dtsi | 6 ------ > arch/arm/boot/dts/r8a7793.dtsi | 6 ------ > arch/arm/boot/dts/r8a7794.dtsi | 6 ------ > arch/arm/boot/dts/sh73a0.dtsi | 3 --- > 7 files changed, 33 deletions(-)
Hi Laurent, On Tue, Jun 23, 2015 at 7:40 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Magnus, > > Thank you for the patch. > > On Sunday 21 June 2015 17:10:33 Magnus Damm wrote: >> From: Magnus Damm <damm+renesas@opensource.se> >> >> Update the DTS to remove the now deprecated "renesas,channels-mask" >> property. >> >> The channel information is now kept in the device driver and can easily >> be determined based on the compat string. > > Unless I've missed something (which is entirely possibly given the late hour), > the channel mask is only stored in the driver for the Gen2 CMT instances. The case for sh73a0 and r8a7740 is also covered by some of the earlier patches in this series. So unless I'm mistaken the series should cover all current in-tree CMT DT users that we have. I'm not aware of any out-of-tree users. You are right that there are more unused compat strings documented, so those will break. I would be tempted in phasing those out somehow. Also, I did not spend much time cleaning up the non R-Car Gen2 cases, so in general that needs some love. Thanks! / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in
Hi Magnus, On Tuesday 23 June 2015 11:46:45 Magnus Damm wrote: > On Tue, Jun 23, 2015 at 7:40 AM, Laurent Pinchart wrote: > > On Sunday 21 June 2015 17:10:33 Magnus Damm wrote: > >> From: Magnus Damm <damm+renesas@opensource.se> > >> > >> Update the DTS to remove the now deprecated "renesas,channels-mask" > >> property. > >> > >> The channel information is now kept in the device driver and can easily > >> be determined based on the compat string. > > > > Unless I've missed something (which is entirely possibly given the late > > hour), the channel mask is only stored in the driver for the Gen2 CMT > > instances. > > The case for sh73a0 and r8a7740 is also covered by some of the earlier > patches in this series. My bad, I've missed that. We should be good then. > So unless I'm mistaken the series should cover all current in-tree CMT DT > users that we have. I'm not aware of any out-of-tree users. > > You are right that there are more unused compat strings documented, so > those will break. I would be tempted in phasing those out somehow. > Also, I did not spend much time cleaning up the non R-Car Gen2 cases, > so in general that needs some love.
--- 0009/arch/arm/boot/dts/r8a73a4.dtsi +++ work/arch/arm/boot/dts/r8a73a4.dtsi 2015-06-20 14:51:41.942366518 +0900 @@ -120,9 +120,6 @@ clocks = <&mstp3_clks R8A73A4_CLK_CMT1>; clock-names = "fck"; power-domains = <&pd_c5>; - - renesas,channels-mask = <0xff>; - status = "disabled"; }; --- 0001/arch/arm/boot/dts/r8a7740.dtsi +++ work/arch/arm/boot/dts/r8a7740.dtsi 2015-06-20 14:52:11.332366518 +0900 @@ -60,9 +60,6 @@ clocks = <&mstp3_clks R8A7740_CLK_CMT1>; clock-names = "fck"; power-domains = <&pd_c5>; - - renesas,channels-mask = <0x3f>; - status = "disabled"; }; --- 0009/arch/arm/boot/dts/r8a7790.dtsi +++ work/arch/arm/boot/dts/r8a7790.dtsi 2015-06-20 14:50:43.532366518 +0900 @@ -218,9 +218,6 @@ <0 143 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp1_clks R8A7790_CLK_CMT0>; clock-names = "fck"; - - renesas,channels-mask = <0x60>; - status = "disabled"; }; @@ -237,9 +234,6 @@ <0 127 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7790_CLK_CMT1>; clock-names = "fck"; - - renesas,channels-mask = <0xff>; - status = "disabled"; }; --- 0009/arch/arm/boot/dts/r8a7791.dtsi +++ work/arch/arm/boot/dts/r8a7791.dtsi 2015-06-20 14:51:00.622366518 +0900 @@ -199,9 +199,6 @@ <0 143 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp1_clks R8A7791_CLK_CMT0>; clock-names = "fck"; - - renesas,channels-mask = <0x60>; - status = "disabled"; }; @@ -218,9 +215,6 @@ <0 127 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7791_CLK_CMT1>; clock-names = "fck"; - - renesas,channels-mask = <0xff>; - status = "disabled"; }; --- 0009/arch/arm/boot/dts/r8a7793.dtsi +++ work/arch/arm/boot/dts/r8a7793.dtsi 2015-06-20 14:51:16.702366518 +0900 @@ -68,9 +68,6 @@ <0 143 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp1_clks R8A7793_CLK_CMT0>; clock-names = "fck"; - - renesas,channels-mask = <0x60>; - status = "disabled"; }; @@ -87,9 +84,6 @@ <0 127 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7793_CLK_CMT1>; clock-names = "fck"; - - renesas,channels-mask = <0xff>; - status = "disabled"; }; --- 0009/arch/arm/boot/dts/r8a7794.dtsi +++ work/arch/arm/boot/dts/r8a7794.dtsi 2015-06-20 14:51:29.512366518 +0900 @@ -57,9 +57,6 @@ <0 143 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp1_clks R8A7794_CLK_CMT0>; clock-names = "fck"; - - renesas,channels-mask = <0x60>; - status = "disabled"; }; @@ -76,9 +73,6 @@ <0 127 IRQ_TYPE_LEVEL_HIGH>; clocks = <&mstp3_clks R8A7794_CLK_CMT1>; clock-names = "fck"; - - renesas,channels-mask = <0xff>; - status = "disabled"; }; --- 0001/arch/arm/boot/dts/sh73a0.dtsi +++ work/arch/arm/boot/dts/sh73a0.dtsi 2015-06-20 14:51:56.502366518 +0900 @@ -84,9 +84,6 @@ clocks = <&mstp3_clks SH73A0_CLK_CMT1>; clock-names = "fck"; power-domains = <&pd_c5>; - - renesas,channels-mask = <0x3f>; - status = "disabled"; };