diff mbox

[v2] trace/events: add chip name and hwirq to irq entry tracepoint

Message ID 1435014310-2080-1-git-send-email-ankgupta@codeaurora.org (mailing list archive)
State Not Applicable, archived
Delegated to: Andy Gross
Headers show

Commit Message

Ankit Gupta June 22, 2015, 11:05 p.m. UTC 
Add chip name and hw-irq number to the trace_irq_handler_entry()
tracepoint. When tracing interrupt events the chip-name and hw-irq
numbers are stable and known in advance. This makes them a better
choice as a filtering criteria for the trace buffer dump. On the
flipside, the os-irq numbers are dynamically allocated which makes
them difficult to use for the same purpose.

Dump messages will look like:
...irq_handler_entry: irq=22 name=msm_serial0 domain=GIC hwirq=140

Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
Reviewed-by: Andy Gross <agross@codeaurora.org>
Signed-off-by: Gilad Avidov <gavidov@codeaurora.org>
Signed-off-by: Ankit Gupta <ankgupta@codeaurora.org>
---
Changes since V1:
- added reviewed by Andy Gross
---
 include/trace/events/irq.h | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

Comments

Thomas Gleixner June 23, 2015, 8:25 a.m. UTC | #1 
On Mon, 22 Jun 2015, Ankit Gupta wrote:

> Add chip name and hw-irq number to the trace_irq_handler_entry()
> tracepoint. When tracing interrupt events the chip-name and hw-irq
> numbers are stable and known in advance. This makes them a better
> choice as a filtering criteria for the trace buffer dump. On the
> flipside, the os-irq numbers are dynamically allocated which makes
> them difficult to use for the same purpose.
> 
> Dump messages will look like:
> ...irq_handler_entry: irq=22 name=msm_serial0 domain=GIC hwirq=140

I can't see the domain name being captured/printed in the code below.
 
> -	TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
> +	TP_printk("irq=%d name=%s chip_name=%s hwirq=%ld", __entry->irq,
> +	  __get_str(name), show_chip_name(__entry->irq),
> +	  show_hwirq(__entry->irq))
>  );

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ankit Gupta June 23, 2015, 3:16 p.m. UTC | #2 
> On Mon, 22 Jun 2015, Ankit Gupta wrote:
>
>> Add chip name and hw-irq number to the trace_irq_handler_entry()
>> tracepoint. When tracing interrupt events the chip-name and hw-irq
>> numbers are stable and known in advance. This makes them a better
>> choice as a filtering criteria for the trace buffer dump. On the
>> flipside, the os-irq numbers are dynamically allocated which makes
>> them difficult to use for the same purpose.
>>
>> Dump messages will look like:
>> ...irq_handler_entry: irq=22 name=msm_serial0 domain=GIC hwirq=140

>
> I can't see the domain name being captured/printed in the code below.
>
>> -	TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
>> +	TP_printk("irq=%d name=%s chip_name=%s hwirq=%ld", __entry->irq,
>> +	  __get_str(name), show_chip_name(__entry->irq),
>> +	  show_hwirq(__entry->irq))
>>  );

Thanks Thomas for your comment. Its actually printing a chipname and not
the domain. Will correct the dump message in the next patch. It will print
as follow.
...irq_handler_entry: irq=22 name=msm_serial0 Chip=GIC hwirq=140

>
> Thanks,
>
> 	tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
index 3608beb..5370075 100644
--- a/include/trace/events/irq.h
+++ b/include/trace/events/irq.h
@@ -23,6 +23,17 @@  struct softirq_action;
 			 softirq_name(HRTIMER),		\
 			 softirq_name(RCU))
 
+
+#define show_chip_name(irq)					\
+	(irq_get_irq_data(irq)					\
+			 ? irq_get_irq_data(irq)->chip->name	\
+			 : "NULL")
+
+#define show_hwirq(irq)						\
+	(irq_get_irq_data(irq)					\
+			 ? irq_get_irq_data(irq)->hwirq		\
+			 : -ENODEV)
+
 /**
  * irq_handler_entry - called immediately before the irq action handler
  * @irq: irq number
@@ -50,7 +61,9 @@  TRACE_EVENT(irq_handler_entry,
 		__assign_str(name, action->name);
 	),
 
-	TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
+	TP_printk("irq=%d name=%s chip_name=%s hwirq=%ld", __entry->irq,
+	  __get_str(name), show_chip_name(__entry->irq),
+	  show_hwirq(__entry->irq))
 );
 
 /**