| Message ID | 1435060743-5511-12-git-send-email-kishon@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 23 Jun 2015 17:28:56 +0530 Kishon Vijay Abraham I <kishon@ti.com> wrote: > The USB2 PHY2 has a different register map compared to USB2 PHY1 > to power on/off the PHY. In order to handle it, use the new compatible > string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY. > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > arch/arm/boot/dts/dra7.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index f69db70..a8ee829 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -1235,7 +1235,7 @@ > }; > > usb2_phy2: phy@4a085000 { > - compatible = "ti,omap-usb2"; > + compatible = "ti,dra7x-usb2-phy2", "ti,omap-usb2"; Why do you want to retain "ti,omap-usb2". It is not backward compatible with it right? > reg = <0x4a085000 0x400>; > ctrl-module = <&omap_control_usb2phy2>; > clocks = <&usb_phy2_always_on_clk32k>, > -- > 1.7.9.5 > cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wednesday 24 June 2015 05:37 PM, Roger Quadros wrote: > On Tue, 23 Jun 2015 17:28:56 +0530 > Kishon Vijay Abraham I <kishon@ti.com> wrote: > >> The USB2 PHY2 has a different register map compared to USB2 PHY1 >> to power on/off the PHY. In order to handle it, use the new compatible >> string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY. >> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> >> --- >> arch/arm/boot/dts/dra7.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index f69db70..a8ee829 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -1235,7 +1235,7 @@ >> }; >> >> usb2_phy2: phy@4a085000 { >> - compatible = "ti,omap-usb2"; >> + compatible = "ti,dra7x-usb2-phy2", "ti,omap-usb2"; > > Why do you want to retain "ti,omap-usb2". > It is not backward compatible with it right? The newer dtbs will anyway have "ti,dra7x-usb2-phy2", so "ti,omap-usb2" was kept just for legacy reasons. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 24 Jun 2015 18:40:31 +0530 Kishon Vijay Abraham I <kishon@ti.com> wrote: > Hi, > > On Wednesday 24 June 2015 05:37 PM, Roger Quadros wrote: > > On Tue, 23 Jun 2015 17:28:56 +0530 > > Kishon Vijay Abraham I <kishon@ti.com> wrote: > > > >> The USB2 PHY2 has a different register map compared to USB2 PHY1 > >> to power on/off the PHY. In order to handle it, use the new compatible > >> string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY. > >> > >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > >> --- > >> arch/arm/boot/dts/dra7.dtsi | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > >> index f69db70..a8ee829 100644 > >> --- a/arch/arm/boot/dts/dra7.dtsi > >> +++ b/arch/arm/boot/dts/dra7.dtsi > >> @@ -1235,7 +1235,7 @@ > >> }; > >> > >> usb2_phy2: phy@4a085000 { > >> - compatible = "ti,omap-usb2"; > >> + compatible = "ti,dra7x-usb2-phy2", "ti,omap-usb2"; > > > > Why do you want to retain "ti,omap-usb2". > > It is not backward compatible with it right? > > The newer dtbs will anyway have "ti,dra7x-usb2-phy2", so "ti,omap-usb2" was > kept just for legacy reasons. OK then. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index f69db70..a8ee829 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -1235,7 +1235,7 @@ }; usb2_phy2: phy@4a085000 { - compatible = "ti,omap-usb2"; + compatible = "ti,dra7x-usb2-phy2", "ti,omap-usb2"; reg = <0x4a085000 0x400>; ctrl-module = <&omap_control_usb2phy2>; clocks = <&usb_phy2_always_on_clk32k>,
The USB2 PHY2 has a different register map compared to USB2 PHY1 to power on/off the PHY. In order to handle it, use the new compatible string "ti,dra7x-usb2-phy2" for the second instance of USB2 PHY. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- arch/arm/boot/dts/dra7.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)