diff mbox

crypto: testmgr - don't print info about missing test for gcm-aes-aesni

Message ID 20150624141422.30488.59869.stgit@tstruk-mobl1 (mailing list archive)
State Superseded
Delegated to: Herbert Xu
Headers show

Commit Message

Tadeusz Struk June 24, 2015, 2:14 p.m. UTC
Don't print info about missing test for the internal
helper __driver-gcm-aes-aesni

Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
---
 crypto/testmgr.c |    3 +++
 1 file changed, 3 insertions(+)


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Stephan Mueller June 24, 2015, 2:44 p.m. UTC | #1
Am Mittwoch, 24. Juni 2015, 07:14:22 schrieb Tadeusz Struk:

Hi Tadeusz,

>Don't print info about missing test for the internal
>helper __driver-gcm-aes-aesni
>
>Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
>---
> crypto/testmgr.c |    3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/crypto/testmgr.c b/crypto/testmgr.c
>index 975e1ea..ad4c3e3 100644
>--- a/crypto/testmgr.c
>+++ b/crypto/testmgr.c
>@@ -2056,6 +2056,9 @@ static const struct alg_test_desc alg_test_descs[] = {
> 		.alg = "__driver-ecb-twofish-avx",
> 		.test = alg_test_null,
> 	}, {
>+		.alg = "__driver-gcm-aes-aesni",
>+		.test = alg_test_null,

Wouldn't fips_allowed = 1 be needed here?
>+	}, {
> 		.alg = "__ghash-pclmulqdqni",
> 		.test = alg_test_null,
> 		.fips_allowed = 1,
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html


Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tadeusz Struk June 24, 2015, 3:47 p.m. UTC | #2
Hi Stephan,
On 06/24/2015 07:44 AM, Stephan Mueller wrote:
>> 	}, {
>> >+		.alg = "__driver-gcm-aes-aesni",
>> >+		.test = alg_test_null,
> Wouldn't fips_allowed = 1 be needed here?

Yes, you are right. I will send a v2 soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 975e1ea..ad4c3e3 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -2056,6 +2056,9 @@  static const struct alg_test_desc alg_test_descs[] = {
 		.alg = "__driver-ecb-twofish-avx",
 		.test = alg_test_null,
 	}, {
+		.alg = "__driver-gcm-aes-aesni",
+		.test = alg_test_null,
+	}, {
 		.alg = "__ghash-pclmulqdqni",
 		.test = alg_test_null,
 		.fips_allowed = 1,