diff mbox

[V2,2/5] ipath,qib: Expose max_sge_rd correctly

Message ID 20150629213613.4188.82456.stgit@build.ogc.int (mailing list archive)
State Changes Requested
Headers show

Commit Message

Steve Wise June 29, 2015, 9:36 p.m. UTC
Applications must not assume that max_sge and max_sge_rd
are the same, Hence expose max_sge_rd correctly as well.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
 drivers/infiniband/hw/ipath/ipath_verbs.c |    1 +
 drivers/infiniband/hw/qib/qib_verbs.c     |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jason Gunthorpe June 30, 2015, 4:54 p.m. UTC | #1
On Mon, Jun 29, 2015 at 04:36:13PM -0500, Steve Wise wrote:
> Applications must not assume that max_sge and max_sge_rd
> are the same, Hence expose max_sge_rd correctly as well.

Chuck,

Now that this works, can we change NFS RDMA and get rid of the
rdma_cap_read_multi_sge stuff?

Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chuck Lever III June 30, 2015, 5 p.m. UTC | #2
On Jun 30, 2015, at 12:54 PM, Jason Gunthorpe <jgunthorpe@obsidianresearch.com> wrote:

> On Mon, Jun 29, 2015 at 04:36:13PM -0500, Steve Wise wrote:
>> Applications must not assume that max_sge and max_sge_rd
>> are the same, Hence expose max_sge_rd correctly as well.
> 
> Chuck,
> 
> Now that this works, can we change NFS RDMA and get rid of the
> rdma_cap_read_multi_sge stuff?

Steve can propose a patch, I’ll review. 

If this is NFS server only, it will have to go through Bruce’s
tree, or he can ACK it and it can go through linux-rdma.

--
Chuck Lever



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marciniszyn, Mike June 30, 2015, 5:23 p.m. UTC | #3
PiBTdWJqZWN0OiBbUEFUQ0ggVjIgMi81XSBpcGF0aCxxaWI6IEV4cG9zZSBtYXhfc2dlX3JkIGNv
cnJlY3RseQ0KPiANCj4gQXBwbGljYXRpb25zIG11c3Qgbm90IGFzc3VtZSB0aGF0IG1heF9zZ2Ug
YW5kIG1heF9zZ2VfcmQgYXJlIHRoZSBzYW1lLA0KPiBIZW5jZSBleHBvc2UgbWF4X3NnZV9yZCBj
b3JyZWN0bHkgYXMgd2VsbC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFN0ZXZlIFdpc2UgPHN3aXNl
QG9wZW5ncmlkY29tcHV0aW5nLmNvbT4NCg0KVGhhbmtzIQ0KQWNrZWQtYnk6IE1pa2UgTWFyY2lu
aXN6eW4gPG1pa2UubWFyY2luaXN6eW5AaW50ZWwuY29tPg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/hw/ipath/ipath_verbs.c b/drivers/infiniband/hw/ipath/ipath_verbs.c
index 48253b8..d958236 100644
--- a/drivers/infiniband/hw/ipath/ipath_verbs.c
+++ b/drivers/infiniband/hw/ipath/ipath_verbs.c
@@ -1521,6 +1521,7 @@  static int ipath_query_device(struct ib_device *ibdev, struct ib_device_attr *pr
 	props->max_qp = ib_ipath_max_qps;
 	props->max_qp_wr = ib_ipath_max_qp_wrs;
 	props->max_sge = ib_ipath_max_sges;
+	props->max_sge_rd = ib_ipath_max_sges;
 	props->max_cq = ib_ipath_max_cqs;
 	props->max_ah = ib_ipath_max_ahs;
 	props->max_cqe = ib_ipath_max_cqes;
diff --git a/drivers/infiniband/hw/qib/qib_verbs.c b/drivers/infiniband/hw/qib/qib_verbs.c
index a05d1a3..bc723b5 100644
--- a/drivers/infiniband/hw/qib/qib_verbs.c
+++ b/drivers/infiniband/hw/qib/qib_verbs.c
@@ -1574,6 +1574,7 @@  static int qib_query_device(struct ib_device *ibdev, struct ib_device_attr *prop
 	props->max_qp = ib_qib_max_qps;
 	props->max_qp_wr = ib_qib_max_qp_wrs;
 	props->max_sge = ib_qib_max_sges;
+	props->max_sge_rd = ib_qib_max_sges;
 	props->max_cq = ib_qib_max_cqs;
 	props->max_ah = ib_qib_max_ahs;
 	props->max_cqe = ib_qib_max_cqes;