| Message ID | 1435309330-50725-2-git-send-email-shobhit.kumar@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 26 Jun 2015, Shobhit Kumar wrote: > In case we unload and load a driver module again that is registering a > lookup table, without this it will result in multiple entries. Provide > an option to remove the lookup table on driver unload > > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > --- > v2: Ccing maintainers > v3: Correct the subject line (Lee jones) Acked-by: Lee Jones <lee.jones@linaro.org> > drivers/gpio/gpiolib.c | 13 +++++++++++++ > include/linux/gpio/machine.h | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 957ede5..9d3ea4e 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -1675,6 +1675,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table) > mutex_unlock(&gpio_lookup_lock); > } > > +/** > + * gpiod_remove_lookup_table() - unregister GPIO device consumers > + * @table: table of consumers to unregister > + */ > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) > +{ > + mutex_lock(&gpio_lookup_lock); > + > + list_del(&table->list); > + > + mutex_unlock(&gpio_lookup_lock); > +} > + > static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, > unsigned int idx, > enum gpio_lookup_flags *flags) > diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h > index e270614..c0d712d 100644 > --- a/include/linux/gpio/machine.h > +++ b/include/linux/gpio/machine.h > @@ -57,5 +57,6 @@ struct gpiod_lookup_table { > } > > void gpiod_add_lookup_table(struct gpiod_lookup_table *table); > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); > > #endif /* __LINUX_GPIO_MACHINE_H */
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 957ede5..9d3ea4e 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1675,6 +1675,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table) mutex_unlock(&gpio_lookup_lock); } +/** + * gpiod_remove_lookup_table() - unregister GPIO device consumers + * @table: table of consumers to unregister + */ +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) +{ + mutex_lock(&gpio_lookup_lock); + + list_del(&table->list); + + mutex_unlock(&gpio_lookup_lock); +} + static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, unsigned int idx, enum gpio_lookup_flags *flags) diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h index e270614..c0d712d 100644 --- a/include/linux/gpio/machine.h +++ b/include/linux/gpio/machine.h @@ -57,5 +57,6 @@ struct gpiod_lookup_table { } void gpiod_add_lookup_table(struct gpiod_lookup_table *table); +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); #endif /* __LINUX_GPIO_MACHINE_H */