diff mbox

clk: shmobile: emev2: annotate smu base pointer

Message ID 1436216708-1815-1-git-send-email-wsa@the-dreams.de (mailing list archive)
State Not Applicable
Headers show

Commit Message

Wolfram Sang July 6, 2015, 9:04 p.m. UTC 
From: Wolfram Sang <wsa+renesas@sang-engineering.com>

sparse rightfully says:

drivers/clk/shmobile/clk-emev2.c:39:14: warning: symbol 'smu_base' was not declared. Should it be static?

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/clk/shmobile/clk-emev2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd July 6, 2015, 9:48 p.m. UTC | #1 
On 07/06, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> sparse rightfully says:
> 
> drivers/clk/shmobile/clk-emev2.c:39:14: warning: symbol 'smu_base' was not declared. Should it be static?
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---

Yep, and it was already fixed and merged

$ git tag -l --contains 43f535702bb2c7b96091c0267fc105d44c18348c v4.*
v4.2-rc1
Wolfram Sang July 6, 2015, 9:52 p.m. UTC | #2 
> Yep, and it was already fixed and merged

Oops, sorry for the noise and thanks for fixing it!
diff mbox

Patch

diff --git a/drivers/clk/shmobile/clk-emev2.c b/drivers/clk/shmobile/clk-emev2.c
index 6c7c929c776557..5b60beb7d0ebce 100644
--- a/drivers/clk/shmobile/clk-emev2.c
+++ b/drivers/clk/shmobile/clk-emev2.c
@@ -34,7 +34,7 @@ 
 static DEFINE_SPINLOCK(lock);
 
 /* not pretty, but hey */
-void __iomem *smu_base;
+static void __iomem *smu_base;
 
 static void __init emev2_smu_write(unsigned long value, int offs)
 {