diff mbox

input: misc: bma150: use sign_extend32() for sign extending

Message ID 1435878781-1828-1-git-send-email-martink@posteo.de (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Martin Kepplinger-Novakovic July 2, 2015, 11:13 p.m. UTC 
Despite it's name, sign_extend32() is used for 16 bit values aswell.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
 drivers/input/misc/bma150.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Dmitry Torokhov July 6, 2015, 10:52 p.m. UTC | #1 
On Fri, Jul 03, 2015 at 01:13:01AM +0200, Martin Kepplinger wrote:
> Despite it's name, sign_extend32() is used for 16 bit values aswell.
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>

Applied, thank you.

> ---
>  drivers/input/misc/bma150.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
> index b36831c..c278049 100644
> --- a/drivers/input/misc/bma150.c
> +++ b/drivers/input/misc/bma150.c
> @@ -333,10 +333,9 @@ static void bma150_report_xyz(struct bma150_data *bma150)
>  	y = ((0xc0 & data[2]) >> 6) | (data[3] << 2);
>  	z = ((0xc0 & data[4]) >> 6) | (data[5] << 2);
>  
> -	/* sign extension */
> -	x = (s16) (x << 6) >> 6;
> -	y = (s16) (y << 6) >> 6;
> -	z = (s16) (z << 6) >> 6;
> +	x = sign_extend32(x, 9);
> +	y = sign_extend32(y, 9);
> +	z = sign_extend32(z, 9);
>  
>  	input_report_abs(bma150->input, ABS_X, x);
>  	input_report_abs(bma150->input, ABS_Y, y);
> -- 
> 2.1.4
>
diff mbox

Patch

diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
index b36831c..c278049 100644
--- a/drivers/input/misc/bma150.c
+++ b/drivers/input/misc/bma150.c
@@ -333,10 +333,9 @@  static void bma150_report_xyz(struct bma150_data *bma150)
 	y = ((0xc0 & data[2]) >> 6) | (data[3] << 2);
 	z = ((0xc0 & data[4]) >> 6) | (data[5] << 2);
 
-	/* sign extension */
-	x = (s16) (x << 6) >> 6;
-	y = (s16) (y << 6) >> 6;
-	z = (s16) (z << 6) >> 6;
+	x = sign_extend32(x, 9);
+	y = sign_extend32(y, 9);
+	z = sign_extend32(z, 9);
 
 	input_report_abs(bma150->input, ABS_X, x);
 	input_report_abs(bma150->input, ABS_Y, y);