| Message ID | 1430885131-6098-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 850346eccc2d32dd6d0a3b08e6ac127b8982c067 |
| Delegated to: | Simon Horman |
| Headers | show |
On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote: > The adv7511 IRQ is low level triggered, not falling edge triggered. The > wrong sense configuration results in no interrupt being triggered at > all, breaking hotplug detection. Fix it. > > Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Ben, would you be able to test this ? I won't have access to my Lager board > before Sunday. I only have remote access to a Lager at present, so I would need to pass this on to a colleague. Ben. > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > index 46f4c56c287c..21782e6b37f7 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > @@ -548,7 +548,7 @@ > compatible = "adi,adv7511w"; > reg = <0x39>; > interrupt-parent = <&gpio1>; > - interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>; > > adi,input-depth = <8>; > adi,input-colorspace = "rgb"; -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ben, On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote: > On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote: > > The adv7511 IRQ is low level triggered, not falling edge triggered. The > > wrong sense configuration results in no interrupt being triggered at > > all, breaking hotplug detection. Fix it. > > > > Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Ben, would you be able to test this ? I won't have access to my Lager > > board before Sunday. > > I only have remote access to a Lager at present, so I would need to pass > this on to a colleague. No worries. Worst case I'll try it when I get back home. > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > > b/arch/arm/boot/dts/r8a7790-lager.dts index 46f4c56c287c..21782e6b37f7 > > 100644 > > --- a/arch/arm/boot/dts/r8a7790-lager.dts > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > > @@ -548,7 +548,7 @@ > > compatible = "adi,adv7511w"; > > reg = <0x39>; > > interrupt-parent = <&gpio1>; > > - interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>; > > > > adi,input-depth = <8>; > > adi,input-colorspace = "rgb";
Hi Ben, Hi Laurent, On Wed, May 06, 2015 at 04:12:39PM +0300, Laurent Pinchart wrote: > Hi Ben, > > On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote: > > On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote: > > > The adv7511 IRQ is low level triggered, not falling edge triggered. The > > > wrong sense configuration results in no interrupt being triggered at > > > all, breaking hotplug detection. Fix it. > > > > > > Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@ideasonboard.com> > > > --- > > > > > > arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Ben, would you be able to test this ? I won't have access to my Lager > > > board before Sunday. > > > > I only have remote access to a Lager at present, so I would need to pass > > this on to a colleague. > > No worries. Worst case I'll try it when I get back home. Did anyone manage to test this? > > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > > > b/arch/arm/boot/dts/r8a7790-lager.dts index 46f4c56c287c..21782e6b37f7 > > > 100644 > > > --- a/arch/arm/boot/dts/r8a7790-lager.dts > > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > > > @@ -548,7 +548,7 @@ > > > compatible = "adi,adv7511w"; > > > reg = <0x39>; > > > interrupt-parent = <&gpio1>; > > > - interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > > > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>; > > > > > > adi,input-depth = <8>; > > > adi,input-colorspace = "rgb"; > > -- > Regards, > > Laurent Pinchart > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Mon, May 25, 2015 at 10:08:24AM +0900, Simon Horman wrote: > Hi Ben, Hi Laurent, > > On Wed, May 06, 2015 at 04:12:39PM +0300, Laurent Pinchart wrote: > > Hi Ben, > > > > On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote: > > > On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote: > > > > The adv7511 IRQ is low level triggered, not falling edge triggered. The > > > > wrong sense configuration results in no interrupt being triggered at > > > > all, breaking hotplug detection. Fix it. > > > > > > > > Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > > > > Signed-off-by: Laurent Pinchart > > > > <laurent.pinchart+renesas@ideasonboard.com> > > > > --- > > > > > > > > arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > Ben, would you be able to test this ? I won't have access to my Lager > > > > board before Sunday. > > > > > > I only have remote access to a Lager at present, so I would need to pass > > > this on to a colleague. > > > > No worries. Worst case I'll try it when I get back home. > > Did anyone manage to test this? This seems to have fallen through the cracks. Laurent, is there any chance you could test this? > > > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > > > > b/arch/arm/boot/dts/r8a7790-lager.dts index 46f4c56c287c..21782e6b37f7 > > > > 100644 > > > > --- a/arch/arm/boot/dts/r8a7790-lager.dts > > > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > > > > @@ -548,7 +548,7 @@ > > > > compatible = "adi,adv7511w"; > > > > reg = <0x39>; > > > > interrupt-parent = <&gpio1>; > > > > - interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > > > > + interrupts = <15 IRQ_TYPE_LEVEL_LOW>; > > > > > > > > adi,input-depth = <8>; > > > > adi,input-colorspace = "rgb"; > > > > -- > > Regards, > > > > Laurent Pinchart > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, On Tuesday 07 July 2015 09:48:09 Simon Horman wrote: > On Mon, May 25, 2015 at 10:08:24AM +0900, Simon Horman wrote: > > On Wed, May 06, 2015 at 04:12:39PM +0300, Laurent Pinchart wrote: > >> On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote: > >>> On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote: > >>>> The adv7511 IRQ is low level triggered, not falling edge triggered. > >>>> The wrong sense configuration results in no interrupt being > >>>> triggered at all, breaking hotplug detection. Fix it. > >>>> > >>>> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > >>>> Signed-off-by: Laurent Pinchart > >>>> <laurent.pinchart+renesas@ideasonboard.com> > >>>> --- > >>>> > >>>> arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> Ben, would you be able to test this ? I won't have access to my > >>>> Lager board before Sunday. > >>> > >>> I only have remote access to a Lager at present, so I would need to > >> pass this on to a colleague. > >> > >> No worries. Worst case I'll try it when I get back home. > > > > Did anyone manage to test this? > > This seems to have fallen through the cracks. It did indeed. There seems to be many cracks these days, must be the season. > Laurent, is there any chance you could test this? Tested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > >>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > >>>> b/arch/arm/boot/dts/r8a7790-lager.dts index > >>>> 46f4c56c287c..21782e6b37f7 > >>>> 100644 > >>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts > >>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts > >>>> @@ -548,7 +548,7 @@ > >>>> compatible = "adi,adv7511w"; > >>>> reg = <0x39>; > >>>> interrupt-parent = <&gpio1>; > >>>> - interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > >>>> + interrupts = <15 IRQ_TYPE_LEVEL_LOW>; > >>>> > >>>> adi,input-depth = <8>; > >>>> adi,input-colorspace = "rgb";
On Thu, Jul 16, 2015 at 02:29:04PM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Tuesday 07 July 2015 09:48:09 Simon Horman wrote: > > On Mon, May 25, 2015 at 10:08:24AM +0900, Simon Horman wrote: > > > On Wed, May 06, 2015 at 04:12:39PM +0300, Laurent Pinchart wrote: > > >> On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote: > > >>> On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote: > > >>>> The adv7511 IRQ is low level triggered, not falling edge triggered. > > >>>> The wrong sense configuration results in no interrupt being > > >>>> triggered at all, breaking hotplug detection. Fix it. > > >>>> > > >>>> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > > >>>> Signed-off-by: Laurent Pinchart > > >>>> <laurent.pinchart+renesas@ideasonboard.com> > > >>>> --- > > >>>> > > >>>> arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>>> > > >>>> Ben, would you be able to test this ? I won't have access to my > > >>>> Lager board before Sunday. > > >>> > > >>> I only have remote access to a Lager at present, so I would need to > > >> pass this on to a colleague. > > >> > > >> No worries. Worst case I'll try it when I get back home. > > > > > > Did anyone manage to test this? > > > > This seems to have fallen through the cracks. > > It did indeed. There seems to be many cracks these days, must be the season. > > > Laurent, is there any chance you could test this? > > Tested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Thanks. Shall I queue it up as a fix with the following tag? Fixes: fd25cdd15b7f ("ARM: shmobile: lager: Add DU HDMI output support") > > > >>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > > >>>> b/arch/arm/boot/dts/r8a7790-lager.dts index > > >>>> 46f4c56c287c..21782e6b37f7 > > >>>> 100644 > > >>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts > > >>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts > > >>>> @@ -548,7 +548,7 @@ > > >>>> compatible = "adi,adv7511w"; > > >>>> reg = <0x39>; > > >>>> interrupt-parent = <&gpio1>; > > >>>> - interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > > >>>> + interrupts = <15 IRQ_TYPE_LEVEL_LOW>; > > >>>> > > >>>> adi,input-depth = <8>; > > >>>> adi,input-colorspace = "rgb"; > > -- > Regards, > > Laurent Pinchart > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon, On Friday 17 July 2015 09:03:11 Simon Horman wrote: > On Thu, Jul 16, 2015 at 02:29:04PM +0300, Laurent Pinchart wrote: > > On Tuesday 07 July 2015 09:48:09 Simon Horman wrote: > >> On Mon, May 25, 2015 at 10:08:24AM +0900, Simon Horman wrote: > >>> On Wed, May 06, 2015 at 04:12:39PM +0300, Laurent Pinchart wrote: > >>>> On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote: > >>>>> On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote: > >>>>>> The adv7511 IRQ is low level triggered, not falling edge triggered. > >>>>>> The wrong sense configuration results in no interrupt being > >>>>>> triggered at all, breaking hotplug detection. Fix it. > >>>>>> > >>>>>> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > >>>>>> Signed-off-by: Laurent Pinchart > >>>>>> <laurent.pinchart+renesas@ideasonboard.com> > >>>>>> --- > >>>>>> > >>>>>> arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>>> > >>>>>> Ben, would you be able to test this ? I won't have access to my > >>>>>> Lager board before Sunday. > >>>>> > >>>>> I only have remote access to a Lager at present, so I would need to > >>>> > >>>> pass this on to a colleague. > >>>> > >>>> No worries. Worst case I'll try it when I get back home. > >>> > >>> Did anyone manage to test this? > >> > >> This seems to have fallen through the cracks. > > > > It did indeed. There seems to be many cracks these days, must be the > > season. > > > >> Laurent, is there any chance you could test this? > > > > Tested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Thanks. > > Shall I queue it up as a fix with the following tag? > > Fixes: fd25cdd15b7f ("ARM: shmobile: lager: Add DU HDMI output support") It's a related fix, but I don't think a fixes tag is appropriate given that the above commit doesn't introduce a regression. > >>>>>> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > >>>>>> b/arch/arm/boot/dts/r8a7790-lager.dts index > >>>>>> 46f4c56c287c..21782e6b37f7 > >>>>>> 100644 > >>>>>> --- a/arch/arm/boot/dts/r8a7790-lager.dts > >>>>>> +++ b/arch/arm/boot/dts/r8a7790-lager.dts > >>>>>> @@ -548,7 +548,7 @@ > >>>>>> > >>>>>> compatible = "adi,adv7511w"; > >>>>>> reg = <0x39>; > >>>>>> interrupt-parent = <&gpio1>; > >>>>>> > >>>>>> - interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > >>>>>> + interrupts = <15 IRQ_TYPE_LEVEL_LOW>; > >>>>>> > >>>>>> adi,input-depth = <8>; > >>>>>> adi,input-colorspace = "rgb";
On Fri, Jul 17, 2015 at 09:31:24AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Friday 17 July 2015 09:03:11 Simon Horman wrote: > > On Thu, Jul 16, 2015 at 02:29:04PM +0300, Laurent Pinchart wrote: > > > On Tuesday 07 July 2015 09:48:09 Simon Horman wrote: > > >> On Mon, May 25, 2015 at 10:08:24AM +0900, Simon Horman wrote: > > >>> On Wed, May 06, 2015 at 04:12:39PM +0300, Laurent Pinchart wrote: > > >>>> On Wednesday 06 May 2015 12:34:34 Ben Hutchings wrote: > > >>>>> On Wed, 2015-05-06 at 07:05 +0300, Laurent Pinchart wrote: > > >>>>>> The adv7511 IRQ is low level triggered, not falling edge triggered. > > >>>>>> The wrong sense configuration results in no interrupt being > > >>>>>> triggered at all, breaking hotplug detection. Fix it. > > >>>>>> > > >>>>>> Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> > > >>>>>> Signed-off-by: Laurent Pinchart > > >>>>>> <laurent.pinchart+renesas@ideasonboard.com> > > >>>>>> --- > > >>>>>> > > >>>>>> arch/arm/boot/dts/r8a7790-lager.dts | 2 +- > > >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>>>>> > > >>>>>> Ben, would you be able to test this ? I won't have access to my > > >>>>>> Lager board before Sunday. > > >>>>> > > >>>>> I only have remote access to a Lager at present, so I would need to > > >>>> > > >>>> pass this on to a colleague. > > >>>> > > >>>> No worries. Worst case I'll try it when I get back home. > > >>> > > >>> Did anyone manage to test this? > > >> > > >> This seems to have fallen through the cracks. > > > > > > It did indeed. There seems to be many cracks these days, must be the > > > season. > > > > > >> Laurent, is there any chance you could test this? > > > > > > Tested-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > > > Thanks. > > > > Shall I queue it up as a fix with the following tag? > > > > Fixes: fd25cdd15b7f ("ARM: shmobile: lager: Add DU HDMI output support") > > It's a related fix, but I don't think a fixes tag is appropriate given that > the above commit doesn't introduce a regression. Ok, I'll just queue it up as a regular-non-fix patch. Most likely early next week. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index 46f4c56c287c..21782e6b37f7 100644 --- a/arch/arm/boot/dts/r8a7790-lager.dts +++ b/arch/arm/boot/dts/r8a7790-lager.dts @@ -548,7 +548,7 @@ compatible = "adi,adv7511w"; reg = <0x39>; interrupt-parent = <&gpio1>; - interrupts = <15 IRQ_TYPE_EDGE_FALLING>; + interrupts = <15 IRQ_TYPE_LEVEL_LOW>; adi,input-depth = <8>; adi,input-colorspace = "rgb";
The adv7511 IRQ is low level triggered, not falling edge triggered. The wrong sense configuration results in no interrupt being triggered at all, breaking hotplug detection. Fix it. Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Ben, would you be able to test this ? I won't have access to my Lager board before Sunday.