diff mbox

Intel Baytrail Linux Audio

Message ID 20150708221745.f72dcbec9c96eb86ce0cbfc2@ao2.it (mailing list archive)
State Superseded
Headers show

Commit Message

Antonio Ospite July 8, 2015, 8:17 p.m. UTC
On Wed, 08 Jul 2015 12:32:17 -0400
Tyler Yeomans <tyeo098@gmail.com> wrote:

> Antonio,
> 
> Hmm...
> I have been running the driver like so:
> (from sound/soc/intel/common/sst-acpi.c)
> static struct sst_acpi_desc sst_acpi_baytrail_desc = {
>      .drv_name = "baytrail-pcm-audio",
>      .machines = baytrail_machines,
>      .resindex_lpe_base = 0,
>      .resindex_pcicfg_base = 1,
>      .resindex_fw_base = 2,
> *    .irqindex_host_ipc = 0,*
>      .sst_id = SST_DEV_ID_BYT,
>      .resindex_dma_base = -1,
> };
> 
> Which is what the patch at 
> https://bugzilla.kernel.org/attachment.cgi?id=155341 says to do.
>

Ah, sorry, the info from that bug report is outdated, for the
snd-intel-sst-acpi you have to change
sound/soc/intel/atom/sst/sst_acpi.c:




I didn't have to do that because I fixed the DSDT.

> However I also noticed in this file that its looking for the wrong 
> firmware:
> static struct sst_acpi_mach baytrail_machines[] = {
> *{ "10EC5640", "byt-rt5640", "intel/fw_sst_0f28.bin-48kHz_i2s_master" },*
>      { "193C9890", "byt-max98090", 
> "intel/fw_sst_0f28.bin-48kHz_i2s_master" },
>      {}
> };
> 
> Which will not point to the SSP0 firmware uploaded by Vinod.
> 

Just to recap: make sure to use the snd-intel-sst-acpi driver instead
of snd-soc-sst-acpi as explained earlier in this thread:
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/094418.html

As a quick and dirty way to do it you can remove snd-soc-sst-acpi.ko
from the modules installation dir.

A more robust solution would be to blacklist snd-soc-sst-acpi.

Ciao,
   Antonio

Comments

tyeo098@gmail.com July 8, 2015, 8:24 p.m. UTC | #1
Antonio,

Thanks for the update.
Unfortunately I'm away from the device right now but ill try that first
thing in the morning.

I do recall blacklisting the module so only the Intel module loads however.

However it seems now I have been editing the common file and not the atom
specific sst-acpi.c file.

An oversight on my part, ill edit the irqindex in the correct file and
report back in the morning EST.

Thanks for the help!

Tyler
On Jul 8, 2015 4:17 PM, "Antonio Ospite" <ao2@ao2.it> wrote:

> On Wed, 08 Jul 2015 12:32:17 -0400
> Tyler Yeomans <tyeo098@gmail.com> wrote:
>
> > Antonio,
> >
> > Hmm...
> > I have been running the driver like so:
> > (from sound/soc/intel/common/sst-acpi.c)
> > static struct sst_acpi_desc sst_acpi_baytrail_desc = {
> >      .drv_name = "baytrail-pcm-audio",
> >      .machines = baytrail_machines,
> >      .resindex_lpe_base = 0,
> >      .resindex_pcicfg_base = 1,
> >      .resindex_fw_base = 2,
> > *    .irqindex_host_ipc = 0,*
> >      .sst_id = SST_DEV_ID_BYT,
> >      .resindex_dma_base = -1,
> > };
> >
> > Which is what the patch at
> > https://bugzilla.kernel.org/attachment.cgi?id=155341 says to do.
> >
>
> Ah, sorry, the info from that bug report is outdated, for the
> snd-intel-sst-acpi you have to change
> sound/soc/intel/atom/sst/sst_acpi.c:
>
>
> diff --git a/sound/soc/intel/atom/sst/sst_acpi.c
> b/sound/soc/intel/atom/sst/sst_acpi.c
> index bb19b58..0badfa3 100644
> --- a/sound/soc/intel/atom/sst/sst_acpi.c
> +++ b/sound/soc/intel/atom/sst/sst_acpi.c
> @@ -118,7 +118,7 @@ static const struct sst_res_info byt_rvp_res_info = {
>         .mbox_size = 0x1000,
>         .acpi_lpe_res_index = 0,
>         .acpi_ddr_index = 2,
> -       .acpi_ipc_irq_index = 5,
> +       .acpi_ipc_irq_index = 0,
>  };
>
>  static struct sst_platform_info byt_rvp_platform_data = {
>
>
> I didn't have to do that because I fixed the DSDT.
>
> > However I also noticed in this file that its looking for the wrong
> > firmware:
> > static struct sst_acpi_mach baytrail_machines[] = {
> > *{ "10EC5640", "byt-rt5640", "intel/fw_sst_0f28.bin-48kHz_i2s_master" },*
> >      { "193C9890", "byt-max98090",
> > "intel/fw_sst_0f28.bin-48kHz_i2s_master" },
> >      {}
> > };
> >
> > Which will not point to the SSP0 firmware uploaded by Vinod.
> >
>
> Just to recap: make sure to use the snd-intel-sst-acpi driver instead
> of snd-soc-sst-acpi as explained earlier in this thread:
> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-July/094418.html
>
> As a quick and dirty way to do it you can remove snd-soc-sst-acpi.ko
> from the modules installation dir.
>
> A more robust solution would be to blacklist snd-soc-sst-acpi.
>
> Ciao,
>    Antonio
>
> --
> Antonio Ospite
> http://ao2.it
>
> A: Because it messes up the order in which people normally read text.
>    See http://en.wikipedia.org/wiki/Posting_style
> Q: Why is top-posting such a bad thing?
>
Vinod Koul July 10, 2015, 4:06 a.m. UTC | #2
On Thu, Jul 09, 2015 at 02:57:58PM -0400, Tyler Yeomans wrote:
> Antonio/Vinod,
> 
> I have made the change in the sst-acpi.c file for the atom specific boards.
> I've attached the dmesg output here with dynamic debug enabled.
> 
> To clarify-
> 
> snd-intel-sst-core is loaded
> FE-BE fix has been applied
> I'm using the ssp0 firmware.
> 
> Interrupts are still 0
> 
> Still no sound.
> 
> Would leaving the device on and providing remote access (i.e though
> teamviewer) assist in any way?

The fw download seems to fail on your device, which can also be due to
incorrect interrupt mapping...

[   20.386850] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
msg_id:0x1 fw_state 0x3
[   20.386862] intel_sst_acpi 80860F28:00: fw returned err -16
[   20.386873] sst-mfld-platform sst-mfld-platform: Enter: enable=1
port_name=ssp2-port
[   20.752559] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
msg_id:0x1 fw_state 0x3
[   20.752570] intel_sst_acpi 80860F28:00: fw returned err -16
[   21.163378] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
msg_id:0x0 fw_state 0x1
[   21.163388] intel_sst_acpi 80860F28:00: fw download failed -16

Can you tell me which device you have, what was preinstalled on it
tyeo098@gmail.com July 10, 2015, 12:41 p.m. UTC | #3
Vinod,

Its a Chinese device with a Z3735F chipset that originally had windows 
8.1 on it.

Thanks-

Tyler

On 07/10/2015 12:06 AM, Vinod Koul wrote:
> On Thu, Jul 09, 2015 at 02:57:58PM -0400, Tyler Yeomans wrote:
>> Antonio/Vinod,
>>
>> I have made the change in the sst-acpi.c file for the atom specific boards.
>> I've attached the dmesg output here with dynamic debug enabled.
>>
>> To clarify-
>>
>> snd-intel-sst-core is loaded
>> FE-BE fix has been applied
>> I'm using the ssp0 firmware.
>>
>> Interrupts are still 0
>>
>> Still no sound.
>>
>> Would leaving the device on and providing remote access (i.e though
>> teamviewer) assist in any way?
> The fw download seems to fail on your device, which can also be due to
> incorrect interrupt mapping...
>
> [   20.386850] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
> msg_id:0x1 fw_state 0x3
> [   20.386862] intel_sst_acpi 80860F28:00: fw returned err -16
> [   20.386873] sst-mfld-platform sst-mfld-platform: Enter: enable=1
> port_name=ssp2-port
> [   20.752559] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
> msg_id:0x1 fw_state 0x3
> [   20.752570] intel_sst_acpi 80860F28:00: fw returned err -16
> [   21.163378] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
> msg_id:0x0 fw_state 0x1
> [   21.163388] intel_sst_acpi 80860F28:00: fw download failed -16
>
> Can you tell me which device you have, what was preinstalled on it
>
tyeo098@gmail.com July 13, 2015, 5:06 p.m. UTC | #4
Vinod,

Have you received my last message?
The device was originally installed with 8.1, but I have since erased it 
in favor of Ubuntu.

Is there anything I can be trying in the meantime?

Thanks-

Tyler

On 07/10/2015 12:06 AM, Vinod Koul wrote:
> On Thu, Jul 09, 2015 at 02:57:58PM -0400, Tyler Yeomans wrote:
>> Antonio/Vinod,
>>
>> I have made the change in the sst-acpi.c file for the atom specific boards.
>> I've attached the dmesg output here with dynamic debug enabled.
>>
>> To clarify-
>>
>> snd-intel-sst-core is loaded
>> FE-BE fix has been applied
>> I'm using the ssp0 firmware.
>>
>> Interrupts are still 0
>>
>> Still no sound.
>>
>> Would leaving the device on and providing remote access (i.e though
>> teamviewer) assist in any way?
> The fw download seems to fail on your device, which can also be due to
> incorrect interrupt mapping...
>
> [   20.386850] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
> msg_id:0x1 fw_state 0x3
> [   20.386862] intel_sst_acpi 80860F28:00: fw returned err -16
> [   20.386873] sst-mfld-platform sst-mfld-platform: Enter: enable=1
> port_name=ssp2-port
> [   20.752559] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
> msg_id:0x1 fw_state 0x3
> [   20.752570] intel_sst_acpi 80860F28:00: fw returned err -16
> [   21.163378] intel_sst_acpi 80860F28:00: Wait timed-out condition:0x0,
> msg_id:0x0 fw_state 0x1
> [   21.163388] intel_sst_acpi 80860F28:00: fw download failed -16
>
> Can you tell me which device you have, what was preinstalled on it
>
Vinod Koul July 14, 2015, 8:47 a.m. UTC | #5
On Mon, Jul 13, 2015 at 01:06:47PM -0400, Tyler Yeomans wrote:
> Vinod,
> 
> Have you received my last message?
> The device was originally installed with 8.1, but I have since
> erased it in favor of Ubuntu.
> 
> Is there anything I can be trying in the meantime?
> 
> Thanks-
> 
> Tyler
> 
> On 07/10/2015 12:06 AM, Vinod Koul wrote:
> >On Thu, Jul 09, 2015 at 02:57:58PM -0400, Tyler Yeomans wrote:
> >>Antonio/Vinod,
> >>
> >>I have made the change in the sst-acpi.c file for the atom specific boards.
> >>I've attached the dmesg output here with dynamic debug enabled.
> >>
> >>To clarify-
> >>
> >>snd-intel-sst-core is loaded
> >>FE-BE fix has been applied
> >>I'm using the ssp0 firmware.
> >>
> >>Interrupts are still 0
> >>
> >>Still no sound.
Thanks,

I think the interrupt routing is not right, so am trying ti get answers for
this, stay tuned :)
tyeo098@gmail.com July 23, 2015, 3:24 p.m. UTC | #6
Hello Vinod,

Sorry to bother again, is there any update or anything else I can try here?

Thanks,

Tyler

On 07/14/2015 04:47 AM, Vinod Koul wrote:
> On Mon, Jul 13, 2015 at 01:06:47PM -0400, Tyler Yeomans wrote:
>> Vinod,
>>
>> Have you received my last message?
>> The device was originally installed with 8.1, but I have since
>> erased it in favor of Ubuntu.
>>
>> Is there anything I can be trying in the meantime?
>>
>> Thanks-
>>
>> Tyler
>>
>> On 07/10/2015 12:06 AM, Vinod Koul wrote:
>>> On Thu, Jul 09, 2015 at 02:57:58PM -0400, Tyler Yeomans wrote:
>>>> Antonio/Vinod,
>>>>
>>>> I have made the change in the sst-acpi.c file for the atom specific boards.
>>>> I've attached the dmesg output here with dynamic debug enabled.
>>>>
>>>> To clarify-
>>>>
>>>> snd-intel-sst-core is loaded
>>>> FE-BE fix has been applied
>>>> I'm using the ssp0 firmware.
>>>>
>>>> Interrupts are still 0
>>>>
>>>> Still no sound.
> Thanks,
>
> I think the interrupt routing is not right, so am trying ti get answers for
> this, stay tuned :)
>
diff mbox

Patch

diff --git a/sound/soc/intel/atom/sst/sst_acpi.c b/sound/soc/intel/atom/sst/sst_acpi.c
index bb19b58..0badfa3 100644
--- a/sound/soc/intel/atom/sst/sst_acpi.c
+++ b/sound/soc/intel/atom/sst/sst_acpi.c
@@ -118,7 +118,7 @@  static const struct sst_res_info byt_rvp_res_info = {
        .mbox_size = 0x1000,
        .acpi_lpe_res_index = 0,
        .acpi_ddr_index = 2,
-       .acpi_ipc_irq_index = 5,
+       .acpi_ipc_irq_index = 0,
 };

 static struct sst_platform_info byt_rvp_platform_data = {