| Message ID | 1435213498-21025-1-git-send-email-b18965@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 25, 2015 at 02:24:58PM +0800, Alison Wang wrote: > @@ -391,6 +394,85 @@ > reg = <0x0 0x2d24000 0x0 0x4000>; > }; > > + enet0: ethernet@2d10000 { Most of the vendor specific properties below are undocumented bindings. Shawn > + compatible = "fsl,etsec2"; > + device_type = "network"; > + #address-cells = <2>; > + #size-cells = <2>; > + interrupt-parent = <&gic>; > + model = "eTSEC"; > + fsl,dma-endian-le; > + fsl,magic-packet; > + fsl,wake-on-filer; > + fsl,num_rx_queues = <0x1>; > + fsl,num_tx_queues = <0x1>; > + local-mac-address = [ 00 00 00 00 00 00 ]; > + ranges; > + > + queue-group@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x0 0x2d10000 0x0 0x8000>; > + fsl,rx-bit-map = <0xff>; > + fsl,tx-bit-map = <0xff>; > + interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>; > + }; > + > + }; > + > + enet1: ethernet@2d50000 { > + compatible = "fsl,etsec2"; > + device_type = "network"; > + #address-cells = <2>; > + #size-cells = <2>; > + interrupt-parent = <&gic>; > + model = "eTSEC"; > + fsl,dma-endian-le; > + fsl,num_rx_queues = <0x1>; > + fsl,num_tx_queues = <0x1>; > + local-mac-address = [ 00 00 00 00 00 00 ]; > + ranges; > + > + queue-group@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x0 0x2d50000 0x0 0x8000>; > + fsl,rx-bit-map = <0xff>; > + fsl,tx-bit-map = <0xff>; > + interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>; > + }; > + > + }; > + > + enet2: ethernet@2d90000 { > + compatible = "fsl,etsec2"; > + device_type = "network"; > + #address-cells = <2>; > + #size-cells = <2>; > + interrupt-parent = <&gic>; > + model = "eTSEC"; > + fsl,dma-endian-le; > + fsl,num_rx_queues = <0x1>; > + fsl,num_tx_queues = <0x1>; > + local-mac-address = [ 00 00 00 00 00 00 ]; > + ranges; > + > + queue-group@0 { > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x0 0x2d90000 0x0 0x8000>; > + fsl,rx-bit-map = <0xff>; > + fsl,tx-bit-map = <0xff>; > + interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > + > usb@8600000 { > compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr"; > reg = <0x0 0x8600000 0x0 0x1000>; > -- > 2.1.0.27.g96db324 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: Sunday, July 12, 2015 9:51 AM > To: Wang Huan-B18965 > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; shawn.guo@linaro.org; Manoil Claudiu-B08782; > Wang Huan-B18965 > Subject: Re: [PATCH] dts: ls1021a: Add dts nodes for eTSEC0, eTSEC1 and > eTSEC2 > > On Thu, Jun 25, 2015 at 02:24:58PM +0800, Alison Wang wrote: > > @@ -391,6 +394,85 @@ > > reg = <0x0 0x2d24000 0x0 0x4000>; > > }; > > > > + enet0: ethernet@2d10000 { > > Most of the vendor specific properties below are undocumented bindings. > > Shawn > Hi Shawn, Please note that these properties (with only one exception) were accepted long time ago and are in use for the upstream powerpc platforms, eg: $ git grep fsl,num_rx_queues arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi: fsl,num_rx_queues = <0x8>; arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi: fsl,num_rx_queues = <0x8>; arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi: fsl,num_rx_queues = <0x8>; drivers/net/ethernet/freescale/gianfar.c: ret = of_property_read_u32(np, "fsl,num_rx_queues", So, I think the bindings documentation could be added in a separate, follow-up, patch. Thanks, Claudiu
On Mon, Jul 13, 2015 at 10:47:49AM +0000, Manoil Claudiu wrote: > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > Sent: Sunday, July 12, 2015 9:51 AM > > To: Wang Huan-B18965 > > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; shawn.guo@linaro.org; Manoil Claudiu-B08782; > > Wang Huan-B18965 > > Subject: Re: [PATCH] dts: ls1021a: Add dts nodes for eTSEC0, eTSEC1 and > > eTSEC2 > > > > On Thu, Jun 25, 2015 at 02:24:58PM +0800, Alison Wang wrote: > > > @@ -391,6 +394,85 @@ > > > reg = <0x0 0x2d24000 0x0 0x4000>; > > > }; > > > > > > + enet0: ethernet@2d10000 { > > > > Most of the vendor specific properties below are undocumented bindings. > > > > Shawn > > > > Hi Shawn, > > Please note that these properties (with only one exception) were accepted long time ago > and are in use for the upstream powerpc platforms, eg: > $ git grep fsl,num_rx_queues > arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi: fsl,num_rx_queues = <0x8>; > arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi: fsl,num_rx_queues = <0x8>; > arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi: fsl,num_rx_queues = <0x8>; > drivers/net/ethernet/freescale/gianfar.c: ret = of_property_read_u32(np, "fsl,num_rx_queues", > > So, I think the bindings documentation could be added in a separate, follow-up, patch. I would like to see patch for bindings documentation before I apply this one. Shawn
> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: Monday, July 13, 2015 4:32 PM > To: Manoil Claudiu-B08782 > Cc: Wang Huan-B18965; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > shawn.guo@linaro.org > Subject: Re: [PATCH] dts: ls1021a: Add dts nodes for eTSEC0, eTSEC1 and > eTSEC2 > > I would like to see patch for bindings documentation before I apply this > one. Agreed. I just noticed that this is an old version of the patch (using an obsoleted property), so please expect a v2 of this patch as well, besides the device tree binding document which I think will be named: ./Documentation/devicetree/bindings/net/fsl-etsec2.txt. Thanks. Claudiu
diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts index 9c5e16b..f16a061 100644 --- a/arch/arm/boot/dts/ls1021a-qds.dts +++ b/arch/arm/boot/dts/ls1021a-qds.dts @@ -75,6 +75,26 @@ }; }; +&enet0 { + tbi-handle = <&tbi0>; + phy-handle = <&sgmii_phy1c>; + phy-connection-type = "sgmii"; + status = "okay"; +}; + +&enet1 { + tbi-handle = <&tbi0>; + phy-handle = <&sgmii_phy1d>; + phy-connection-type = "sgmii"; + status = "okay"; +}; + +&enet2 { + phy-handle = <&rgmii_phy3>; + phy-connection-type = "rgmii-id"; + status = "okay"; +}; + &i2c0 { status = "okay"; diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts index a2c591e..4b61766 100644 --- a/arch/arm/boot/dts/ls1021a-twr.dts +++ b/arch/arm/boot/dts/ls1021a-twr.dts @@ -73,6 +73,26 @@ }; }; +&enet0 { + tbi-handle = <&tbi1>; + phy-handle = <&sgmii_phy2>; + phy-connection-type = "sgmii"; + status = "okay"; +}; + +&enet1 { + tbi-handle = <&tbi1>; + phy-handle = <&sgmii_phy0>; + phy-connection-type = "sgmii"; + status = "okay"; +}; + +&enet2 { + phy-handle = <&rgmii_phy1>; + phy-connection-type = "rgmii-id"; + status = "okay"; +}; + &i2c0 { status = "okay"; }; diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index c70bb27..6c41b10 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -59,6 +59,9 @@ serial3 = &lpuart3; serial4 = &lpuart4; serial5 = &lpuart5; + ethernet0 = &enet0; + ethernet1 = &enet1; + ethernet2 = &enet2; sysclk = &sysclk; }; @@ -391,6 +394,85 @@ reg = <0x0 0x2d24000 0x0 0x4000>; }; + enet0: ethernet@2d10000 { + compatible = "fsl,etsec2"; + device_type = "network"; + #address-cells = <2>; + #size-cells = <2>; + interrupt-parent = <&gic>; + model = "eTSEC"; + fsl,dma-endian-le; + fsl,magic-packet; + fsl,wake-on-filer; + fsl,num_rx_queues = <0x1>; + fsl,num_tx_queues = <0x1>; + local-mac-address = [ 00 00 00 00 00 00 ]; + ranges; + + queue-group@0 { + #address-cells = <1>; + #size-cells = <1>; + reg = <0x0 0x2d10000 0x0 0x8000>; + fsl,rx-bit-map = <0xff>; + fsl,tx-bit-map = <0xff>; + interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>; + }; + + }; + + enet1: ethernet@2d50000 { + compatible = "fsl,etsec2"; + device_type = "network"; + #address-cells = <2>; + #size-cells = <2>; + interrupt-parent = <&gic>; + model = "eTSEC"; + fsl,dma-endian-le; + fsl,num_rx_queues = <0x1>; + fsl,num_tx_queues = <0x1>; + local-mac-address = [ 00 00 00 00 00 00 ]; + ranges; + + queue-group@0 { + #address-cells = <1>; + #size-cells = <1>; + reg = <0x0 0x2d50000 0x0 0x8000>; + fsl,rx-bit-map = <0xff>; + fsl,tx-bit-map = <0xff>; + interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>; + }; + + }; + + enet2: ethernet@2d90000 { + compatible = "fsl,etsec2"; + device_type = "network"; + #address-cells = <2>; + #size-cells = <2>; + interrupt-parent = <&gic>; + model = "eTSEC"; + fsl,dma-endian-le; + fsl,num_rx_queues = <0x1>; + fsl,num_tx_queues = <0x1>; + local-mac-address = [ 00 00 00 00 00 00 ]; + ranges; + + queue-group@0 { + #address-cells = <1>; + #size-cells = <1>; + reg = <0x0 0x2d90000 0x0 0x8000>; + fsl,rx-bit-map = <0xff>; + fsl,tx-bit-map = <0xff>; + interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>; + }; + }; + usb@8600000 { compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr"; reg = <0x0 0x8600000 0x0 0x1000>;