Message ID | 1436782503-9749-1-git-send-email-rzr@gna.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Mon, 2015-07-13 at 12:15 +0200, Philippe Coval wrote: > Invert Y is needed (together with swap XY) for some touchscreens : > - LeadingTouch screens (at least for some of them) > - CarTft 8in4 (USB ID=0eef:0001) Wouldn't it be useful to force those settings for touchscreen devices which you can detect? That would make it work out-of-the-box on those devices. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/13/2015 12:28 PM, Bastien Nocera wrote: > On Mon, 2015-07-13 at 12:15 +0200, Philippe Coval wrote: >> Invert Y is needed (together with swap XY) for some touchscreens : >> - LeadingTouch screens (at least for some of them) >> - CarTft 8in4 (USB ID=0eef:0001) > > Wouldn't it be useful to force those settings for touchscreen devices > which you can detect? That would make it work out-of-the-box on those > devices. > Hi, That's what I am doing, but userland (using udev rules), since I am really unsure we can rely on USB id... For now, I don't think it's a good idea to force any behaviour, that can cause regressions on other ones. In a longer term, it would be good to keep a list of all those screens and see what should be the prefered behaviour per identification. Note, I don't have any screen anymore. Thanks for feedback
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c index f2c6c35..af7e6f3 100644 --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c @@ -63,6 +63,12 @@ static bool swap_xy; module_param(swap_xy, bool, 0644); MODULE_PARM_DESC(swap_xy, "If set X and Y axes are swapped."); +static int invert_x; +module_param(invert_x, bool, 0644); +MODULE_PARM_DESC(invert_x, "Invert X axis."); +static int invert_y; +module_param(invert_y, bool, 0644); +MODULE_PARM_DESC(invert_y, "Invert Y axis."); static bool hwcalib_xy; module_param(hwcalib_xy, bool, 0644); @@ -1303,6 +1309,7 @@ static void usbtouch_process_pkt(struct usbtouch_usb *usbtouch, unsigned char *pkt, int len) { struct usbtouch_device_info *type = usbtouch->type; + int x, y; if (!type->read_data(usbtouch, pkt)) return; @@ -1310,12 +1317,20 @@ static void usbtouch_process_pkt(struct usbtouch_usb *usbtouch, input_report_key(usbtouch->input, BTN_TOUCH, usbtouch->touch); if (swap_xy) { - input_report_abs(usbtouch->input, ABS_X, usbtouch->y); - input_report_abs(usbtouch->input, ABS_Y, usbtouch->x); + x = usbtouch->y; + y = usbtouch->x; } else { - input_report_abs(usbtouch->input, ABS_X, usbtouch->x); - input_report_abs(usbtouch->input, ABS_Y, usbtouch->y); + x = usbtouch->x; + y = usbtouch->y; } + if (invert_x) + x = type->max_xc - x + type->min_xc; + if (invert_y) + y = type->max_yc - y + type->min_yc; + + input_report_abs(usbtouch->input, ABS_X, x); + input_report_abs(usbtouch->input, ABS_Y, y); + if (type->max_press) input_report_abs(usbtouch->input, ABS_PRESSURE, usbtouch->press); input_sync(usbtouch->input);