| Message ID | 1431240383-12763-4-git-send-email-vishnupatekar0510@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Sun, May 10, 2015 at 12:16:20PM +0530, Vishnu Patekar wrote: > A33 clock control unit is similar to A23. > > A33 specific clocks are not yet implemented, added CLK_OF_DECLARE > to get it compiled for A33. That commit log doesn't make any sense. What you're doing isn't about whether or not that will be compiled, but whether you're registering the clocks and which clocks you protect. > Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> Isn't it supposed to have a space in the middle of your name, just like you have in your mail address? Thanks, Maxime
Hi, On Sun, May 10, 2015 at 3:47 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Sun, May 10, 2015 at 12:16:20PM +0530, Vishnu Patekar wrote: >> A33 clock control unit is similar to A23. >> >> A33 specific clocks are not yet implemented, added CLK_OF_DECLARE >> to get it compiled for A33. > > That commit log doesn't make any sense. > > What you're doing isn't about whether or not that will be compiled, > but whether you're registering the clocks and which clocks you > protect. Actually, It's just registering the a33 clocks and reusing a23 code. nothing to do with compile. I'll correct it in next patch version. > >> Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> > > Isn't it supposed to have a space in the middle of your name, just > like you have in your mail address? Yes, There should be space. > > Thanks, > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
Hi Vishnu, This patch did not make v4.2-rc1. A33 support requires this patch. Otherwise the clock tree is absent and nothing works. On Mon, May 11, 2015 at 4:53 PM, Vishnu Patekar <vishnupatekar0510@gmail.com> wrote: > Hi, > > On Sun, May 10, 2015 at 3:47 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: >> Hi, >> >> On Sun, May 10, 2015 at 12:16:20PM +0530, Vishnu Patekar wrote: >>> A33 clock control unit is similar to A23. >>> >>> A33 specific clocks are not yet implemented, added CLK_OF_DECLARE >>> to get it compiled for A33. >> >> That commit log doesn't make any sense. >> >> What you're doing isn't about whether or not that will be compiled, >> but whether you're registering the clocks and which clocks you >> protect. > Actually, It's just registering the a33 clocks and reusing a23 code. > nothing to do with compile. I'll correct it in next patch version. >> >>> Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> >> >> Isn't it supposed to have a space in the middle of your name, just >> like you have in your mail address? > Yes, There should be space. >> >> Thanks, >> Maxime >> >> -- >> Maxime Ripard, Free Electrons >> Embedded Linux, Kernel and Android engineering >> http://free-electrons.com
Hi, On Fri, Jul 17, 2015 at 04:57:11PM +0800, Chen-Yu Tsai wrote: > Hi Vishnu, > > This patch did not make v4.2-rc1. > > A33 support requires this patch. Otherwise the clock tree > is absent and nothing works. It got delayed and is in v4.2-rc2. Maxime
On Fri, Jul 17, 2015 at 5:09 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Fri, Jul 17, 2015 at 04:57:11PM +0800, Chen-Yu Tsai wrote: >> Hi Vishnu, >> >> This patch did not make v4.2-rc1. >> >> A33 support requires this patch. Otherwise the clock tree >> is absent and nothing works. > > It got delayed and is in v4.2-rc2. Ah, it's in the A33 machine support patch. Not where I was expecting it. Thanks. ChenYu
diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index 7e1e2bd..6d25e4e 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -1389,6 +1389,7 @@ static void __init sun6i_init_clocks(struct device_node *node) CLK_OF_DECLARE(sun6i_a31_clk_init, "allwinner,sun6i-a31", sun6i_init_clocks); CLK_OF_DECLARE(sun6i_a31s_clk_init, "allwinner,sun6i-a31s", sun6i_init_clocks); CLK_OF_DECLARE(sun8i_a23_clk_init, "allwinner,sun8i-a23", sun6i_init_clocks); +CLK_OF_DECLARE(sun8i_a33_clk_init, "allwinner,sun8i-a33", sun6i_init_clocks); static void __init sun9i_init_clocks(struct device_node *node) {
A33 clock control unit is similar to A23. A33 specific clocks are not yet implemented, added CLK_OF_DECLARE to get it compiled for A33. Signed-off-by: VishnuPatekar <vishnupatekar0510@gmail.com> --- drivers/clk/sunxi/clk-sunxi.c | 1 + 1 file changed, 1 insertion(+)