| Message ID | 1437395369-749-1-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 20, 2015 at 05:59:29PM +0530, Sudip Mukherjee wrote: > We were dereferencing dev first and then checking if it is NULL. Lets > check for NULL first and then dereference. The code is bonkers. Testing for a lack of a correctly constructed debugfs seq_file inside the debugfs seq_file callback is inane. -Chris
On Mon, Jul 20, 2015 at 01:38:46PM +0100, Chris Wilson wrote: > On Mon, Jul 20, 2015 at 05:59:29PM +0530, Sudip Mukherjee wrote: > > We were dereferencing dev first and then checking if it is NULL. Lets > > check for NULL first and then dereference. > > The code is bonkers. Testing for a lack of a correctly constructed > debugfs seq_file inside the debugfs seq_file callback is inane. I missed seeing before sending this patch that there are some more places where this has been done. Then are you suggesting to remove the test? regards sudip
On Mon, Jul 20, 2015 at 06:58:32PM +0530, Sudip Mukherjee wrote: > On Mon, Jul 20, 2015 at 01:38:46PM +0100, Chris Wilson wrote: > > On Mon, Jul 20, 2015 at 05:59:29PM +0530, Sudip Mukherjee wrote: > > > We were dereferencing dev first and then checking if it is NULL. Lets > > > check for NULL first and then dereference. > > > > The code is bonkers. Testing for a lack of a correctly constructed > > debugfs seq_file inside the debugfs seq_file callback is inane. > I missed seeing before sending this patch that there are some more > places where this has been done. > Then are you suggesting to remove the test? It's all been added for the tp validation support. And yes it should be removed everywhere. -Daniel
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index bc817da..f316e49 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -4100,12 +4100,13 @@ static int i915_displayport_test_active_show(struct seq_file *m, void *data) { struct drm_device *dev = m->private; struct drm_connector *connector; - struct list_head *connector_list = &dev->mode_config.connector_list; + struct list_head *connector_list; struct intel_dp *intel_dp; if (!dev) return -ENODEV; + connector_list = &dev->mode_config.connector_list; list_for_each_entry(connector, connector_list, head) { if (connector->connector_type !=
We were dereferencing dev first and then checking if it is NULL. Lets check for NULL first and then dereference. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)