| Message ID | 1435191645-6022-4-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: > The ChromeOS EC SPI transport driver has a dependency on OF because it > uses some OF helpers from the <linux/of.h> header. But there isn't a > need for an explicit dependency since the header has stub functions if > CONFIG_OF is not defined. > > Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has > a dependency on OF so in practice can't be selected without CONFIG_OF. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > > --- > > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied for v4.3, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 653815950aa2..3f68dd251ce8 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C > > config MFD_CROS_EC_SPI > tristate "ChromeOS Embedded Controller (SPI)" > - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF > + depends on MFD_CROS_EC && CROS_EC_PROTO && SPI > > ---help--- > If you say Y here, you get support for talking to the ChromeOS EC
On Thu, 25 Jun 2015, Lee Jones wrote: > On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: > > > The ChromeOS EC SPI transport driver has a dependency on OF because it > > uses some OF helpers from the <linux/of.h> header. But there isn't a > > need for an explicit dependency since the header has stub functions if > > CONFIG_OF is not defined. > > > > Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has > > a dependency on OF so in practice can't be selected without CONFIG_OF. > > > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > > > > --- > > > > drivers/mfd/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied for v4.3, thanks. Now applied for v4.2, thanks. > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index 653815950aa2..3f68dd251ce8 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C > > > > config MFD_CROS_EC_SPI > > tristate "ChromeOS Embedded Controller (SPI)" > > - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF > > + depends on MFD_CROS_EC && CROS_EC_PROTO && SPI > > > > ---help--- > > If you say Y here, you get support for talking to the ChromeOS EC >
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 653815950aa2..3f68dd251ce8 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C config MFD_CROS_EC_SPI tristate "ChromeOS Embedded Controller (SPI)" - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF + depends on MFD_CROS_EC && CROS_EC_PROTO && SPI ---help--- If you say Y here, you get support for talking to the ChromeOS EC
The ChromeOS EC SPI transport driver has a dependency on OF because it uses some OF helpers from the <linux/of.h> header. But there isn't a need for an explicit dependency since the header has stub functions if CONFIG_OF is not defined. Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has a dependency on OF so in practice can't be selected without CONFIG_OF. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)