| Message ID | 1437553904-7102-1-git-send-email-shobhit.kumar@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote: > This is needed as the CRC PMIC has support for Panel > enable/diable as gpio which needs 'gpiod_add_lookup_table' > and 'gpiod_remove_lookup_table' from gpiolib. This patch > can be squashed with below commit in topic/crc-pmic branch > > commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd > Author: Shobhit Kumar <shobhit.kumar@intel.com> > Date: Fri Jun 26 14:32:05 2015 +0530 > > mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO > signal > > On some Intel SoC platforms, the panel enable/disable signals > are controlled by CRC PMIC. Add those control as a new GPIO in a > lookup table for gpio-crystalcove chip during CRC driver load > > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> Applied, thanks. -Daniel > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 6538159..379a420 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -318,6 +318,7 @@ config LPC_SCH > > config INTEL_SOC_PMIC > bool "Support for Intel Atom SoC PMIC" > + depends on GPIOLIB > depends on I2C=y > select MFD_CORE > select REGMAP_I2C > -- > 1.9.1 >
On Wed, 22 Jul 2015, Daniel Vetter wrote: > On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote: > > This is needed as the CRC PMIC has support for Panel > > enable/diable as gpio which needs 'gpiod_add_lookup_table' > > and 'gpiod_remove_lookup_table' from gpiolib. This patch > > can be squashed with below commit in topic/crc-pmic branch > > > > commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd > > Author: Shobhit Kumar <shobhit.kumar@intel.com> > > Date: Fri Jun 26 14:32:05 2015 +0530 > > > > mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO > > signal > > > > On some Intel SoC platforms, the panel enable/disable signals > > are controlled by CRC PMIC. Add those control as a new GPIO in a > > lookup table for gpio-crystalcove chip during CRC driver load > > > > Cc: Lee Jones <lee.jones@linaro.org> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > > Applied, thanks. You can't just apply changes made to other subsystems willy-nilly. You should wait for an Ack, despite the triviality of the patch, even if it's just out of courtesy. > > --- > > drivers/mfd/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index 6538159..379a420 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -318,6 +318,7 @@ config LPC_SCH > > > > config INTEL_SOC_PMIC > > bool "Support for Intel Atom SoC PMIC" > > + depends on GPIOLIB > > depends on I2C=y > > select MFD_CORE > > select REGMAP_I2C >
On Thu, Jul 23, 2015 at 9:38 AM, Lee Jones <lee.jones@linaro.org> wrote: > On Wed, 22 Jul 2015, Daniel Vetter wrote: >> On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote: >> > This is needed as the CRC PMIC has support for Panel >> > enable/diable as gpio which needs 'gpiod_add_lookup_table' >> > and 'gpiod_remove_lookup_table' from gpiolib. This patch >> > can be squashed with below commit in topic/crc-pmic branch >> > >> > commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd >> > Author: Shobhit Kumar <shobhit.kumar@intel.com> >> > Date: Fri Jun 26 14:32:05 2015 +0530 >> > >> > mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO >> > signal >> > >> > On some Intel SoC platforms, the panel enable/disable signals >> > are controlled by CRC PMIC. Add those control as a new GPIO in a >> > lookup table for gpio-crystalcove chip during CRC driver load >> > >> > Cc: Lee Jones <lee.jones@linaro.org> >> > Cc: Linus Walleij <linus.walleij@linaro.org> >> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> >> >> Applied, thanks. > > You can't just apply changes made to other subsystems willy-nilly. > > You should wait for an Ack, despite the triviality of the patch, even > if it's just out of courtesy. Sorry about that, figured getting rid of the compile fail asap is better. Should I revert it again and update the pull request? -Daniel
On Thu, 23 Jul 2015, Daniel Vetter wrote: > On Thu, Jul 23, 2015 at 9:38 AM, Lee Jones <lee.jones@linaro.org> wrote: > > On Wed, 22 Jul 2015, Daniel Vetter wrote: > >> On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote: > >> > This is needed as the CRC PMIC has support for Panel > >> > enable/diable as gpio which needs 'gpiod_add_lookup_table' > >> > and 'gpiod_remove_lookup_table' from gpiolib. This patch > >> > can be squashed with below commit in topic/crc-pmic branch > >> > > >> > commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd > >> > Author: Shobhit Kumar <shobhit.kumar@intel.com> > >> > Date: Fri Jun 26 14:32:05 2015 +0530 > >> > > >> > mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO > >> > signal > >> > > >> > On some Intel SoC platforms, the panel enable/disable signals > >> > are controlled by CRC PMIC. Add those control as a new GPIO in a > >> > lookup table for gpio-crystalcove chip during CRC driver load > >> > > >> > Cc: Lee Jones <lee.jones@linaro.org> > >> > Cc: Linus Walleij <linus.walleij@linaro.org> > >> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > >> > >> Applied, thanks. > > > > You can't just apply changes made to other subsystems willy-nilly. > > > > You should wait for an Ack, despite the triviality of the patch, even > > if it's just out of courtesy. > > Sorry about that, figured getting rid of the compile fail asap is > better. Should I revert it again and update the pull request? It's fine. Just please bear it in mind for the future.
On Thu, Jul 23, 2015 at 10:15:03AM +0100, Lee Jones wrote: > On Thu, 23 Jul 2015, Daniel Vetter wrote: > > > On Thu, Jul 23, 2015 at 9:38 AM, Lee Jones <lee.jones@linaro.org> wrote: > > > On Wed, 22 Jul 2015, Daniel Vetter wrote: > > >> On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote: > > >> > This is needed as the CRC PMIC has support for Panel > > >> > enable/diable as gpio which needs 'gpiod_add_lookup_table' > > >> > and 'gpiod_remove_lookup_table' from gpiolib. This patch > > >> > can be squashed with below commit in topic/crc-pmic branch > > >> > > > >> > commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd > > >> > Author: Shobhit Kumar <shobhit.kumar@intel.com> > > >> > Date: Fri Jun 26 14:32:05 2015 +0530 > > >> > > > >> > mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO > > >> > signal > > >> > > > >> > On some Intel SoC platforms, the panel enable/disable signals > > >> > are controlled by CRC PMIC. Add those control as a new GPIO in a > > >> > lookup table for gpio-crystalcove chip during CRC driver load > > >> > > > >> > Cc: Lee Jones <lee.jones@linaro.org> > > >> > Cc: Linus Walleij <linus.walleij@linaro.org> > > >> > Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> > > >> > > >> Applied, thanks. > > > > > > You can't just apply changes made to other subsystems willy-nilly. > > > > > > You should wait for an Ack, despite the triviality of the patch, even > > > if it's just out of courtesy. > > > > Sorry about that, figured getting rid of the compile fail asap is > > better. Should I revert it again and update the pull request? > > It's fine. Just please bear it in mind for the future. Sure will wait for ack the next time around. Thanks, Daniel
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 6538159..379a420 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -318,6 +318,7 @@ config LPC_SCH config INTEL_SOC_PMIC bool "Support for Intel Atom SoC PMIC" + depends on GPIOLIB depends on I2C=y select MFD_CORE select REGMAP_I2C
This is needed as the CRC PMIC has support for Panel enable/diable as gpio which needs 'gpiod_add_lookup_table' and 'gpiod_remove_lookup_table' from gpiolib. This patch can be squashed with below commit in topic/crc-pmic branch commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd Author: Shobhit Kumar <shobhit.kumar@intel.com> Date: Fri Jun 26 14:32:05 2015 +0530 mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal On some Intel SoC platforms, the panel enable/disable signals are controlled by CRC PMIC. Add those control as a new GPIO in a lookup table for gpio-crystalcove chip during CRC driver load Cc: Lee Jones <lee.jones@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> --- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)