diff mbox

[2/5] staging: wilc1000: change void pointer type to real type

Message ID 1439440883-16061-3-git-send-email-tony.cho@atmel.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Tony Cho Aug. 13, 2015, 4:41 a.m. UTC 
From: Johnny Kim <johnny.kim@atmel.com>

This patch changes the void pointer member of the tstrHostIFmsg to the
real data type because the void pointer type is ambiguous and not
readable.

Signed-off-by: Johnny Kim <johnny.kim@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
---
 drivers/staging/wilc1000/host_interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sudip Mukherjee Aug. 14, 2015, 6:26 a.m. UTC | #1 
On Thu, Aug 13, 2015 at 01:41:20PM +0900, Tony Cho wrote:
> From: Johnny Kim <johnny.kim@atmel.com>
> 
> This patch changes the void pointer member of the tstrHostIFmsg to the
> real data type because the void pointer type is ambiguous and not
> readable.
> 
> Signed-off-by: Johnny Kim <johnny.kim@atmel.com>
> Signed-off-by: Tony Cho <tony.cho@atmel.com>
> ---
This patch is introducing some new warnings like:

drivers/staging/wilc1000/host_interface.c: In function ‘host_int_set_wfi_drv_handler’:
drivers/staging/wilc1000/host_interface.c:5817:66: warning: assignment
makes integer from pointer without a cast [enabled by default]
  strHostIFmsg.uniHostIFmsgBody.strHostIfSetDrvHandler.u32Address = u32address;


regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg KH Aug. 15, 2015, 2:01 a.m. UTC | #2 
On Fri, Aug 14, 2015 at 11:56:13AM +0530, Sudip Mukherjee wrote:
> On Thu, Aug 13, 2015 at 01:41:20PM +0900, Tony Cho wrote:
> > From: Johnny Kim <johnny.kim@atmel.com>
> > 
> > This patch changes the void pointer member of the tstrHostIFmsg to the
> > real data type because the void pointer type is ambiguous and not
> > readable.
> > 
> > Signed-off-by: Johnny Kim <johnny.kim@atmel.com>
> > Signed-off-by: Tony Cho <tony.cho@atmel.com>
> > ---
> This patch is introducing some new warnings like:
> 
> drivers/staging/wilc1000/host_interface.c: In function ‘host_int_set_wfi_drv_handler’:
> drivers/staging/wilc1000/host_interface.c:5817:66: warning: assignment
> makes integer from pointer without a cast [enabled by default]
>   strHostIFmsg.uniHostIFmsgBody.strHostIfSetDrvHandler.u32Address = u32address;

That warning doesn't seem to have anything to do with this patch, odd...
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 20a554f..b5afc82 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -466,7 +466,7 @@  typedef union _tuniHostIFmsgBody {
 typedef struct _tstrHostIFmsg {
 	u16 u16MsgId;                                           /*!< Message ID */
 	tuniHostIFmsgBody uniHostIFmsgBody;             /*!< Message body */
-	void *drvHandler;
+	tstrWILC_WFIDrv *drvHandler;
 } tstrHostIFmsg;
 
 #ifdef CONNECT_DIRECT