diff mbox

[9/9] ASoC: Intel: Skylake: Remove CPU dai that is not used

Message ID 1438976184-6160-10-git-send-email-subhransu.s.prusty@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Subhransu S. Prusty Aug. 7, 2015, 7:36 p.m. UTC 
From: Jeeja KP <jeeja.kp@intel.com>

For each endpoint instance, need to create CPU dai,
Removed unused CPU dai DMIC23/HDA-SPK/HDA-AMIC dais.

Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
---
 sound/soc/intel/skylake/skl-pcm.c | 33 ---------------------------------
 1 file changed, 33 deletions(-)

Comments

Mark Brown Aug. 14, 2015, 10:06 p.m. UTC | #1 
On Sat, Aug 08, 2015 at 01:06:24AM +0530, Subhransu S. Prusty wrote:
> From: Jeeja KP <jeeja.kp@intel.com>
> 
> For each endpoint instance, need to create CPU dai,
> Removed unused CPU dai DMIC23/HDA-SPK/HDA-AMIC dais.

I'm not sure I understand the first line here?
Vinod Koul Aug. 15, 2015, 2:19 p.m. UTC | #2 
On Fri, Aug 14, 2015 at 11:06:33PM +0100, Mark Brown wrote:
> On Sat, Aug 08, 2015 at 01:06:24AM +0530, Subhransu S. Prusty wrote:
> > From: Jeeja KP <jeeja.kp@intel.com>
> > 
> > For each endpoint instance, need to create CPU dai,
> > Removed unused CPU dai DMIC23/HDA-SPK/HDA-AMIC dais.
> 
> I'm not sure I understand the first line here?

We need to create CPU DAI for each endpoint instance. For this we should
have one DMIC DAI, one HDA DAI and SSP DAI. DMIC23, HDA-SPK/AMIC was not
required so this patch removes

Will fix the description

Thanks
diff mbox

Patch

diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index 045c7d4..22ab7ac 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -579,17 +579,6 @@  static struct snd_soc_dai_driver skl_platform_dai[] = {
 	},
 },
 {
-	.name = "DMIC23 Pin",
-	.ops = &skl_dmic_dai_ops,
-	.capture = {
-		.stream_name = "DMIC23 Rx",
-		.channels_min = HDA_STEREO,
-		.channels_max = HDA_STEREO,
-		.rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_16000,
-		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE,
-	},
-},
-{
 	.name = "HD-Codec Pin",
 	.ops = &skl_link_dai_ops,
 	.playback = {
@@ -607,28 +596,6 @@  static struct snd_soc_dai_driver skl_platform_dai[] = {
 		.formats = SNDRV_PCM_FMTBIT_S16_LE,
 	},
 },
-{
-	.name = "HD-Codec-SPK Pin",
-	.ops = &skl_link_dai_ops,
-	.playback = {
-		.stream_name = "HD-Codec-SPK Tx",
-		.channels_min = HDA_STEREO,
-		.channels_max = HDA_STEREO,
-		.rates = SNDRV_PCM_RATE_48000,
-		.formats = SNDRV_PCM_FMTBIT_S16_LE,
-	},
-},
-{
-	.name = "HD-Codec-AMIC Pin",
-	.ops = &skl_link_dai_ops,
-	.capture = {
-		.stream_name = "HD-Codec-AMIC Rx",
-		.channels_min = HDA_STEREO,
-		.channels_max = HDA_STEREO,
-		.rates = SNDRV_PCM_RATE_48000,
-		.formats = SNDRV_PCM_FMTBIT_S16_LE,
-	},
-},
 };
 
 static int skl_platform_open(struct snd_pcm_substream *substream)