| Message ID | 1435191645-6022-2-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 25, 2015 at 02:20:42AM +0200, Javier Martinez Canillas wrote: > The Chrome platform support depends on X86 || ARM because there are > only Chromebooks using those architectures. But only some drivers > depend on a given architecture, and the ones that do already have > a dependency on their specific Kconfig symbol entries. > > An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST > but is more future proof to remove the dependency and let the drivers > be built in all architectures if possible to have more build coverage. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Acked-by: Olof Johansson <olof@lixom.net> -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: > The Chrome platform support depends on X86 || ARM because there are > only Chromebooks using those architectures. But only some drivers > depend on a given architecture, and the ones that do already have > a dependency on their specific Kconfig symbol entries. > > An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST > but is more future proof to remove the dependency and let the drivers > be built in all architectures if possible to have more build coverage. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > > drivers/platform/chrome/Kconfig | 1 - > 1 file changed, 1 deletion(-) Applied for v4.2, thanks. > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig > index cb1329919527..3271cd1abe7c 100644 > --- a/drivers/platform/chrome/Kconfig > +++ b/drivers/platform/chrome/Kconfig > @@ -4,7 +4,6 @@ > > menuconfig CHROME_PLATFORMS > bool "Platform support for Chrome hardware" > - depends on X86 || ARM > ---help--- > Say Y here to get to see options for platform support for > various Chromebooks and Chromeboxes. This option alone does
On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas <javier.martinez@collabora.co.uk> wrote: > The Chrome platform support depends on X86 || ARM because there are > only Chromebooks using those architectures. But only some drivers > depend on a given architecture, and the ones that do already have > a dependency on their specific Kconfig symbol entries. > > An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST > but is more future proof to remove the dependency and let the drivers > be built in all architectures if possible to have more build coverage. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> NAKed-by: Geert Uytterhoeven <geert@linux-m68k.org> The proper way to have more build coverage is to extend the dependencies with "|| COMPILE_TEST". Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a Kconfig warning on !X86 and !ARM. Mixing "select" and "depends" (all other ChromeOS stuff depends on the symbol) is bad practice, as it may lead to circular Kconfig dependencies. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Geert, Thanks a lot for your feedback. On Mon, Aug 17, 2015 at 9:56 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Thu, Jun 25, 2015 at 2:20 AM, Javier Martinez Canillas > <javier.martinez@collabora.co.uk> wrote: >> The Chrome platform support depends on X86 || ARM because there are >> only Chromebooks using those architectures. But only some drivers >> depend on a given architecture, and the ones that do already have >> a dependency on their specific Kconfig symbol entries. >> >> An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST >> but is more future proof to remove the dependency and let the drivers >> be built in all architectures if possible to have more build coverage. >> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > > NAKed-by: Geert Uytterhoeven <geert@linux-m68k.org> > > The proper way to have more build coverage is to extend the dependencies > with "|| COMPILE_TEST". > Ok, I mentioned that as the other option but was not sure which one was more suitable since CHROME_PLATFORMS is a category and the individual drivers already depend on a given arch. But I will make it depends on X86 || ARM again plus || COMPILE_TEST and in the future if there is a Chromebook on !X86 and !ARM, that new arch can be added to the or logic. > Yes I know MFD_CROS_EC selects CHROME_PLATFORMS, causing a > Kconfig warning on !X86 and !ARM. > > Mixing "select" and "depends" (all other ChromeOS stuff depends on the > symbol) is bad practice, as it may lead to circular Kconfig dependencies. > Yes, I think this is the real issue. I added the select instead of a depends to avoid breaking git bisection when moving the cros_ec com helpers out of MFD since some platforms use MFD_CROS_EC but don't enable CHROME_PLATFORMS on their defconfigs. But I'll change the select to depends instead and include the defconfig changes as a dependency in the series to avoid breaking git bisection. > Gr{oetje,eeting}s, > > Geert > > -- Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig index cb1329919527..3271cd1abe7c 100644 --- a/drivers/platform/chrome/Kconfig +++ b/drivers/platform/chrome/Kconfig @@ -4,7 +4,6 @@ menuconfig CHROME_PLATFORMS bool "Platform support for Chrome hardware" - depends on X86 || ARM ---help--- Say Y here to get to see options for platform support for various Chromebooks and Chromeboxes. This option alone does
The Chrome platform support depends on X86 || ARM because there are only Chromebooks using those architectures. But only some drivers depend on a given architecture, and the ones that do already have a dependency on their specific Kconfig symbol entries. An option is to also make CHROME_PLATFORMS depends on || COMPILE_TEST but is more future proof to remove the dependency and let the drivers be built in all architectures if possible to have more build coverage. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- drivers/platform/chrome/Kconfig | 1 - 1 file changed, 1 deletion(-)