| Message ID | 1440207911-17666-3-git-send-email-chunfeng.yun@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 8/22/2015 4:45 AM, Chunfeng Yun wrote: > add a DT binding documentation of xHCI host controller for the > MT8173 SoC from Mediatek. > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > .../devicetree/bindings/usb/mt8173-xhci.txt | 52 ++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > new file mode 100644 > index 0000000..8e6e463 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > @@ -0,0 +1,52 @@ > +mt65XX xHCI The file is called mt8173-xhci.txt. Are you sure MT65xx should be here? > + > +The device node for Mediatek SOC usb3.0 host controller > + > +Required properties: > + - compatible : should contain "mediatek,mt8173-xhci" > + - reg : specifies physical base address and size of the registers, > + the first one for MAC, the second for IPPC > + - interrupts : interrupt used by the controller > + - power-domains : a phandle to USB power domain node to control usb's USB's -- be consistent, please. > + mtcmos > + - vusb33-supply : regulator of usb avdd3.3v > + > + - clocks : a list of phandle + clock-specifier pairs, one for each > + entry in clock-names > + - clock-names : must contain > + "sys_ck": for clock of xHCI MAC > + "wakeup_deb_p0": for usb wakeup debounce clock of port0 > + "wakeup_deb_p0": for usb wakeup debounce clock of port1 USB. > + > + - phys : a list of phandle + phy specifier pairs > + - usb3-lpm-capable : supports USB3 LPM > + - mediatek,syscon-wakeup : phandle to syscon used to access usb wakeup > + control register > + - mediatek,wakeup-src : 1: ip sleep wakeup mode; 2: line state wakeup > + mode; others means don't enable wakeup source of usb "Others mean" and "USB". [...] MBR, Sergei
hi, On Sat, 2015-08-22 at 16:23 +0300, Sergei Shtylyov wrote: > Hello. > > On 8/22/2015 4:45 AM, Chunfeng Yun wrote: > > > add a DT binding documentation of xHCI host controller for the > > MT8173 SoC from Mediatek. > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > > --- > > .../devicetree/bindings/usb/mt8173-xhci.txt | 52 ++++++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > new file mode 100644 > > index 0000000..8e6e463 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt > > @@ -0,0 +1,52 @@ > > +mt65XX xHCI > > The file is called mt8173-xhci.txt. Are you sure MT65xx should be here? > I will revise it later. > > + > > +The device node for Mediatek SOC usb3.0 host controller > > + > > +Required properties: > > + - compatible : should contain "mediatek,mt8173-xhci" > > + - reg : specifies physical base address and size of the registers, > > + the first one for MAC, the second for IPPC > > + - interrupts : interrupt used by the controller > > + - power-domains : a phandle to USB power domain node to control usb's > > USB's -- be consistent, please. > > > + mtcmos > > + - vusb33-supply : regulator of usb avdd3.3v > > + > > + - clocks : a list of phandle + clock-specifier pairs, one for each > > + entry in clock-names > > + - clock-names : must contain > > + "sys_ck": for clock of xHCI MAC > > + "wakeup_deb_p0": for usb wakeup debounce clock of port0 > > + "wakeup_deb_p0": for usb wakeup debounce clock of port1 > > USB. > > > + > > + - phys : a list of phandle + phy specifier pairs > > + - usb3-lpm-capable : supports USB3 LPM > > + - mediatek,syscon-wakeup : phandle to syscon used to access usb wakeup > > + control register > > + - mediatek,wakeup-src : 1: ip sleep wakeup mode; 2: line state wakeup > > + mode; others means don't enable wakeup source of usb > > "Others mean" and "USB". > I will replace all 'usb' by "USB" Thanks a lot, and sorry for later reply. > [...] > > MBR, Sergei >
diff --git a/Documentation/devicetree/bindings/usb/mt8173-xhci.txt b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt new file mode 100644 index 0000000..8e6e463 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/mt8173-xhci.txt @@ -0,0 +1,52 @@ +mt65XX xHCI + +The device node for Mediatek SOC usb3.0 host controller + +Required properties: + - compatible : should contain "mediatek,mt8173-xhci" + - reg : specifies physical base address and size of the registers, + the first one for MAC, the second for IPPC + - interrupts : interrupt used by the controller + - power-domains : a phandle to USB power domain node to control usb's + mtcmos + - vusb33-supply : regulator of usb avdd3.3v + + - clocks : a list of phandle + clock-specifier pairs, one for each + entry in clock-names + - clock-names : must contain + "sys_ck": for clock of xHCI MAC + "wakeup_deb_p0": for usb wakeup debounce clock of port0 + "wakeup_deb_p0": for usb wakeup debounce clock of port1 + + - phys : a list of phandle + phy specifier pairs + - usb3-lpm-capable : supports USB3 LPM + - mediatek,syscon-wakeup : phandle to syscon used to access usb wakeup + control register + - mediatek,wakeup-src : 1: ip sleep wakeup mode; 2: line state wakeup + mode; others means don't enable wakeup source of usb + +Optional properties: + - vbus-supply : Reference to the VBUS regulator; + +Example: +usb30: usb@11270000 { + compatible = "mediatek,mt8173-xhci"; + reg = <0 0x11270000 0 0x4000>, + <0 0x11280000 0 0x0800>; + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_LOW>; + power-domains = <&scpsys MT8173_POWER_DOMAIN_USB>; + clocks = <&topckgen CLK_TOP_USB30_SEL>, + <&pericfg CLK_PERI_USB0>, + <&pericfg CLK_PERI_USB1>; + clock-names = "sys_ck", + "wakeup_deb_p0", + "wakeup_deb_p1"; + phys = <&phy_port0 PHY_TYPE_USB3>, + <&phy_port1 PHY_TYPE_USB2>; + vusb33-supply = <&mt6397_vusb_reg>; + vbus-supply = <&usb_p1_vbus>; + usb3-lpm-capable; + mediatek,syscon-wakeup = <&pericfg>; + mediatek,wakeup-src = <1>; + status = "okay"; +};
add a DT binding documentation of xHCI host controller for the MT8173 SoC from Mediatek. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- .../devicetree/bindings/usb/mt8173-xhci.txt | 52 ++++++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/mt8173-xhci.txt