| Message ID | 1441034514-18853-1-git-send-email-kys@microsoft.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote: > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying > tags. What's the actual problem description this causes? James > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> > Cc: stable@vger.kernel.org > --- > drivers/scsi/storvsc_drv.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index 40c43ae..ad8c4bc 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) > vm_srb->win8_extension.time_out_value = 60; > > vm_srb->win8_extension.srb_flags |= > - (SRB_FLAGS_QUEUE_ACTION_ENABLE | > - SRB_FLAGS_DISABLE_SYNCH_TRANSFER); > + SRB_FLAGS_DISABLE_SYNCH_TRANSFER; > > /* Build the SRB */ > switch (scmnd->sc_data_direction) { -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFtZXMgQm90dG9tbGV5 IFttYWlsdG86SmFtZXMuQm90dG9tbGV5QEhhbnNlblBhcnRuZXJzaGlwLmNvbV0NCj4gU2VudDog TW9uZGF5LCBBdWd1c3QgMzEsIDIwMTUgNzowMiBBTQ0KPiBUbzogS1kgU3Jpbml2YXNhbiA8a3lz QG1pY3Jvc29mdC5jb20+DQo+IENjOiBncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZzsgbGludXgt a2VybmVsQHZnZXIua2VybmVsLm9yZzsNCj4gZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZzsg b2hlcmluZ0BzdXNlLmNvbTsNCj4gamJvdHRvbWxleUBwYXJhbGxlbHMuY29tOyBoY2hAaW5mcmFk ZWFkLm9yZzsgbGludXgtc2NzaUB2Z2VyLmtlcm5lbC5vcmc7DQo+IGFwd0BjYW5vbmljYWwuY29t OyB2a3V6bmV0c0ByZWRoYXQuY29tOyBqYXNvd2FuZ0ByZWRoYXQuY29tOw0KPiBzdGFibGVAdmdl ci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8xXSBzdG9ydnNjOiBEb24ndCBz ZXQgdGhlDQo+IFNSQl9GTEFHU19RVUVVRV9BQ1RJT05fRU5BQkxFIGZsYWcNCj4gDQo+IE9uIE1v biwgMjAxNS0wOC0zMSBhdCAwODoyMSAtMDcwMCwgSy4gWS4gU3Jpbml2YXNhbiB3cm90ZToNCj4g PiBEb24ndCBzZXQgdGhlIFNSQl9GTEFHU19RVUVVRV9BQ1RJT05fRU5BQkxFIGZsYWcgc2luY2Ug d2UgYXJlIG5vdA0KPiBzcGVjaWZ5aW5nDQo+ID4gdGFncy4NCj4gDQo+IFdoYXQncyB0aGUgYWN0 dWFsIHByb2JsZW0gZGVzY3JpcHRpb24gdGhpcyBjYXVzZXM/DQpRbG9naWMgZHJpdmVyIGRvZXMg bm90IHdvcmsgY29ycmVjdGx5IGlmIHRoZSBTUkJfRkxBR1NfUVVFVUVfQUNUSU9OX0VOQUJMRQ0K aXMgc2V0IGFuZCBubyBhY3Rpb24gdGFnIGlzIHNwZWNpZmllZC4NCg0KUmVnYXJkcywNCg0KSy4g WQ0KDQo+IA0KPiBKYW1lcw0KPiANCj4gDQo+ID4gU2lnbmVkLW9mZi1ieTogSy4gWS4gU3Jpbml2 YXNhbiA8a3lzQG1pY3Jvc29mdC5jb20+DQo+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcN Cj4gPiAtLS0NCj4gPiAgZHJpdmVycy9zY3NpL3N0b3J2c2NfZHJ2LmMgfCAgICAzICstLQ0KPiA+ ICAxIGZpbGVzIGNoYW5nZWQsIDEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gPg0K PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Njc2kvc3RvcnZzY19kcnYuYyBiL2RyaXZlcnMvc2Nz aS9zdG9ydnNjX2Rydi5jDQo+ID4gaW5kZXggNDBjNDNhZS4uYWQ4YzRiYyAxMDA2NDQNCj4gPiAt LS0gYS9kcml2ZXJzL3Njc2kvc3RvcnZzY19kcnYuYw0KPiA+ICsrKyBiL2RyaXZlcnMvc2NzaS9z dG9ydnNjX2Rydi5jDQo+ID4gQEAgLTE2NDcsOCArMTY0Nyw3IEBAIHN0YXRpYyBpbnQgc3RvcnZz Y19xdWV1ZWNvbW1hbmQoc3RydWN0DQo+IFNjc2lfSG9zdCAqaG9zdCwgc3RydWN0IHNjc2lfY21u ZCAqc2NtbmQpDQo+ID4gIAl2bV9zcmItPndpbjhfZXh0ZW5zaW9uLnRpbWVfb3V0X3ZhbHVlID0g NjA7DQo+ID4NCj4gPiAgCXZtX3NyYi0+d2luOF9leHRlbnNpb24uc3JiX2ZsYWdzIHw9DQo+ID4g LQkJKFNSQl9GTEFHU19RVUVVRV9BQ1RJT05fRU5BQkxFIHwNCj4gPiAtCQlTUkJfRkxBR1NfRElT QUJMRV9TWU5DSF9UUkFOU0ZFUik7DQo+ID4gKwkJU1JCX0ZMQUdTX0RJU0FCTEVfU1lOQ0hfVFJB TlNGRVI7DQo+ID4NCj4gPiAgCS8qIEJ1aWxkIHRoZSBTUkIgKi8NCj4gPiAgCXN3aXRjaCAoc2Nt bmQtPnNjX2RhdGFfZGlyZWN0aW9uKSB7DQo+IA0KPiANCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFtZXMgQm90dG9tbGV5 IFttYWlsdG86SmFtZXMuQm90dG9tbGV5QEhhbnNlblBhcnRuZXJzaGlwLmNvbV0NCj4gU2VudDog TW9uZGF5LCBBdWd1c3QgMzEsIDIwMTUgNzowMiBBTQ0KPiBUbzogS1kgU3Jpbml2YXNhbiA8a3lz QG1pY3Jvc29mdC5jb20+DQo+IENjOiBncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZzsgbGludXgt a2VybmVsQHZnZXIua2VybmVsLm9yZzsNCj4gZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZzsg b2hlcmluZ0BzdXNlLmNvbTsNCj4gamJvdHRvbWxleUBwYXJhbGxlbHMuY29tOyBoY2hAaW5mcmFk ZWFkLm9yZzsgbGludXgtc2NzaUB2Z2VyLmtlcm5lbC5vcmc7DQo+IGFwd0BjYW5vbmljYWwuY29t OyB2a3V6bmV0c0ByZWRoYXQuY29tOyBqYXNvd2FuZ0ByZWRoYXQuY29tOw0KPiBzdGFibGVAdmdl ci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8xXSBzdG9ydnNjOiBEb24ndCBz ZXQgdGhlDQo+IFNSQl9GTEFHU19RVUVVRV9BQ1RJT05fRU5BQkxFIGZsYWcNCj4gDQo+IE9uIE1v biwgMjAxNS0wOC0zMSBhdCAwODoyMSAtMDcwMCwgSy4gWS4gU3Jpbml2YXNhbiB3cm90ZToNCj4g PiBEb24ndCBzZXQgdGhlIFNSQl9GTEFHU19RVUVVRV9BQ1RJT05fRU5BQkxFIGZsYWcgc2luY2Ug d2UgYXJlIG5vdA0KPiBzcGVjaWZ5aW5nDQo+ID4gdGFncy4NCj4gDQo+IFdoYXQncyB0aGUgYWN0 dWFsIHByb2JsZW0gZGVzY3JpcHRpb24gdGhpcyBjYXVzZXM/DQoNCkphbWVzLA0KDQpTaG91bGQg SSByZXNlbmQgdGhpcyBwYXRjaC4gSSB0aGluayBJIHByb3ZpZGVkIHRoZSBjbGFyaWZpY2F0aW9u IHlvdSBoYWQgc291Z2h0Lg0KDQpSZWdhcmRzLA0KDQpLLiBZDQo+IA0KPiBKYW1lcw0KPiANCj4g DQo+ID4gU2lnbmVkLW9mZi1ieTogSy4gWS4gU3Jpbml2YXNhbiA8a3lzQG1pY3Jvc29mdC5jb20+ DQo+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcNCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9z Y3NpL3N0b3J2c2NfZHJ2LmMgfCAgICAzICstLQ0KPiA+ICAxIGZpbGVzIGNoYW5nZWQsIDEgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L3Njc2kvc3RvcnZzY19kcnYuYyBiL2RyaXZlcnMvc2NzaS9zdG9ydnNjX2Rydi5jDQo+ID4gaW5k ZXggNDBjNDNhZS4uYWQ4YzRiYyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL3Njc2kvc3RvcnZz Y19kcnYuYw0KPiA+ICsrKyBiL2RyaXZlcnMvc2NzaS9zdG9ydnNjX2Rydi5jDQo+ID4gQEAgLTE2 NDcsOCArMTY0Nyw3IEBAIHN0YXRpYyBpbnQgc3RvcnZzY19xdWV1ZWNvbW1hbmQoc3RydWN0DQo+ IFNjc2lfSG9zdCAqaG9zdCwgc3RydWN0IHNjc2lfY21uZCAqc2NtbmQpDQo+ID4gIAl2bV9zcmIt PndpbjhfZXh0ZW5zaW9uLnRpbWVfb3V0X3ZhbHVlID0gNjA7DQo+ID4NCj4gPiAgCXZtX3NyYi0+ d2luOF9leHRlbnNpb24uc3JiX2ZsYWdzIHw9DQo+ID4gLQkJKFNSQl9GTEFHU19RVUVVRV9BQ1RJ T05fRU5BQkxFIHwNCj4gPiAtCQlTUkJfRkxBR1NfRElTQUJMRV9TWU5DSF9UUkFOU0ZFUik7DQo+ ID4gKwkJU1JCX0ZMQUdTX0RJU0FCTEVfU1lOQ0hfVFJBTlNGRVI7DQo+ID4NCj4gPiAgCS8qIEJ1 aWxkIHRoZSBTUkIgKi8NCj4gPiAgCXN3aXRjaCAoc2NtbmQtPnNjX2RhdGFfZGlyZWN0aW9uKSB7 DQo+IA0KPiANCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 40c43ae..ad8c4bc 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1647,8 +1647,7 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) vm_srb->win8_extension.time_out_value = 60; vm_srb->win8_extension.srb_flags |= - (SRB_FLAGS_QUEUE_ACTION_ENABLE | - SRB_FLAGS_DISABLE_SYNCH_TRANSFER); + SRB_FLAGS_DISABLE_SYNCH_TRANSFER; /* Build the SRB */ switch (scmnd->sc_data_direction) {
Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying tags. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Cc: stable@vger.kernel.org --- drivers/scsi/storvsc_drv.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)