diff mbox

[v3,8/10] megaraid_sas : Fix validHandles check in io path

Message ID 201508311159.t7VBxUKb031439@palmhbs0.lsi.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sumit Saxena Aug. 31, 2015, 11:54 a.m. UTC 
Syncro firmware supports round robin IO switch on dual path. For this driver 
use validHandles as a check for dual path. This check suppose to be > 1 (not > 2)

Without this patch, earlier driver code does not use dual path functionality.

Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: Kashyap Desai <kashyap.desai@avagotech.com>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Martin K. Petersen Sept. 4, 2015, 3:34 a.m. UTC | #1 
>>>>> "Sumit" == sumit saxena <sumit.saxena@avagotech.com> writes:

Sumit> Syncro firmware supports round robin IO switch on dual path. For
Sumit> this driver use validHandles as a check for dual path. This check
Sumit> suppose to be > 1 (not > 2)

Sumit> Without this patch, earlier driver code does not use dual path
Sumit> functionality.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
diff mbox

Patch

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 1d73d30..1398950 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -1684,7 +1684,7 @@  megasas_build_ldio_fusion(struct megasas_instance *instance,
 			scp->SCp.Status &= ~MEGASAS_LOAD_BALANCE_FLAG;
 
 		if ((raidLUN[0] == 1) &&
-			(local_map_ptr->raidMap.devHndlInfo[io_info.pd_after_lb].validHandles > 2)) {
+			(local_map_ptr->raidMap.devHndlInfo[io_info.pd_after_lb].validHandles > 1)) {
 			instance->dev_handle = !(instance->dev_handle);
 			io_info.devHandle =
 				local_map_ptr->raidMap.devHndlInfo[io_info.pd_after_lb].devHandle[instance->dev_handle];