| Message ID | 1441357309-61669-3-git-send-email-dawei.chien@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Dawei, On Fri, Sep 4, 2015 at 5:01 PM, Dawei Chien <dawei.chien@mediatek.com> wrote: > Add thermal zone node to mt8173.dtsi. > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > --- > This patch is base on following patches > https://patchwork.kernel.org/patch/6969581/ > https://patchwork.kernel.org/patch/6969571/ > https://patchwork.kernel.org/patch/6969381/ > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index 208051a..6493bfd 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -17,6 +17,7 @@ > #include <dt-bindings/power/mt8173-power.h> > #include <dt-bindings/reset-controller/mt8173-resets.h> > #include "mt8173-pinfunc.h" > +#include <dt-bindings/thermal/thermal.h> This include is not necessary, however... > > / { > compatible = "mediatek,mt8173"; > @@ -116,6 +117,49 @@ > clock-output-names = "clk32k"; > }; > > + thermal-zones { > + cpu_thermal: cpu_thermal { > + polling-delay-passive = <1000>; /* milliseconds */ > + polling-delay = <1000>; /* milliseconds */ > + > + thermal-sensors = <&thermal MT8173_THERMAL_ZONE_CA57>; this fails to compile, because MT8173_THERMAL_ZONE_CA57 is defined in: include/dt-bindings/thermal/mt8173.h -Dan > + sustainable-power = <1500>; > + > + trips { > + threshold: trip-point@0 { > + temperature = <68000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + target: trip-point@1 { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu_crit: cpu_crit@0 { > + temperature = <115000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map@0 { > + trip = <&target>; > + cooling-device = <&cpu0 0 0>; > + contribution = <1024>; > + }; > + map@1 { > + trip = <&target>; > + cooling-device = <&cpu2 0 0>; > + contribution = <2048>; > + }; > + }; > + }; > + }; > + > timer { > compatible = "arm,armv8-timer"; > interrupt-parent = <&gic>; > -- > 1.7.9.5 >
On Mon, Sep 7, 2015 at 12:00 PM, Daniel Kurtz <djkurtz@chromium.org> wrote: > Hi Dawei, > > On Fri, Sep 4, 2015 at 5:01 PM, Dawei Chien <dawei.chien@mediatek.com> wrote: >> Add thermal zone node to mt8173.dtsi. >> >> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> >> --- >> This patch is base on following patches >> https://patchwork.kernel.org/patch/6969581/ >> https://patchwork.kernel.org/patch/6969571/ >> https://patchwork.kernel.org/patch/6969381/ >> --- >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> index 208051a..6493bfd 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> @@ -17,6 +17,7 @@ >> #include <dt-bindings/power/mt8173-power.h> >> #include <dt-bindings/reset-controller/mt8173-resets.h> >> #include "mt8173-pinfunc.h" >> +#include <dt-bindings/thermal/thermal.h> Also, as a nit, (#include <dt-bindings/thermal/mt8173.h>) should be above '#include "mt8173-pinfunc.h"' -djk
Hi Daniel, On Mon, 2015-09-07 at 12:05 +0800, Daniel Kurtz wrote: > On Mon, Sep 7, 2015 at 12:00 PM, Daniel Kurtz <djkurtz@chromium.org> wrote: > > Hi Dawei, > > > > On Fri, Sep 4, 2015 at 5:01 PM, Dawei Chien <dawei.chien@mediatek.com> wrote: > >> Add thermal zone node to mt8173.dtsi. > >> > >> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > >> --- > >> This patch is base on following patches > >> https://patchwork.kernel.org/patch/6969581/ > >> https://patchwork.kernel.org/patch/6969571/ > >> https://patchwork.kernel.org/patch/6969381/ > >> --- > >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ > >> 1 file changed, 44 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> index 208051a..6493bfd 100644 > >> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> @@ -17,6 +17,7 @@ > >> #include <dt-bindings/power/mt8173-power.h> > >> #include <dt-bindings/reset-controller/mt8173-resets.h> > >> #include "mt8173-pinfunc.h" > >> +#include <dt-bindings/thermal/thermal.h> > > Also, as a nit, (#include <dt-bindings/thermal/mt8173.h>) should be > above '#include "mt8173-pinfunc.h"' Thank you, I will resend this patch with mt8171.h and sort header file. > -djk
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 208051a..6493bfd 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -17,6 +17,7 @@ #include <dt-bindings/power/mt8173-power.h> #include <dt-bindings/reset-controller/mt8173-resets.h> #include "mt8173-pinfunc.h" +#include <dt-bindings/thermal/thermal.h> / { compatible = "mediatek,mt8173"; @@ -116,6 +117,49 @@ clock-output-names = "clk32k"; }; + thermal-zones { + cpu_thermal: cpu_thermal { + polling-delay-passive = <1000>; /* milliseconds */ + polling-delay = <1000>; /* milliseconds */ + + thermal-sensors = <&thermal MT8173_THERMAL_ZONE_CA57>; + sustainable-power = <1500>; + + trips { + threshold: trip-point@0 { + temperature = <68000>; + hysteresis = <2000>; + type = "passive"; + }; + + target: trip-point@1 { + temperature = <85000>; + hysteresis = <2000>; + type = "passive"; + }; + + cpu_crit: cpu_crit@0 { + temperature = <115000>; + hysteresis = <2000>; + type = "critical"; + }; + }; + + cooling-maps { + map@0 { + trip = <&target>; + cooling-device = <&cpu0 0 0>; + contribution = <1024>; + }; + map@1 { + trip = <&target>; + cooling-device = <&cpu2 0 0>; + contribution = <2048>; + }; + }; + }; + }; + timer { compatible = "arm,armv8-timer"; interrupt-parent = <&gic>;
Add thermal zone node to mt8173.dtsi. Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> --- This patch is base on following patches https://patchwork.kernel.org/patch/6969581/ https://patchwork.kernel.org/patch/6969571/ https://patchwork.kernel.org/patch/6969381/ --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)