| Message ID | 1441570566-14001-3-git-send-email-sjoerd.simons@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Sjoerd, On 09/06/2015 10:16 PM, Sjoerd Simons wrote: > Active Semi act8846 is used as the PMIC on various Rockchip boards, > enable the ACT8865 driver to support this. > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > --- > > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 25a1d574..7058fef 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y > CONFIG_MFD_TPS6586X=y > CONFIG_MFD_TPS65910=y > CONFIG_REGULATOR_AB8500=y > +CONFIG_REGULATOR_ACT8865=y Same question than the previous patch, does this really need to be built-in? The Kconfig symbol is tristate. After an explanation why it needs to be built-in or enabling it as a module: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
Hi, I guess one could rename that to something like "ARM: multi_v7_defconfig: Enable regulators used on most rockchip boards" and as well add CONFIG_REGULATOR_FAN53555=y CONFIG_MFD_RK808=y CONFIG_REGULATOR_RK808=y fan5355 is the driver providing support for the syr82x used on all rk3288 boards with an act8846. Am Sonntag, 6. September 2015, 22:16:04 schrieb Sjoerd Simons: > Active Semi act8846 is used as the PMIC on various Rockchip boards, > enable the ACT8865 driver to support this. > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > --- > > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig > b/arch/arm/configs/multi_v7_defconfig index 25a1d574..7058fef 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y > CONFIG_MFD_TPS6586X=y > CONFIG_MFD_TPS65910=y > CONFIG_REGULATOR_AB8500=y > +CONFIG_REGULATOR_ACT8865=y > CONFIG_REGULATOR_AS3711=y > CONFIG_REGULATOR_AS3722=y > CONFIG_REGULATOR_AXP20X=y
PMIC RK808 used on many rk3288 boards ,such as Popmetal. It is a MFD with function regulator and RTC. So if you plan to enable RK808, please also enable CONFIG_RTC_DRV_RK808. thanks. On 2015?09?07? 17:33, Heiko Stübner wrote: > Hi, > > I guess one could rename that to something like > "ARM: multi_v7_defconfig: Enable regulators used on most rockchip boards" > > and as well add > > CONFIG_REGULATOR_FAN53555=y > CONFIG_MFD_RK808=y > CONFIG_REGULATOR_RK808=y > > fan5355 is the driver providing support for the syr82x used on all rk3288 > boards with an act8846. > > > > Am Sonntag, 6. September 2015, 22:16:04 schrieb Sjoerd Simons: >> Active Semi act8846 is used as the PMIC on various Rockchip boards, >> enable the ACT8865 driver to support this. >> >> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > >> --- >> >> arch/arm/configs/multi_v7_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/configs/multi_v7_defconfig >> b/arch/arm/configs/multi_v7_defconfig index 25a1d574..7058fef 100644 >> --- a/arch/arm/configs/multi_v7_defconfig >> +++ b/arch/arm/configs/multi_v7_defconfig >> @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y >> CONFIG_MFD_TPS6586X=y >> CONFIG_MFD_TPS65910=y >> CONFIG_REGULATOR_AB8500=y >> +CONFIG_REGULATOR_ACT8865=y >> CONFIG_REGULATOR_AS3711=y >> CONFIG_REGULATOR_AS3722=y >> CONFIG_REGULATOR_AXP20X=y > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >
Hi Andy, Am Montag, 7. September 2015, 18:49:02 schrieb Andy Yan: > PMIC RK808 used on many rk3288 boards ,such as Popmetal. > It is a MFD with function regulator and RTC. So if you plan to enable > RK808, please also enable CONFIG_RTC_DRV_RK808. I think that could go into a separate patch5 ... enabling CONFIG_RTC_DRV_RK808=m CONFIG_RTC_DRV_HYM8563=m the two rtc types used on all(?) Rockchip boards. So enable the rk808 mfd+regulator here and do the rtcs separately later. > On 2015?09?07? 17:33, Heiko Stübner wrote: > > Hi, > > > > I guess one could rename that to something like > > "ARM: multi_v7_defconfig: Enable regulators used on most rockchip boards" > > > > and as well add > > > > CONFIG_REGULATOR_FAN53555=y > > CONFIG_MFD_RK808=y > > CONFIG_REGULATOR_RK808=y > > > > fan5355 is the driver providing support for the syr82x used on all rk3288 > > boards with an act8846. > > > > Am Sonntag, 6. September 2015, 22:16:04 schrieb Sjoerd Simons: > >> Active Semi act8846 is used as the PMIC on various Rockchip boards, > >> enable the ACT8865 driver to support this. > >> > >> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > >> > >> --- > >> > >> arch/arm/configs/multi_v7_defconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/arch/arm/configs/multi_v7_defconfig > >> b/arch/arm/configs/multi_v7_defconfig index 25a1d574..7058fef 100644 > >> --- a/arch/arm/configs/multi_v7_defconfig > >> +++ b/arch/arm/configs/multi_v7_defconfig > >> @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y > >> > >> CONFIG_MFD_TPS6586X=y > >> CONFIG_MFD_TPS65910=y > >> CONFIG_REGULATOR_AB8500=y > >> > >> +CONFIG_REGULATOR_ACT8865=y > >> > >> CONFIG_REGULATOR_AS3711=y > >> CONFIG_REGULATOR_AS3722=y > >> CONFIG_REGULATOR_AXP20X=y > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 25a1d574..7058fef 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y CONFIG_MFD_TPS6586X=y CONFIG_MFD_TPS65910=y CONFIG_REGULATOR_AB8500=y +CONFIG_REGULATOR_ACT8865=y CONFIG_REGULATOR_AS3711=y CONFIG_REGULATOR_AS3722=y CONFIG_REGULATOR_AXP20X=y
Active Semi act8846 is used as the PMIC on various Rockchip boards, enable the ACT8865 driver to support this. Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+)