| Message ID | 1441658303-18081-5-git-send-email-pandit.parav@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On 07/09/2015 23:38, Parav Pandit wrote: > @@ -2676,7 +2686,7 @@ static inline int thread_group_empty(struct task_struct *p) > * Protects ->fs, ->files, ->mm, ->group_info, ->comm, keyring > * subscriptions and synchronises with wait4(). Also used in procfs. Also > * pins the final release of task.io_context. Also protects ->cpuset and > - * ->cgroup.subsys[]. And ->vfork_done. > + * ->cgroup.subsys[]. Also projtects ->vfork_done and ->rdma_res_counter. s/projtects/protects/ > * > * Nests both inside and outside of read_lock(&tasklist_lock). > * It must not be nested with write_lock_irq(&tasklist_lock), -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Sep 8, 2015 at 11:18 AM, Haggai Eran <haggaie@mellanox.com> wrote: > On 07/09/2015 23:38, Parav Pandit wrote: >> @@ -2676,7 +2686,7 @@ static inline int thread_group_empty(struct task_struct *p) >> * Protects ->fs, ->files, ->mm, ->group_info, ->comm, keyring >> * subscriptions and synchronises with wait4(). Also used in procfs. Also >> * pins the final release of task.io_context. Also protects ->cpuset and >> - * ->cgroup.subsys[]. And ->vfork_done. >> + * ->cgroup.subsys[]. Also projtects ->vfork_done and ->rdma_res_counter. > s/projtects/protects/ >> * >> * Nests both inside and outside of read_lock(&tasklist_lock). >> * It must not be nested with write_lock_irq(&tasklist_lock), > Hi Haggai Eran, Did you miss to put comments or I missed something? Parav -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/09/2015 10:04, Parav Pandit wrote: > On Tue, Sep 8, 2015 at 11:18 AM, Haggai Eran <haggaie@mellanox.com> wrote: >> On 07/09/2015 23:38, Parav Pandit wrote: >>> @@ -2676,7 +2686,7 @@ static inline int thread_group_empty(struct task_struct *p) >>> * Protects ->fs, ->files, ->mm, ->group_info, ->comm, keyring >>> * subscriptions and synchronises with wait4(). Also used in procfs. Also >>> * pins the final release of task.io_context. Also protects ->cpuset and >>> - * ->cgroup.subsys[]. And ->vfork_done. >>> + * ->cgroup.subsys[]. Also projtects ->vfork_done and ->rdma_res_counter. >> s/projtects/protects/ >>> * >>> * Nests both inside and outside of read_lock(&tasklist_lock). >>> * It must not be nested with write_lock_irq(&tasklist_lock), >> > > Hi Haggai Eran, > Did you miss to put comments or I missed something? Yes, I wrote "s/projtects/protects/" to tell you that you have a typo in your comment. You should change the word "projtects" to "protects". Haggai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Sep 8, 2015 at 1:54 PM, Haggai Eran <haggaie@mellanox.com> wrote: > On 08/09/2015 10:04, Parav Pandit wrote: >> On Tue, Sep 8, 2015 at 11:18 AM, Haggai Eran <haggaie@mellanox.com> wrote: >>> On 07/09/2015 23:38, Parav Pandit wrote: >>>> @@ -2676,7 +2686,7 @@ static inline int thread_group_empty(struct task_struct *p) >>>> * Protects ->fs, ->files, ->mm, ->group_info, ->comm, keyring >>>> * subscriptions and synchronises with wait4(). Also used in procfs. Also >>>> * pins the final release of task.io_context. Also protects ->cpuset and >>>> - * ->cgroup.subsys[]. And ->vfork_done. >>>> + * ->cgroup.subsys[]. Also projtects ->vfork_done and ->rdma_res_counter. >>> s/projtects/protects/ >>>> * >>>> * Nests both inside and outside of read_lock(&tasklist_lock). >>>> * It must not be nested with write_lock_irq(&tasklist_lock), >>> >> >> Hi Haggai Eran, >> Did you miss to put comments or I missed something? > > Yes, I wrote "s/projtects/protects/" to tell you that you have a typo in > your comment. You should change the word "projtects" to "protects". > > Haggai > ah. ok. Right. Will correct it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/sched.h b/include/linux/sched.h index ae21f15..a5f79b6 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1334,6 +1334,8 @@ union rcu_special { }; struct rcu_node; +struct task_rdma_res_counter; + enum perf_event_task_context { perf_invalid_context = -1, perf_hw_context = 0, @@ -1637,6 +1639,14 @@ struct task_struct { struct css_set __rcu *cgroups; /* cg_list protected by css_set_lock and tsk->alloc_lock */ struct list_head cg_list; + +#ifdef CONFIG_CGROUP_RDMA_RESOURCE + /* RDMA resource accounting counters, allocated only + * when RDMA resources are created by a task. + */ + struct task_rdma_res_counter *rdma_res_counter; +#endif + #endif #ifdef CONFIG_FUTEX struct robust_list_head __user *robust_list; @@ -2676,7 +2686,7 @@ static inline int thread_group_empty(struct task_struct *p) * Protects ->fs, ->files, ->mm, ->group_info, ->comm, keyring * subscriptions and synchronises with wait4(). Also used in procfs. Also * pins the final release of task.io_context. Also protects ->cpuset and - * ->cgroup.subsys[]. And ->vfork_done. + * ->cgroup.subsys[]. Also projtects ->vfork_done and ->rdma_res_counter. * * Nests both inside and outside of read_lock(&tasklist_lock). * It must not be nested with write_lock_irq(&tasklist_lock),
Added RDMA device resource tracking object per task. Added comments to capture usage of task lock by device cgroup for rdma. Signed-off-by: Parav Pandit <pandit.parav@gmail.com> --- include/linux/sched.h | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)