Message ID | 1441296673-14315-1-git-send-email-vkuznets@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Vitaly Kuznetsov <vkuznets@redhat.com> writes: > Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the > SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at > least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan: > INQUIRY result too short (5), using 36' messages on console. This can be > problematic for slow consoles. Introduce short_inquiry host template flag > to avoid printing error messages for such adapters. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > --- > Changes since v1: > - This is a successor of previously sent "scsi_scan: move 'INQUIRY result > too short' message to debug level" patch. Instead of moving the message > to debug level for all adapters introduce a special 'short_inquiry' flag > for host template [inspired by James Bottomley]. James, sorry for the ping but can you please let me know your opinion? This is not a 'cosmetic fix', serial port on Hyper-V is extremely slow and users get softlockups just because we output too much. Here is a freshly booted guest with SCSI and FC adapters connected: # dmesg | grep -c INQUIRY 2076 (my other pernding '[PATCH] scsi_scan: don't dump trace when scsi_prep_async_scan() is called twice' is related to the same issue). See also: https://lkml.org/lkml/2015/9/6/119 Thanks, [...]
On Tue, 2015-09-15 at 16:27 +0200, Vitaly Kuznetsov wrote: > Vitaly Kuznetsov <vkuznets@redhat.com> writes: > > > Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the > > SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at > > least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan: > > INQUIRY result too short (5), using 36' messages on console. This can be > > problematic for slow consoles. Introduce short_inquiry host template flag > > to avoid printing error messages for such adapters. > > > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > > --- > > Changes since v1: > > - This is a successor of previously sent "scsi_scan: move 'INQUIRY result > > too short' message to debug level" patch. Instead of moving the message > > to debug level for all adapters introduce a special 'short_inquiry' flag > > for host template [inspired by James Bottomley]. > > James, > > sorry for the ping but can you please let me know your opinion? This is > not a 'cosmetic fix', serial port on Hyper-V is extremely slow and users > get softlockups just because we output too much. Here is a freshly > booted guest with SCSI and FC adapters connected: > > # dmesg | grep -c INQUIRY > 2076 It needs a review ... preferably from someone who validates that we don't get any adverse impact from the missing inquiry data > (my other pernding '[PATCH] scsi_scan: don't dump trace when > scsi_prep_async_scan() is called twice' is related to the same issue). So does this. James > See also: https://lkml.org/lkml/2015/9/6/119 > > Thanks, > > [...] > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFtZXMgQm90dG9tbGV5 IFttYWlsdG86SmFtZXMuQm90dG9tbGV5QEhhbnNlblBhcnRuZXJzaGlwLmNvbV0NCj4gU2VudDog VHVlc2RheSwgU2VwdGVtYmVyIDE1LCAyMDE1IDExOjI0IEFNDQo+IFRvOiBWaXRhbHkgS3V6bmV0 c292IDx2a3V6bmV0c0ByZWRoYXQuY29tPg0KPiBDYzogbGludXgtc2NzaUB2Z2VyLmtlcm5lbC5v cmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IEtZIFNyaW5pdmFzYW4NCj4gPGt5c0Bt aWNyb3NvZnQuY29tPjsgTG9uZyBMaSA8bG9uZ2xpQG1pY3Jvc29mdC5jb20+OyBEZXh1YW4gQ3Vp DQo+IDxkZWN1aUBtaWNyb3NvZnQuY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyXSBzY3Np OiBpbnRyb2R1Y2Ugc2hvcnRfaW5xdWlyeSBmbGFnIGZvciBicm9rZW4gaG9zdA0KPiBhZGFwdGVy cw0KPiANCj4gT24gVHVlLCAyMDE1LTA5LTE1IGF0IDE2OjI3ICswMjAwLCBWaXRhbHkgS3V6bmV0 c292IHdyb3RlOg0KPiA+IFZpdGFseSBLdXpuZXRzb3YgPHZrdXpuZXRzQHJlZGhhdC5jb20+IHdy aXRlczoNCj4gPg0KPiA+ID4gU29tZSBob3N0IGFkYXB0ZXJzIChlLmcuIEh5cGVyLVYgc3RvcnZz YykgYXJlIGtub3duIGZvciBub3QgcmVzcGVjdGluZw0KPiB0aGUNCj4gPiA+IFNQQy0yLzMvNCBy ZXF1aXJlbWVudCBmb3IgJ0lOUVVJUlkgZGF0YSAoc2VlIHRhYmxlIC4uLikgc2hhbGwgY29udGFp biBhdA0KPiA+ID4gbGVhc3QgMzYgYnl0ZXMnLiBBcyBhIHJlc3VsdCB3ZSBnZXQgdG9ucyBvbiAn c2NzaSAwOjc6MToxOiBzY3NpIHNjYW46DQo+ID4gPiBJTlFVSVJZIHJlc3VsdCB0b28gc2hvcnQg KDUpLCB1c2luZyAzNicgbWVzc2FnZXMgb24gY29uc29sZS4gVGhpcyBjYW4gYmUNCj4gPiA+IHBy b2JsZW1hdGljIGZvciBzbG93IGNvbnNvbGVzLiBJbnRyb2R1Y2Ugc2hvcnRfaW5xdWlyeSBob3N0 IHRlbXBsYXRlIGZsYWcNCj4gPiA+IHRvIGF2b2lkIHByaW50aW5nIGVycm9yIG1lc3NhZ2VzIGZv ciBzdWNoIGFkYXB0ZXJzLg0KPiA+ID4NCj4gPiA+IFNpZ25lZC1vZmYtYnk6IFZpdGFseSBLdXpu ZXRzb3YgPHZrdXpuZXRzQHJlZGhhdC5jb20+DQo+ID4gPiAtLS0NCj4gPiA+IENoYW5nZXMgc2lu Y2UgdjE6DQo+ID4gPiAtIFRoaXMgaXMgYSBzdWNjZXNzb3Igb2YgcHJldmlvdXNseSBzZW50ICJz Y3NpX3NjYW46IG1vdmUgJ0lOUVVJUlkgcmVzdWx0DQo+ID4gPiAgIHRvbyBzaG9ydCcgbWVzc2Fn ZSB0byBkZWJ1ZyBsZXZlbCIgcGF0Y2guIEluc3RlYWQgb2YgbW92aW5nIHRoZQ0KPiBtZXNzYWdl DQo+ID4gPiAgIHRvIGRlYnVnIGxldmVsIGZvciBhbGwgYWRhcHRlcnMgaW50cm9kdWNlIGEgc3Bl Y2lhbCAnc2hvcnRfaW5xdWlyeScgZmxhZw0KPiA+ID4gICBmb3IgaG9zdCB0ZW1wbGF0ZSBbaW5z cGlyZWQgYnkgSmFtZXMgQm90dG9tbGV5XS4NCj4gPg0KPiA+IEphbWVzLA0KPiA+DQo+ID4gc29y cnkgZm9yIHRoZSBwaW5nIGJ1dCBjYW4geW91IHBsZWFzZSBsZXQgbWUga25vdyB5b3VyIG9waW5p b24/IFRoaXMgaXMNCj4gPiBub3QgYSAnY29zbWV0aWMgZml4Jywgc2VyaWFsIHBvcnQgb24gSHlw ZXItViBpcyBleHRyZW1lbHkgc2xvdyBhbmQgdXNlcnMNCj4gPiBnZXQgc29mdGxvY2t1cHMganVz dCBiZWNhdXNlIHdlIG91dHB1dCB0b28gbXVjaC4gSGVyZSBpcyBhIGZyZXNobHkNCj4gPiBib290 ZWQgZ3Vlc3Qgd2l0aCBTQ1NJIGFuZCBGQyBhZGFwdGVycyBjb25uZWN0ZWQ6DQo+ID4NCj4gPiAj IGRtZXNnIHwgZ3JlcCAtYyBJTlFVSVJZDQo+ID4gMjA3Ng0KPiANCj4gSXQgbmVlZHMgYSByZXZp ZXcgLi4uIHByZWZlcmFibHkgZnJvbSBzb21lb25lIHdobyB2YWxpZGF0ZXMgdGhhdCB3ZQ0KPiBk b24ndCBnZXQgYW55IGFkdmVyc2UgaW1wYWN0IGZyb20gdGhlIG1pc3NpbmcgaW5xdWlyeSBkYXRh DQo+IA0KPiA+IChteSBvdGhlciBwZXJuZGluZyAnW1BBVENIXSBzY3NpX3NjYW46IGRvbid0IGR1 bXAgdHJhY2Ugd2hlbg0KPiA+IHNjc2lfcHJlcF9hc3luY19zY2FuKCkgaXMgY2FsbGVkIHR3aWNl JyBpcyByZWxhdGVkIHRvIHRoZSBzYW1lIGlzc3VlKS4NCj4gDQo+IFNvIGRvZXMgdGhpcy4NCg0K SmFtZXMsDQoNCkkgd2lsbCByZXZpZXcgdGhlIGNvZGUgYW5kIHRlc3QgdGhpcyBhcyB3ZWxsLg0K DQpSZWdhcmRzLA0KDQpLLiBZDQo+IA0KPiBKYW1lcw0KPiANCj4gDQo+ID4gU2VlIGFsc286DQo+ IGh0dHBzOi8vbmEwMS5zYWZlbGlua3MucHJvdGVjdGlvbi5vdXRsb29rLmNvbS8/dXJsPWh0dHBz JTNhJTJmJTJmbGttbC5vcg0KPiBnJTJmbGttbCUyZjIwMTUlMmY5JTJmNiUyZjExOSZkYXRhPTAx JTdjMDElN2NreXMlNDBtaWNyb3NvZnQuY29tDQo+ICU3YzdhNmU5Y2NhYmIyZjQzYzBhMDExMDhk MmJkZmFkODI2JTdjNzJmOTg4YmY4NmYxNDFhZjkxYWIyZDdjZDAxMQ0KPiBkYjQ3JTdjMSZzZGF0 YT10M0lHTE1pRzJzVTRWSmZtR2lZS0dNeTIyZDNJeEhiR1Fab3A2M25yVjdZJTNkDQo+ID4NCj4g PiBUaGFua3MsDQo+ID4NCj4gPiBbLi4uXQ0KPiA+DQo+IA0KPiANCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index f9f3f82..f1d00a0 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -701,9 +701,10 @@ static int scsi_probe_lun(struct scsi_device *sdev, unsigned char *inq_result, * strings. */ if (sdev->inquiry_len < 36) { - sdev_printk(KERN_INFO, sdev, - "scsi scan: INQUIRY result too short (%d)," - " using 36\n", sdev->inquiry_len); + if (!sdev->host->hostt->short_inquiry) + sdev_printk(KERN_INFO, sdev, + "scsi scan: INQUIRY result too short (%d)," + " using 36\n", sdev->inquiry_len); sdev->inquiry_len = 36; } diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 3c6584f..f3b4d0f 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1711,6 +1711,7 @@ static struct scsi_host_template scsi_driver = { /* Make sure we dont get a sg segment crosses a page boundary */ .dma_boundary = PAGE_SIZE-1, .no_write_same = 1, + .short_inquiry = 1, }; enum { diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index e113c75..7b022af 100644 --- a/include/scsi/scsi_host.h +++ b/include/scsi/scsi_host.h @@ -454,6 +454,12 @@ struct scsi_host_template { unsigned no_async_abort:1; /* + * True if this host adapter returns short (<36 bytes) responses to + * some INQUIRY requests. + */ + unsigned short_inquiry:1; + + /* * Countdown for host blocking with no commands outstanding. */ unsigned int max_host_blocked;
Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan: INQUIRY result too short (5), using 36' messages on console. This can be problematic for slow consoles. Introduce short_inquiry host template flag to avoid printing error messages for such adapters. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> --- Changes since v1: - This is a successor of previously sent "scsi_scan: move 'INQUIRY result too short' message to debug level" patch. Instead of moving the message to debug level for all adapters introduce a special 'short_inquiry' flag for host template [inspired by James Bottomley]. --- drivers/scsi/scsi_scan.c | 7 ++++--- drivers/scsi/storvsc_drv.c | 1 + include/scsi/scsi_host.h | 6 ++++++ 3 files changed, 11 insertions(+), 3 deletions(-)