| Message ID | 1442062934-13449-4-git-send-email-ivan.ivanov@linaro.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On 09/12, Ivan T. Ivanov wrote: > Stale Event Enable command should be 5 not 8, fix this. > > Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org> > --- > drivers/tty/serial/msm_serial.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h > index 60917d30c6b5..223f961f992a 100644 > --- a/drivers/tty/serial/msm_serial.h > +++ b/drivers/tty/serial/msm_serial.h > @@ -59,7 +59,7 @@ > #define UART_CR_CMD_SET_RFR (13 << 4) > #define UART_CR_CMD_RESET_RFR (14 << 4) > #define UART_CR_CMD_PROTECTION_EN (16 << 4) > -#define UART_CR_CMD_STALE_EVENT_ENABLE (80 << 4) > +#define UART_CR_CMD_STALE_EVENT_ENABLE (5 << 8) I don't get this one 5 << 8 == 80 << 4 so this makes no difference.
> On Sep 19, 2015, at 2:33 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > > On 09/12, Ivan T. Ivanov wrote: >> Stale Event Enable command should be 5 not 8, fix this. >> >> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org> >> --- >> drivers/tty/serial/msm_serial.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h >> index 60917d30c6b5..223f961f992a 100644 >> --- a/drivers/tty/serial/msm_serial.h >> +++ b/drivers/tty/serial/msm_serial.h >> @@ -59,7 +59,7 @@ >> #define UART_CR_CMD_SET_RFR (13 << 4) >> #define UART_CR_CMD_RESET_RFR (14 << 4) >> #define UART_CR_CMD_PROTECTION_EN (16 << 4) >> -#define UART_CR_CMD_STALE_EVENT_ENABLE (80 << 4) >> +#define UART_CR_CMD_STALE_EVENT_ENABLE (5 << 8) > > I don't get this one > > 5 << 8 == 80 << 4 > > so this makes no difference. Uh, of course. It is not 0x80. Regards, Ivan-- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/tty/serial/msm_serial.h b/drivers/tty/serial/msm_serial.h index 60917d30c6b5..223f961f992a 100644 --- a/drivers/tty/serial/msm_serial.h +++ b/drivers/tty/serial/msm_serial.h @@ -59,7 +59,7 @@ #define UART_CR_CMD_SET_RFR (13 << 4) #define UART_CR_CMD_RESET_RFR (14 << 4) #define UART_CR_CMD_PROTECTION_EN (16 << 4) -#define UART_CR_CMD_STALE_EVENT_ENABLE (80 << 4) +#define UART_CR_CMD_STALE_EVENT_ENABLE (5 << 8) #define UART_CR_CMD_FORCE_STALE (4 << 8) #define UART_CR_CMD_RESET_TX_READY (3 << 8) #define UART_CR_TX_DISABLE BIT(3)
Stale Event Enable command should be 5 not 8, fix this. Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org> --- drivers/tty/serial/msm_serial.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html