| Message ID | 1442484788-15482-3-git-send-email-antoine.tenart@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 17, 2015 at 12:13:05PM +0200, Antoine Tenart wrote: > Following the addition of a Berlin PWM driver, this patch adds the > corresponding documentation. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Documentation/devicetree/bindings/pwm/pwm-berlin.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-berlin.txt That's the wrong way around. You define the binding, get concensus that it's okay and then implement the binding in the driver. Of course you'd always provide both the binding and an implementation in the same patch series for convenience, but that doesn't change the logical ordering. > diff --git a/Documentation/devicetree/bindings/pwm/pwm-berlin.txt b/Documentation/devicetree/bindings/pwm/pwm-berlin.txt > new file mode 100644 > index 000000000000..8f9bc11f8c4c > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-berlin.txt > @@ -0,0 +1,19 @@ > +Berlin PWM controller > + > +PWM IP found in Marvell Berlin SoCs. This isn't a proper sentence and doesn't add much useful information. If you want to say anything here, provide details about the PWM controller. > + > +Required properties: > +- compatible: should be "marvell,berlin-pwm" > +- reg: physical base address and length of the controller's registers > +- clocks: phandle to the input clock You should think about adding a clock-names property here as well. Thierry
diff --git a/Documentation/devicetree/bindings/pwm/pwm-berlin.txt b/Documentation/devicetree/bindings/pwm/pwm-berlin.txt new file mode 100644 index 000000000000..8f9bc11f8c4c --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/pwm-berlin.txt @@ -0,0 +1,19 @@ +Berlin PWM controller + +PWM IP found in Marvell Berlin SoCs. + +Required properties: +- compatible: should be "marvell,berlin-pwm" +- reg: physical base address and length of the controller's registers +- clocks: phandle to the input clock +- #pwm-cells: should be 3. See pwm.txt in this directory for a description of + the cells format. + +Example: + +pwm: pwm@f7f20000 { + compatible = "marvell,berlin-pwm"; + reg = <0xf7f20000 0x40>; + clocks = <&chip_clk CLKID_CFG>; + #pwm-cells = <3>; +}