| Message ID | 1442928966-6418-2-git-send-email-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hans de Goede <hdegoede@redhat.com> writes:
> Enable the otg/drc usb controller on the Bananapi.
would something similar apply to the a20 olimex olinuxino micro/lime2
boards?
is there some documentation how to port devicetree improvements/new
features to all boards or to at least help with that? i think you did
some workshop like that?
i think i have seen other features being added only to some boards?
pwm backlight?
audio output?
but my understanding of all of this is really very limited.
thanks,
Jens
Hi, On 23-09-15 10:07, Jens Thiele wrote: > Hans de Goede <hdegoede@redhat.com> writes: > >> Enable the otg/drc usb controller on the Bananapi. > > would something similar apply to the a20 olimex olinuxino micro/lime2 > boards? a20 olimex olinuxino micro already has this in 4.3-rc1, see: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts a20 olimex olinuxino lime2 support is pending: https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-4.4&id=9ff5052f7561068207c2b0e7590ad8ca5765f2cc Regards, Hans > > is there some documentation how to port devicetree improvements/new > features to all boards or to at least help with that? i think you did > some workshop like that? > > i think i have seen other features being added only to some boards? > pwm backlight? > audio output? > but my understanding of all of this is really very limited. > > thanks, > Jens >
On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote: > Enable the otg/drc usb controller on the Bananapi. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Applied all the other patches but this one. Since we dropped the patch adding the regulators support on the Bananapi until we figure out why the board crash, it doesn't compile anymore. Thanks! Maxime
Hi, On 29-09-15 10:04, Maxime Ripard wrote: > On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote: >> Enable the otg/drc usb controller on the Bananapi. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Applied all the other patches but this one. Thanks, seems you did not push this to your git.kernel.org repo though ? > Since we dropped the patch adding the regulators support on the > Bananapi until we figure out why the board crash, it doesn't compile > anymore. How about me doing a v2 of the regulators patch which removes the &cpu0 { cpu-supply = <®_dcdc2>; }; So that we do not get cpu voltage scaling, then the regulator changes should be a NOP, everything should just keep the u-boot set voltages, and we can enable oth support. And then when we've figured out a safe way to enable cpu voltage scaling we can do so with a follow up patch ? Is that a plan ? If so say yes and I'll do a v2 of these patches :) Regards, Hans
Hi, On Tue, Sep 29, 2015 at 10:26:37AM +0200, Hans de Goede wrote: > Hi, > > On 29-09-15 10:04, Maxime Ripard wrote: > >On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote: > >>Enable the otg/drc usb controller on the Bananapi. > >> > >>Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > > >Applied all the other patches but this one. > > Thanks, seems you did not push this to your git.kernel.org repo though ? I think I did, but maybe not at the time you sent the mail. > >Since we dropped the patch adding the regulators support on the > >Bananapi until we figure out why the board crash, it doesn't compile > >anymore. > > How about me doing a v2 of the regulators patch which removes the > > &cpu0 { > cpu-supply = <®_dcdc2>; > }; > > So that we do not get cpu voltage scaling, then the regulator > changes should be a NOP, everything should just keep the u-boot > set voltages, and we can enable oth support. > > And then when we've figured out a safe way to enable cpu voltage > scaling we can do so with a follow up patch ? > > Is that a plan ? If so say yes and I'll do a v2 of these patches :) Yep, it sounds like a good plan :) Maxime
Hi, On 10/01/2015 09:32 AM, Maxime Ripard wrote: > Hi, > > On Tue, Sep 29, 2015 at 10:26:37AM +0200, Hans de Goede wrote: >> Hi, >> >> On 29-09-15 10:04, Maxime Ripard wrote: >>> On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote: >>>> Enable the otg/drc usb controller on the Bananapi. >>>> >>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >>> >>> Applied all the other patches but this one. >> >> Thanks, seems you did not push this to your git.kernel.org repo though ? > > I think I did, but maybe not at the time you sent the mail. > >>> Since we dropped the patch adding the regulators support on the >>> Bananapi until we figure out why the board crash, it doesn't compile >>> anymore. >> >> How about me doing a v2 of the regulators patch which removes the >> >> &cpu0 { >> cpu-supply = <®_dcdc2>; >> }; >> >> So that we do not get cpu voltage scaling, then the regulator >> changes should be a NOP, everything should just keep the u-boot >> set voltages, and we can enable oth support. >> >> And then when we've figured out a safe way to enable cpu voltage >> scaling we can do so with a follow up patch ? >> >> Is that a plan ? If so say yes and I'll do a v2 of these patches :) > > Yep, it sounds like a good plan :) With the new v3 of the regulators patch with the corrected opp-s which was just send this should no longer be necessary, can you apply the original "ARM: dts: sun7i: Enable USB DRC on Bananapi" after applying v3 of the regulators patch please ? Regards, Hans
On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote: > Enable the otg/drc usb controller on the Bananapi. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Applied, thanks! Maxime
On Thu, Oct 08, 2015 at 09:37:39AM +0100, Hans de Goede wrote: > Hi, > > On 10/01/2015 09:32 AM, Maxime Ripard wrote: > >Hi, > > > >On Tue, Sep 29, 2015 at 10:26:37AM +0200, Hans de Goede wrote: > >>Hi, > >> > >>On 29-09-15 10:04, Maxime Ripard wrote: > >>>On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote: > >>>>Enable the otg/drc usb controller on the Bananapi. > >>>> > >>>>Signed-off-by: Hans de Goede <hdegoede@redhat.com> > >>> > >>>Applied all the other patches but this one. > >> > >>Thanks, seems you did not push this to your git.kernel.org repo though ? > > > >I think I did, but maybe not at the time you sent the mail. > > > >>>Since we dropped the patch adding the regulators support on the > >>>Bananapi until we figure out why the board crash, it doesn't compile > >>>anymore. > >> > >>How about me doing a v2 of the regulators patch which removes the > >> > >>&cpu0 { > >> cpu-supply = <®_dcdc2>; > >>}; > >> > >>So that we do not get cpu voltage scaling, then the regulator > >>changes should be a NOP, everything should just keep the u-boot > >>set voltages, and we can enable oth support. > >> > >>And then when we've figured out a safe way to enable cpu voltage > >>scaling we can do so with a follow up patch ? > >> > >>Is that a plan ? If so say yes and I'll do a v2 of these patches :) > > > >Yep, it sounds like a good plan :) > > With the new v3 of the regulators patch with the corrected opp-s which > was just send this should no longer be necessary, can you apply the > original "ARM: dts: sun7i: Enable USB DRC on Bananapi" after applying > v3 of the regulators patch please ? Sure, I just did it. Thanks! Maxime
diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts index 74382f3..61436ad 100644 --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts @@ -159,7 +159,18 @@ status = "okay"; }; +&otg_sram { + status = "okay"; +}; + &pio { + usb0_id_detect_pin: usb0_id_detect_pin@0 { + allwinner,pins = "PH4"; + allwinner,function = "gpio_in"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; + }; + mmc0_cd_pin_bananapi: mmc0_cd_pin@0 { allwinner,pins = "PH10"; allwinner,function = "gpio_in"; @@ -209,6 +220,10 @@ regulator-name = "avcc"; }; +®_usb0_vbus { + status = "okay"; +}; + ®_usb1_vbus { status = "okay"; }; @@ -243,7 +258,21 @@ status = "okay"; }; +&usb_otg { + dr_mode = "otg"; + status = "okay"; +}; + +&usb_power_supply { + status = "okay"; +}; + &usbphy { + pinctrl-names = "default"; + pinctrl-0 = <&usb0_id_detect_pin>; + usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */ + usb0_vbus_power-supply = <&usb_power_supply>; + usb0_vbus-supply = <®_usb0_vbus>; usb1_vbus-supply = <®_usb1_vbus>; usb2_vbus-supply = <®_usb2_vbus>; status = "okay";
Enable the otg/drc usb controller on the Bananapi. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- arch/arm/boot/dts/sun7i-a20-bananapi.dts | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)